ASoC: amd: yc: Enable internal mic on MSI Bravo 17 C7VF
Subsystems (3)
PATCH 1/1 ASoC: amd: yc: Enable internal mic on MSI Bravo 17 C7VF
From: João Miguel <[email protected]>
the board's internal DMIC is on the ACP6x and isn't detected without a DMI quirk entry; this adds it.
--- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -0
@@ -794,6 +794,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M7601RM"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."), + DMI_MATCH(DMI_BOARD_NAME, "MS-17LN"), + } + }, {} };
Signature · 1 line
2.54.0
Hi João Miguel,
Quoted 7 lines · João Miguel
From: João Miguel <[email protected]>
the board's internal DMIC is on the ACP6x and isn't detected without a DMI quirk entry; this adds it.
--- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
While the patch itself looks OK, you're missing the required Signed-off-by tag, which should contain your legal name with surname (I'm assuming Miguel is not your surname, correct me if I'm wrong).
Also, please wrap the commit message at 72 characters. The way it is now makes a very long line hard to read in standard terminals.
Thank you,
Geraldo Nascimento
Quoted 22 lines
sound/soc/amd/yc/acp6x-mach.c +7
-0@@ -794,6 +794,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M7601RM"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."), + DMI_MATCH(DMI_BOARD_NAME, "MS-17LN"), + } + }, {} };Signature · 1 line
2.54.0
Hi Geraldo,
Miguel is indeed my surname.
I will follow up with the required tag, thanks!
Thank you,
João Miguel
Quoted 48 lines · Geraldo Nascimento
Hi João Miguel,
Quoted 3 lines · João Miguel
From: João Miguel <[email protected]>
the board's internal DMIC is on the ACP6x and isn't detected without a
DMI quirk entry; this adds it.
Quoted 4 lines
--- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)While the patch itself looks OK, you're missing the required Signed-off-by tag, which should contain your legal name with surname (I'm assuming Miguel is not your surname, correct me if I'm wrong).
Also, please wrap the commit message at 72 characters. The way it is now makes a very long line hard to read in standard terminals.
Thank you,
Geraldo NascimentoReview
Quoted 1 line
(quoted diff) +0
-0
b/sound/soc/amd/yc/acp6x-mach.csound/soc/amd/yc/acp6x-mach.c static const struct dmi_system_id
Quoted 4 lines
index
7a637d6b5..a93a7fd48100644sound/soc/amd/yc/acp6x-mach.c +0
-0@@ -794,6 +794,13 @@ static const struct dmi_system_idyc_acp_quirk_table[] = {
sound/soc/amd/yc/acp6x-mach.c static const struct dmi_system_id yc_acp_quirk_table[] = {
Quoted 7 lines
sound/soc/amd/yc/acp6x-mach.c +4
-0DMI_MATCH(DMI_PRODUCT_NAME, "M7601RM"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Micro-StarInternational Co., Ltd."),
Quoted 10 lines
sound/soc/amd/yc/acp6x-mach.c +3
-1+ DMI_MATCH(DMI_BOARD_NAME, "MS-17LN"), + } + }, {} }; --2.54.0