Skip to contentSkip to conversation

ASoC: amd: yc: Enable internal mic on MSI Bravo 17 C7VF

PATCH In review João Miguel 3 participants 4 messages May 23 – Jun 2

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: amd: yc: Enable internal mic on MSI Bravo 17 C7VF

The MSI Bravo 17 C7VF routes its internal digital microphone through the ACP6x. The machine driver only enables the DMIC for boards present in the DMI quirk table, so on this model the internal mic is never detected and no capture device is created.

Add a quirk entry matching the board's DMI identifiers so the DMIC is enabled and the internal microphone works.

---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -0
index 7a637d6b5..a93a7fd48 100644
@@ -794,6 +794,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "M7601RM"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
+			DMI_MATCH(DMI_BOARD_NAME, "MS-17LN"),
+		}
+	},
 	{}
 };
 
Signature · 1 line
2.54.0
#1 lore raw
Quoted 10 lines · João Miguel

The MSI Bravo 17 C7VF routes its internal digital microphone through the ACP6x. The machine driver only enables the DMIC for boards present in the DMI quirk table, so on this model the internal mic is never detected and no capture device is created.

Add a quirk entry matching the board's DMI identifiers so the DMIC is enabled and the internal microphone works.

Cc Mark Brown
Quoted 26 lines
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -1
index 7a637d6b5..a93a7fd48 100644
@@ -794,6 +794,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "M7601RM"),
                }
        },
+       {
+               .driver_data = &acp6x_card,
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
+                       DMI_MATCH(DMI_BOARD_NAME, "MS-17LN"),
+               }
+       },
        {}
 };
 
--

2.54.0

#2 lore raw

Hi João,

Quoted 8 lines · Geraldo Nascimento
Quoted 6 lines · João Miguel

The MSI Bravo 17 C7VF routes its internal digital microphone through the ACP6x. The machine driver only enables the DMIC for boards present in the DMI quirk table, so on this model the internal mic is never detected and no capture device is created.

Quoted 6 lines
Quoted 4 lines

Add a quirk entry matching the board's DMI identifiers so the DMIC is enabled and the internal microphone works.

Cc Mark Brown

I'm pretty sure Mark missed this entirely, so feel free to resend the patch but this time remember to use scripts/get_maintainer.pl so your patch lands proeminently on the maintainer's mailbox.

Thanks,
Geraldo Nascimento

Quoted 27 lines
Quoted 27 lines
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -1
index 7a637d6b5..a93a7fd48 100644
@@ -794,6 +794,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "M7601RM"),
                }
        },
+       {
+               .driver_data = &acp6x_card,
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
+                       DMI_MATCH(DMI_BOARD_NAME, "MS-17LN"),
+               }
+       },
        {}
 };
 
--

2.54.0

maintainer
#3 lore raw
In reply to João Miguel
Quoted 1 line · João Miguel

ASoC: amd: yc: Enable internal mic on MSI Bravo 17 C7VF

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1

Thanks!

[1/1] ASoC: amd: yc: Enable internal mic on MSI Bravo 17 C7VF

      https://git.kernel.org/broonie/sound/c/c9c64820a48d

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark