Skip to contentSkip to conversation

staging: rtl8723bs: rename camelcase variable bAllow

PATCH In review Anirban Bose 2 participants 3 messages May 24 – Jul 8 Staging

lore
Share & tools
lore

Anirban Bose

author
#0 lore raw

PATCH 1/1 staging: rtl8723bs: rename camelcase variable bAllow

Rename the local variable 'bAllow' to 'allow' in rtw_cmd_filter() to fix
a checkpatch CamelCase warning.

Signed-off-by Anirban Bose <[email protected]>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +3 -3
index b932670f5d63..aa4a810d8322 100644
@@ -299,12 +299,12 @@ void rtw_free_cmd_priv(struct	cmd_priv *pcmdpriv)
 int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj);
 int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
 {
-	u8 bAllow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */
+	u8 allow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */
 
 	if (cmd_obj->cmdcode == GEN_CMD_CODE(_SetChannelPlan))
-		bAllow = true;
+		allow = true;
 
-	if ((!pcmdpriv->padapter->hw_init_completed && !bAllow) ||
+	if ((!pcmdpriv->padapter->hw_init_completed && !allow) ||
 	    !atomic_read(&pcmdpriv->cmdthd_running))	/* com_thread not running */
 		return _FAIL;
Signature · 1 line
2.54.0
maintainer
#1 lore raw
Quoted 13 lines · Anirban Bose

Rename the local variable 'bAllow' to 'allow' in rtw_cmd_filter() to fix
a checkpatch CamelCase warning.

Signed-off-by Anirban Bose <[email protected]>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +0 -0
index b932670f5d63..aa4a810d8322 100644

drivers/staging/rtl8723bs/core/rtw_cmd.c void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) · line 302

Quoted 5 lines
drivers/staging/rtl8723bs/core/rtw_cmd.c +1 -1
@@ -299,12 +299,12 @@ void rtw_free_cmd_priv(struct	cmd_priv *pcmdpriv)
 int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj);
 int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
 {
-	u8 bAllow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */
+	u8 allow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */

Why isn't this converted to a boolean at the same time?

thanks,

greg k-h

author
#2 lore raw

PATCH v2 1/1 staging: rtl8723bs: rename camelcase variable bAllow

In reply to Anirban Bose

Rename the local variable 'bAllow' to 'allow' in rtw_cmd_filter() to fix a checkpatch CamelCase warning.

Signed-off-by Anirban Bose <[email protected]>

---
v2:
- Changed the variable type to bool (as requested)

---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +3 -3
index aa9ad4d05e36..623ce064d395 100644
@@ -296,12 +296,12 @@ void rtw_free_cmd_priv(struct	cmd_priv *pcmdpriv)
 int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj);
 int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
 {
-	u8 bAllow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */
+	bool allow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */
 
 	if (cmd_obj->cmdcode == SET_CHANNEL_PLAN_CMD)
-		bAllow = true;
+		allow = true;
 
-	if ((!pcmdpriv->padapter->hw_init_completed && !bAllow) ||
+	if ((!pcmdpriv->padapter->hw_init_completed && !allow) ||
 	    !atomic_read(&pcmdpriv->cmdthd_running))	/* com_thread not running */
 		return _FAIL;
Signature · 1 line
2.53.0