regulator: mt6363: select CONFIG_IRQ_DOMAIN
PATCH 1/1 regulator: mt6363: select CONFIG_IRQ_DOMAIN
From: Arnd Bergmann <[email protected]>
When build-testing this driver without CONFIG_IRQ_DOMAIN causes a compile-time error:
drivers/regulator/mt6363-regulator.c: In function 'mt6363_regulator_probe':drivers/regulator/mt6363-regulator.c:884:18: error: implicit declaration of function 'irq_find_host' [-Wimplicit-function-declaration]
884 | domain = irq_find_host(interrupt_parent);
| ^~~~~~~~~~~~~drivers/regulator/mt6363-regulator.c:884:16: error: assignment to 'struct irq_domain *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
884 | domain = irq_find_host(interrupt_parent);
| ^drivers/regulator/mt6363-regulator.c:896:30: error: implicit declaration of function 'irq_create_fwspec_mapping'; did you mean 'irq_create_of_mapping'? [-Wimplicit-function-declaration]
896 | info->virq = irq_create_fwspec_mapping(&fwspec);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| irq_create_of_mappingThis is rather hard to trigger because so many other drivers enable IRQ_DOMAIN already, but I ran into this on an s390 randconfig build.
Ensure this is always enabled using a Kconfig 'select IRQ_DOMAIN' entry, as we do for all other users of this.
--- drivers/regulator/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/regulator/Kconfig +1 -0
@@ -979,6 +979,7 @@ config REGULATOR_MT6363 tristate "MT6363 SPMI PMIC regulator driver" depends on SPMI select REGMAP_SPMI + select IRQ_DOMAIN help Say Y here to enable support for regulators found in the MediaTek MT6363 SPMI PMIC.
Signature · 1 line
2.39.5
Quoted 21 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When build-testing this driver without
CONFIG_IRQ_DOMAINcauses a compile-time error:
drivers/regulator/mt6363-regulator.c: In function 'mt6363_regulator_probe':drivers/regulator/mt6363-regulator.c:884:18: error: implicit declaration of function 'irq_find_host' [-Wimplicit-function-declaration]884 | domain = irq_find_host(interrupt_parent); | ^~~~~~~~~~~~~
drivers/regulator/mt6363-regulator.c:884:16: error: assignment to 'structirq_domain*' from 'int' makes pointer from integer without a cast [-Wint-conversion]
884 | domain =irq_find_host(interrupt_parent);
| ^drivers/regulator/mt6363-regulator.c:896:30: error: implicit declaration of function 'irq_create_fwspec_mapping'; did you mean 'irq_create_of_mapping'? [-Wimplicit-function-declaration]896 | info->virq = irq_create_fwspec_mapping(&fwspec); | ^~~~~~~~~~~~~~~~~~~~~~~~~ | irq_create_of_mappingThis is rather hard to trigger because so many other drivers enable
IRQ_DOMAINalready, but I ran into this on an s390 randconfig build.
Quoted 5 lines
Ensure this is always enabled using a
Kconfig'selectIRQ_DOMAIN' entry, as we do for all other users of this.Fixes 3c36965df808 ("regulator: Add support for MediaTek MT6363 SPMI PMIC Regulators")Signed-off-by Arnd Bergmann <[email protected]>
Mark Brown
maintainerQuoted 1 line · Arnd Bergmann
regulator: mt6363: select
CONFIG_IRQ_DOMAIN
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.1
Thanks!
[1/1] regulator: mt6363: select CONFIG_IRQ_DOMAIN
https://git.kernel.org/broonie/regulator/c/29d87434cb91
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark