Skip to contentSkip to conversation

hyperv: Clean up and fix the guest ID comment in hvgdk.h

PATCH Applied Dexuan Cui 3 participants 3 messages May 27

Subsystems (2)
lore
Share & tools
lore

Dexuan Cui

author maintainer
#0 lore raw

PATCH 1/1 hyperv: Clean up and fix the guest ID comment in hvgdk.h

Change the "64 bit" to "64-bit", and the "Os" to "OS".

Remove the obsolete paragraph since the guideline has been published in the Hypervisor Top Level Functional Specification for many years.

The "OS Type" is 0x1 for Linux, not 0x100.

No functional change.

Fixes 83ba0c4f3f31 ("Drivers: hv: Cleanup the guest ID computation")
---
 include/hyperv/hvgdk.h | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
include/hyperv/hvgdk.h +2 -8
index 384c3f3ff4a5..f538144280ca 100644
@@ -10,18 +10,12 @@
 
 /*
  * The guest OS needs to register the guest ID with the hypervisor.
- * The guest ID is a 64 bit entity and the structure of this ID is
+ * The guest ID is a 64-bit entity and the structure of this ID is
  * specified in the Hyper-V TLFS specification.
  *
- * While the current guideline does not specify how Linux guest ID(s)
- * need to be generated, our plan is to publish the guidelines for
- * Linux and other guest operating systems that currently are hosted
- * on Hyper-V. The implementation here conforms to this yet
- * unpublished guidelines.
- *
  * Bit(s)
  * 63 - Indicates if the OS is Open Source or not; 1 is Open Source
- * 62:56 - Os Type; Linux is 0x100
+ * 62:56 - OS Type; Linux is 0x1
  * 55:48 - Distro specific identification
  * 47:16 - Linux kernel version number
  * 15:0  - Distro specific identification
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Dexuan Cui

Change the "64 bit" to "64-bit", and the "Os" to "OS".

Remove the obsolete paragraph since the guideline has been published in the Hypervisor Top Level Functional Specification for many years.

Quoted 6 lines

The "OS Type" is 0x1 for Linux, not 0x100.

No functional change.

Fixes 83ba0c4f3f31 ("Drivers: hv: Cleanup the guest ID computation")
Quoted 32 lines
---
 include/hyperv/hvgdk.h | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
include/hyperv/hvgdk.h +2 -8
index 384c3f3ff4a5..f538144280ca 100644
@@ -10,18 +10,12 @@
 
 /*
  * The guest OS needs to register the guest ID with the hypervisor.
- * The guest ID is a 64 bit entity and the structure of this ID is
+ * The guest ID is a 64-bit entity and the structure of this ID is
  * specified in the Hyper-V TLFS specification.
  *
- * While the current guideline does not specify how Linux guest ID(s)
- * need to be generated, our plan is to publish the guidelines for
- * Linux and other guest operating systems that currently are hosted
- * on Hyper-V. The implementation here conforms to this yet
- * unpublished guidelines.
- *
  * Bit(s)
  * 63 - Indicates if the OS is Open Source or not; 1 is Open Source
- * 62:56 - Os Type; Linux is 0x100
+ * 62:56 - OS Type; Linux is 0x1
  * 55:48 - Distro specific identification
  * 47:16 - Linux kernel version number
  * 15:0  - Distro specific identification
Signature · 1 line
2.34.1
maintainer Applied
#2 lore raw
Quoted 7 lines · Hamza Mahfooz
Quoted 6 lines · Dexuan Cui

Change the "64 bit" to "64-bit", and the "Os" to "OS".

Remove the obsolete paragraph since the guideline has been published in the Hypervisor Top Level Functional Specification for many years.

Quoted 8 lines
Quoted 6 lines

The "OS Type" is 0x1 for Linux, not 0x100.

No functional change.

Fixes 83ba0c4f3f31 ("Drivers: hv: Cleanup the guest ID computation")

Applied. Thanks.