Add Xiaomi 12 Lite 5G (taoyao) device tree
v7 cover Add Xiaomi 12 Lite 5G (taoyao) device tree
This series adds device tree support for the Xiaomi 12 Lite 5G (taoyao), based on the Qualcomm SM7325 SoC.
The display panel model is unknown, so bootloader-initialized simple-framebuffer is therefore used to expose the display.
Changes in v7:
- Patch no. 1 - no changes
- Patch no. 3 removed. Dmitry Baryskov addressed that in a separate patchset
- Added record-size for ramoops node (reduced pmsg-size by 0x100000) (patch no. 2)
- Fixed unit address for rmtfs_mem (patch no. 2)
- Link to v6:
https://lore.kernel.org/all/[email protected]/
Changes in v6:
- Patch no. 1 - no changes
- Added a comment about reserved gpio ranges (patch no. 2)
- Removed "output-low" property from "hst_bt_en" node (patch no. 2)
- Moved common IPA properties for sm7325 devices to soc's dtsi (patch no. 3)
- Link to v5:
https://lore.kernel.org/all/[email protected]/
Changes in v5:
- Patch no. 1 - no changes
- Change vccq-supply to vccq2-supply in ufs node as it's ufs2.2 (patch no. 2)
- Val's patch for goodix-berlin didn't have effect on my touchscreen, therefore keep the touchscreen szie (no changes in this regard in patch no. 2)
- Link to v4:
https://lore.kernel.org/all/[email protected]/
Changes in v4:
- Patch no. 1 - no changes
- Removed Konrad's R-b tag, please take a look again (patch no. 2)
- Fixed vreg_s2b_0p7 regulator name to spmb2 (patch no. 2)
- Switched bluetooth to wcn6750-pmu (patch no. 2)
- Dropped qcom,local-bd-address-broken as it has no effect (patch no. 2)
- Added wifi calibration variant "Xiaomi_taoyao" (also sent board-2.bin files to ath11k) (patch no. 2)
- Link to v3:
https://lore.kernel.org/all/[email protected]/
Changes in v3:
- Patch no. 1 - no changes
- Drop unit address for framebuffer node (patch no. 2)
- Add Konrad's R-b tag (patch no. 2)
- Link to v2:
https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Add Rob's A-b tag (patch no. 1)
- Add explicit framebuffer_reserved label (patch no. 2)
- Use memory-region for simple-framebuffer (patch no. 2)
- Fix reserved-memory naming: make node names consistent with labels and intended subsystem (CVP/camera/video) (patch no. 2)
- Convert mem-type value from <0x02> to <2> (patch no. 2)
- Fix s2b regulator comment style (patch no. 2)
- Remove unused gpio-reserved-ranges entry (<32 2>) (patch no. 2)
- Link to v1:
https://lore.kernel.org/all/[email protected]/
Stanislav Zaikin (2):
dt-bindings: arm: qcom: Add SM7325 Xiaomi 12 Lite 5G (taoyao)
arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS
.../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm7325-xiaomi-taoyao.dts | 909 ++++++++++++++++++ 3 files changed, 911 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts
Signature · 1 line
2.51.0
PATCH v7 1/2 dt-bindings: arm: qcom: Add SM7325 Xiaomi 12 Lite 5G (taoyao)
Xiaomi 12 Lite 5G (xiaomi,taoyao) is a smartphone based on the SM7325 SoC.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -1041,6 +1041,7 @@ properties: - items: - enum: - nothing,spacewar + - xiaomi,taoyao - const: qcom,sm7325 - items:
Signature · 1 line
2.51.0
PATCH v7 2/2 arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS
In reply to Stanislav ZaikinXiaomi 12 Lite 5G is a handset released in 2022
This commit has the following features working:
- Display (with simple fb)
- Touchscreen
- UFS
- Power and volume buttons
- Pinctrl
- RPM Regulators
- Remoteprocs - wifi, bluetooth
- USB (Device Mode)
--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm7325-xiaomi-taoyao.dts | 909 ++++++++++++++++++ 2 files changed, 910 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -341,6 +341,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm7125-xiaomi-curtana.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7125-xiaomi-joyeuse.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7225-fairphone-fp4.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7325-nothing-spacewar.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm7325-xiaomi-taoyao.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8150-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8150-microsoft-surface-duo.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8150-mtp.dtb
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts new file +909 -0
909 lines not on this page · raw message
Signature · 1 line
2.51.0
[email protected]
AI reviewRe: [PATCH v7 2/2] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The Type-C SBU endpoint in the `pmic-glink` connector node is incorrectly assigned to `port@1`…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Type-C SBU endpoint in the pmic-glink connector node is incorrectly assigned to port@1 instead of port@2. --
commit 9a9b64540450daa489edb83d1eb2b8d095f07b3b
Author: Stanislav Zaikin <[email protected]>
arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS
This commit adds device tree support for the Xiaomi 12 Lite 5G (taoyao), a handset released in 2022. It enables features like display, touchscreen, UFS, pinctrl, regulators, remoteprocs, and USB device mode.
Quoted 5 lines
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts new file +0
-0
[ ... ]
Quoted 25 lines
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts new file +25
-0+ pmic-glink { + compatible = "qcom,sm7325-pmic-glink", + "qcom,qcm6490-pmic-glink", + "qcom,pmic-glink"; + + #address-cells = <1>; + #size-cells = <0>; + + orientation-gpios = <&tlmm 140 GPIO_ACTIVE_HIGH>; + + connector@0 { + compatible = "usb-c-connector"; + reg = <0>; + power-role = "dual"; + data-role = "dual"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + pmic_glink_hs_in: endpoint { + remote-endpoint = <&usb_1_dwc3_hs>;
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts line 107
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts new file +10
-0+ }; + }; + + port@1 { + reg = <1>; + + pmic_glink_sbu: endpoint { + remote-endpoint = <&fsa4480_sbu_mux>; + }; + };
[Severity: Low]
Does this incorrectly assign the Type-C SBU endpoint to port@1 instead of port@2?
According to the standard usb-connector.yaml device tree bindings, port@0 is reserved for High Speed (HS) data lines, port@1 for Super Speed (SS) data lines, and port@2 for Sideband Use (SBU) lines.
Assigning the SBU endpoint to port@1 violates the device tree schema, even if Super Speed lines are not implemented on the device, and could potentially confuse USB Type-C drivers that rely on standard port indices for SBU routing and Alternate Modes.
Quoted 3 lines
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts new file +3
-0+ }; + }; + };
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Re: [PATCH v7 2/2] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS
In reply to Stanislav ZaikinQuoted 20 lines · Stanislav Zaikin
Xiaomi 12 Lite 5G is a handset released in 2022
This commit has the following features working:
- Display (with simple fb)
- Touchscreen
- UFS
- Power and volume buttons
- Pinctrl
- RPM Regulators
- Remoteprocs - wifi, bluetooth
- USB (Device Mode)Signed-off-by Stanislav Zaikin <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm7325-xiaomi-taoyao.dts | 909 ++++++++++++++++++ 2 files changed, 910 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts+&usb_1 {
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts line 877
Quoted 4 lines
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts new file +4
-0+ /* USB 2.0 only */ + qcom,select-utmi-as-pipe-clk; + + dr_mode = "otg";
This is default, it can be dropped.
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts line 878
Quoted 1 line
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts new file +1
-0+ usb-role-switch;
This should go to the SoC DT.
Quoted 8 lines
arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts new file +8
-0+ maximum-speed = "high-speed"; + /* Remove USB3 phy */ + phys = <&usb_1_hsphy>; + phy-names = "usb2-phy"; + + status = "okay"; +}; +
Signature · 2 lines
With best wishes Dmitry