mm-damon-add-synchronous-commit-for-commit_inputs.patch removed from -mm tree
The quilt patch titled
Subject: mm/damon: add synchronous commit for commit_inputs
has been removed from the -mm tree. Its filename was
mm-damon-add-synchronous-commit-for-commit_inputs.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Liew Rui Yan <[email protected]>
Subject: mm/damon: add synchronous commit for commit_inputs
Date: Sun, 26 Apr 2026 16:16:16 -0700
Problem
=======
Writing invalid parameters to sysfs followed by 'commit_inputs=Y' fails silently (no error returned to shell), because the validation happens asynchronously in the kdamond.
Solution
========
To fix this, the commit_inputs_store() callback now uses damon_call() to synchronously commit parameters in the kdamond thread's safe context. This ensures that validation errors are returned immediately to userspace, following the pattern used by DAMON_SYSFS.
Changes
=======
1. Added commit_inputs_store() and commit_inputs_fn() to commit synchronously.
2. Removed handle_commit_inputs().
This change is motivated from another discussion [1].
---
mm/damon/lru_sort.c | 46 +++++++++++++++++++++++++++++++++++------- mm/damon/reclaim.c | 46 +++++++++++++++++++++++++++++++++++------- 2 files changed, 78 insertions(+), 14 deletions(-)
mm/damon/lru_sort.c renamed from mm/damon/lru_sort.c~mm-damon-add-synchronous-commit-for-commit_inputs +39 -7
@@ -39,7 +39,6 @@ static bool enabled __read_mostly;* the re-reading, DAMON_LRU_SORT will be disabled. */ static bool commit_inputs__read_mostly ; -module_param (commit_inputs, bool,0600 );/* * Desired active to [in]active memory ratio in bp (1/10,000).
@@ -340,18 +339,51 @@ out:return err; } -static int damon_lru_sort_handle_commit_inputs (void ) +static int damon_lru_sort_commit_inputs_fn (void *arg) { +return damon_lru_sort_apply_parameters (); +} + +static int damon_lru_sort_commit_inputs_store (const char *val, +const struct kernel_param *kp) +{ +bool commit_inputs_request;int err; +struct damon_call_control control = { + .fn = damon_lru_sort_commit_inputs_fn, + }; + +if (!val) { + commit_inputs_request = true; + }else { + err =kstrtobool (val, &commit_inputs_request); +if (err) +return err; + } -if (!commit_inputs) +if (!commit_inputs_request)return 0 ; - err =damon_lru_sort_apply_parameters (); - commit_inputs = false; -return err; +/* +* Skip damon_call() if ctx is not initialized to avoid +* NULL pointer dereference. +*/ +if (!ctx) +return -EINVAL ; + + err =damon_call (ctx, &control); + +return err ? err : control.return_code; } +static const struct kernel_param_ops commit_inputs_param_ops = { + .flags =KERNEL_PARAM_OPS_FL_NOARG , + .set = damon_lru_sort_commit_inputs_store, + .get = param_get_bool, +}; + +module_param_cb (commit_inputs, &commit_inputs_param_ops, &commit_inputs,0600 ); +static int damon_lru_sort_damon_call_fn (void *arg) {struct damon_ctx *c = arg;
@@ -365,7 +397,7 @@ static int damon_lru_sort_damon_call_fn( damon_lru_sort_cold_stat = s->stat; } -return damon_lru_sort_handle_commit_inputs (); +return 0 ; }static struct damon_call_control call_control = {
mm/damon/reclaim.c renamed from mm/damon/reclaim.c~mm-damon-add-synchronous-commit-for-commit_inputs +39 -7
71 lines not on this page · raw message
_
Patches currently in -mm which might be from [email protected] are
mm-damon-lru_sort-validate-min_region_size-to-be-power-of-2.patch mm-damon-reclaim-validate-min_region_size-to-be-power-of-2.patch