scsi: megaraid_mbox: avoid double kfree()
Subsystems (2)
PATCH 1/1 scsi: megaraid_mbox: avoid double kfree()
From: Arnd Bergmann <[email protected]>
Smatch found a double-free after my recent change:
drivers/scsi/megaraid/megaraid_mbox.c:3474 megaraid_cmm_register()
error: double free of 'adp' (line 3468)
Since the object is no longer allocated in megaraid_cmm_register(), remove the kfree() as well.
--- drivers/scsi/megaraid/megaraid_mm.c | 2 -- 1 file changed, 2 deletions(-)
drivers/scsi/megaraid/megaraid_mm.c +0 -2
@@ -998,8 +998,6 @@ mraid_mm_register_adp(mraid_mmadp_t *adapter)dma_pool_destroy (adapter->pthru_dma_pool); -kfree (adapter); -return rval; }
Signature · 1 line
2.39.5
Martin K. Petersen
AppliedArnd,
Quoted 7 lines
Smatch found a double-free after my recent change:
drivers/scsi/megaraid/megaraid_mbox.c:3474megaraid_cmm_register()
error: double free of 'adp' (line 3468)Since the object is no longer allocated in
megaraid_cmm_register(), remove thekfree()as well.
Applied to 7.2/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen
Martin K. Petersen
AppliedQuoted 9 lines · Arnd Bergmann
Smatch found a double-free after my recent change:
drivers/scsi/megaraid/megaraid_mbox.c:3474megaraid_cmm_register()
error: double free of 'adp' (line 3468)Since the object is no longer allocated in
megaraid_cmm_register(), remove thekfree()as well.[...]
Applied to 7.2/scsi-queue, thanks!
[1/1] scsi: megaraid_mbox: avoid double kfree()
https://git.kernel.org/mkp/scsi/c/c39a9a02bc5d
Signature · 1 line
Martin K. Petersen