mm: page_isolation: avoid unsafe folio reads while scanning compound pages
Subsystems (2)
PATCH v2 1/1 mm: page_isolation: avoid unsafe folio reads while scanning compound pages
From: Kaitao Cheng <[email protected]>
page_is_unmovable() can inspect compound pages without holding a folio reference or any lock. The folio can therefore be freed, split or reused while the scanner is still looking at it.
The existing HugeTLB handling already avoids folio_hstate() for this reason, but it still derives the hstate from folio_size() and later derives the scan step from folio_nr_pages() and folio_page_idx(). These helpers rely on the folio still being a valid folio head. If the folio changed concurrently, the scanner can read inconsistent folio metadata and compute a wrong step. In the worst case, folio_nr_pages() can return 1 for what used to be a tail page and the subtraction from folio_page_idx() can underflow.
There is a similar issue for non-Hugetlb compound pages: folio_test_lru() expects a valid folio. If the previously observed head page has been reused as a tail page of another compound page, the folio flag checks can trigger VM_BUG_ON_PGFLAGS().
Read the compound order once with compound_order(), reject obviously bogus orders, and derive the hstate and scan step from that order instead of querying folio size information again. Also use PageLRU(page), which is safe for the page being scanned, instead of folio_test_lru() on a potentially stale folio pointer.
Treat an unknown HugeTLB hstate as unmovable so the scanner does not try to skip over an unstable HugeTLB folio.
---
Changes in v2:
- Avoid unsafe folio metadata reads in the unlocked scanner by deriving the hstate and scan step from compound_order(). (David Hildenbrand, Andrew Morton)
- Treat invalid compound orders or unknown HugeTLB hstates as unmovable.
- Use PageLRU(page) instead of folio_test_lru(folio) to avoid folio flag checks on a stale folio pointer. ()
- Update the commit log (David Hildenbrand)
Link to v1:
https://lore.kernel.org/all/[email protected]/
--- mm/page_isolation.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-)
mm/page_isolation.c +13 -6
@@ -41,8 +41,14 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* We need not scan over tail pages because we don't * handle each tail page individually in migration. */ -if (PageHuge (page) ||PageCompound (page)) { +if (PageCompound (page)) {struct folio *folio =page_folio (page); +unsigned long nr_pages, pfn; +unsigned int order; + + order =compound_order (&folio->page); +if (order >MAX_FOLIO_ORDER ) +return true;if (folio_test_hugetlb (folio)) {struct hstate *h;
@@ -54,15 +60,16 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* The huge page may be freed so can not * use folio_hstate() directly. */ - h =size_to_hstate (folio_size (folio)); -if (h && !hugepage_migration_supported (h)) + h =size_to_hstate (PAGE_SIZE << order); +if (!h || !hugepage_migration_supported (h))return true; - - }else if (!folio_test_lru (folio)) { + }else if (!PageLRU (page)) {return true; } - *step =folio_nr_pages (folio) -folio_page_idx (folio, page); + nr_pages =1UL << order; + pfn =page_to_pfn (page); + *step = (pfn | (nr_pages -1 )) +1 - pfn;return false; }
Signature · 1 line
2.43.0
Quoted 79 lines · Kaitao Cheng
From: Kaitao Cheng <[email protected]>
page_is_unmovable()can inspect compound pages without holding a folio reference or any lock. The folio can therefore be freed, split or reused while the scanner is still looking at it.The existing HugeTLB handling already avoids
folio_hstate()for this reason, but it still derives the hstate fromfolio_size()and later derives the scan step fromfolio_nr_pages()andfolio_page_idx(). These helpers rely on the folio still being a valid folio head. If the folio changed concurrently, the scanner can read inconsistent folio metadata and compute a wrong step. In the worst case,folio_nr_pages()can return 1 for what used to be a tail page and the subtraction fromfolio_page_idx()can underflow.There is a similar issue for non-Hugetlb compound pages:
folio_test_lru()expects a valid folio. If the previously observed head page has been reused as a tail page of another compound page, the folio flag checks can triggerVM_BUG_ON_PGFLAGS().Read the compound order once with
compound_order(), reject obviously bogus orders, and derive the hstate and scan step from that order instead of querying folio size information again. Also use PageLRU(page), which is safe for the page being scanned, instead offolio_test_lru()on a potentially stale folio pointer.Treat an unknown HugeTLB hstate as unmovable so the scanner does not try to skip over an unstable HugeTLB folio.
Fixes a0a9f2180b90 ("mm: page_isolation: avoid calling folio_hstate() without hugetlb_lock")Signed-off-by Kaitao Cheng <[email protected]>---
Changes in v2:
- Avoid unsafe folio metadata reads in the unlocked scanner by deriving the hstate and scan step fromcompound_order(). (David Hildenbrand, Andrew Morton)
- Treat invalid compound orders or unknown HugeTLB hstates as unmovable.
- Use PageLRU(page) instead offolio_test_lru(folio)to avoid folio flag checks on a stale folio pointer. ()
- Update the commit log (David Hildenbrand)Link to v1:
https://lore.kernel.org/all/[email protected]/--- mm/page_isolation.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-)mm/page_isolation.c +9
-5@@ -41,8 +41,14 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* We need not scan over tail pages because we don't * handle each tail page individually in migration. */ -if (PageHuge (page) ||PageCompound (page)) { +if (PageCompound (page)) {struct folio *folio =page_folio (page); +unsigned long nr_pages, pfn; +unsigned int order; + + order =compound_order (&folio->page); +if (order >MAX_FOLIO_ORDER ) +return true;if (folio_test_hugetlb (folio)) {struct hstate *h;@@ -54,15 +60,16 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* The huge page may be freed so can not * use folio_hstate() directly. */ - h =size_to_hstate (folio_size (folio)); -if (h && !hugepage_migration_supported (h)) + h =size_to_hstate (PAGE_SIZE << order); +if (!h || !hugepage_migration_supported (h))return true; - - }else if (!folio_test_lru (folio)) {
mm/page_isolation.c bool page_is_unmovable(struct zone *zone, struct page *page, · line 74
Quoted 10 lines
mm/page_isolation.c +4
-1+ }else if (!PageLRU (page)) {return true; } - *step =folio_nr_pages (folio) -folio_page_idx (folio, page); + nr_pages =1UL << order; + pfn =page_to_pfn (page); + *step = (pfn | (nr_pages -1 )) +1 - pfn;return false; }
LGTM. Thanks.
Just a comment, order can be dropped and use nr_pages = compound_nr(&folio->page) instead:
1. order > MAX_FOLIO_ORDER -> nr_pages > MAX_FOLIO_NR_PAGES
2. PAGE_SIZE << order -> PAGE_SIZE * nr_pages.
But it is not worth a new version.
Best Regards,
Yan, Zi
Andrew Morton
maintainerQuoted 9 lines · On Tue, 02 Jun 2026 11:02:41 -0400 Zi Yan <[email protected]> wrote:
mm/page_isolation.c bool page_is_unmovable(struct zone *zone, struct page *page, · line 74
Quoted 6 lines
mm/page_isolation.c +3
-1- *step =folio_nr_pages (folio) -folio_page_idx (folio, page); + nr_pages =1UL << order; + pfn =page_to_pfn (page); + *step = (pfn | (nr_pages -1 )) +1 - pfn;return false; }LGTM. Thanks.
Quoted 7 lines
Just a comment, order can be dropped and use
nr_pages=compound_nr(&folio->page)instead:
1. order >MAX_FOLIO_ORDER->nr_pages>MAX_FOLIO_NR_PAGES
2.PAGE_SIZE<< order ->PAGE_SIZE*nr_pages.
But it is not worth a new version.Reviewed-by Zi Yan <[email protected]>
Thanks, I queued this.
What are we to make of Sashiko's question?
https://sashiko.dev/#/patchset/[email protected]
Zi Yan
reviewerQuoted 17 lines · Andrew Morton
Quoted 15 lines · On Tue, 02 Jun 2026 11:02:41 -0400 Zi Yan <[email protected]> wrote:
mm/page_isolation.c bool page_is_unmovable(struct zone *zone, struct page *page, · line 74
Quoted 6 lines
mm/page_isolation.c +3
-1- *step =folio_nr_pages (folio) -folio_page_idx (folio, page); + nr_pages =1UL << order; + pfn =page_to_pfn (page); + *step = (pfn | (nr_pages -1 )) +1 - pfn;return false; }LGTM. Thanks.
Just a comment, order can be dropped and use
nr_pages=compound_nr(&folio->page)instead:
1. order >MAX_FOLIO_ORDER->nr_pages>MAX_FOLIO_NR_PAGES
2.PAGE_SIZE<< order ->PAGE_SIZE*nr_pages.
But it is not worth a new version.
Quoted 6 lines
Quoted 1 line
Reviewed-by Zi Yan <[email protected]>Thanks, I queued this.
What are we to make of Sashiko's question?
https://sashiko.dev/#/patchset/[email protected]
Sashiko asked if compound_order() returns bogus order and the code can skip checking unmovable pages and return false negative (the range has unmovable pages but returning false), leading to offline in-use memory.
Answer is no. 1. order > MAX_FOLIO_ORDER restricts the number of skipped pages; 2. the actual users of page_is_unmovable(), alloc_contig_range() or hot offline, will perform page migration and unmovable pages will fail the migration and prevent these users from doing anything.
Best Regards,
Yan, Zi
Quoted 94 lines · Zi Yan
Quoted 79 lines · Kaitao Cheng
From: Kaitao Cheng <[email protected]>
page_is_unmovable()can inspect compound pages without holding a folio reference or any lock. The folio can therefore be freed, split or reused while the scanner is still looking at it.The existing HugeTLB handling already avoids
folio_hstate()for this reason, but it still derives the hstate fromfolio_size()and later derives the scan step fromfolio_nr_pages()andfolio_page_idx(). These helpers rely on the folio still being a valid folio head. If the folio changed concurrently, the scanner can read inconsistent folio metadata and compute a wrong step. In the worst case,folio_nr_pages()can return 1 for what used to be a tail page and the subtraction fromfolio_page_idx()can underflow.There is a similar issue for non-Hugetlb compound pages:
folio_test_lru()expects a valid folio. If the previously observed head page has been reused as a tail page of another compound page, the folio flag checks can triggerVM_BUG_ON_PGFLAGS().Read the compound order once with
compound_order(), reject obviously bogus orders, and derive the hstate and scan step from that order instead of querying folio size information again. Also use PageLRU(page), which is safe for the page being scanned, instead offolio_test_lru()on a potentially stale folio pointer.Treat an unknown HugeTLB hstate as unmovable so the scanner does not try to skip over an unstable HugeTLB folio.
Fixes a0a9f2180b90 ("mm: page_isolation: avoid calling folio_hstate() without hugetlb_lock")Signed-off-by Kaitao Cheng <[email protected]>---
Changes in v2:
- Avoid unsafe folio metadata reads in the unlocked scanner by deriving the hstate and scan step fromcompound_order(). (David Hildenbrand, Andrew Morton)
- Treat invalid compound orders or unknown HugeTLB hstates as unmovable.
- Use PageLRU(page) instead offolio_test_lru(folio)to avoid folio flag checks on a stale folio pointer. ()
- Update the commit log (David Hildenbrand)Link to v1:
https://lore.kernel.org/all/[email protected]/--- mm/page_isolation.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-)mm/page_isolation.c +9
-5@@ -41,8 +41,14 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* We need not scan over tail pages because we don't * handle each tail page individually in migration. */ -if (PageHuge (page) ||PageCompound (page)) { +if (PageCompound (page)) {struct folio *folio =page_folio (page); +unsigned long nr_pages, pfn; +unsigned int order; + + order =compound_order (&folio->page); +if (order >MAX_FOLIO_ORDER ) +return true;if (folio_test_hugetlb (folio)) {struct hstate *h;@@ -54,15 +60,16 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* The huge page may be freed so can not * use folio_hstate() directly. */ - h =size_to_hstate (folio_size (folio)); -if (h && !hugepage_migration_supported (h)) + h =size_to_hstate (PAGE_SIZE << order); +if (!h || !hugepage_migration_supported (h))return true; - - }else if (!folio_test_lru (folio)) {mm/page_isolation.c bool page_is_unmovable(struct zone *zone, struct page *page, · line 74
Quoted 10 lines
mm/page_isolation.c +4
-1+ }else if (!PageLRU (page)) {return true; } - *step =folio_nr_pages (folio) -folio_page_idx (folio, page); + nr_pages =1UL << order; + pfn =page_to_pfn (page); + *step = (pfn | (nr_pages -1 )) +1 - pfn;return false; }LGTM. Thanks.
Quoted 5 lines
Just a comment, order can be dropped and use
nr_pages=compound_nr(&folio->page)instead:
1. order >MAX_FOLIO_ORDER->nr_pages>MAX_FOLIO_NR_PAGES
2.PAGE_SIZE<< order ->PAGE_SIZE*nr_pages.
But it is not worth a new version.
If we use compound_nr, we have to check for power-of-2, like scan_movable_pages(), as folio_large_nr_pages() might use the per-computed value (which might read garbage).
Signature · 3 lines
Cheers, David
Zi Yan
reviewerQuoted 101 lines · David Hildenbrand (Arm)
Quoted 94 lines · Zi Yan
Quoted 79 lines · Kaitao Cheng
From: Kaitao Cheng <[email protected]>
page_is_unmovable()can inspect compound pages without holding a folio reference or any lock. The folio can therefore be freed, split or reused while the scanner is still looking at it.The existing HugeTLB handling already avoids
folio_hstate()for this reason, but it still derives the hstate fromfolio_size()and later derives the scan step fromfolio_nr_pages()andfolio_page_idx(). These helpers rely on the folio still being a valid folio head. If the folio changed concurrently, the scanner can read inconsistent folio metadata and compute a wrong step. In the worst case,folio_nr_pages()can return 1 for what used to be a tail page and the subtraction fromfolio_page_idx()can underflow.There is a similar issue for non-Hugetlb compound pages:
folio_test_lru()expects a valid folio. If the previously observed head page has been reused as a tail page of another compound page, the folio flag checks can triggerVM_BUG_ON_PGFLAGS().Read the compound order once with
compound_order(), reject obviously bogus orders, and derive the hstate and scan step from that order instead of querying folio size information again. Also use PageLRU(page), which is safe for the page being scanned, instead offolio_test_lru()on a potentially stale folio pointer.Treat an unknown HugeTLB hstate as unmovable so the scanner does not try to skip over an unstable HugeTLB folio.
Fixes a0a9f2180b90 ("mm: page_isolation: avoid calling folio_hstate() without hugetlb_lock")Signed-off-by Kaitao Cheng <[email protected]>---
Changes in v2:
- Avoid unsafe folio metadata reads in the unlocked scanner by deriving the hstate and scan step fromcompound_order(). (David Hildenbrand, Andrew Morton)
- Treat invalid compound orders or unknown HugeTLB hstates as unmovable.
- Use PageLRU(page) instead offolio_test_lru(folio)to avoid folio flag checks on a stale folio pointer. ()
- Update the commit log (David Hildenbrand)Link to v1:
https://lore.kernel.org/all/[email protected]/--- mm/page_isolation.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-)mm/page_isolation.c +9
-5@@ -41,8 +41,14 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* We need not scan over tail pages because we don't * handle each tail page individually in migration. */ -if (PageHuge (page) ||PageCompound (page)) { +if (PageCompound (page)) {struct folio *folio =page_folio (page); +unsigned long nr_pages, pfn; +unsigned int order; + + order =compound_order (&folio->page); +if (order >MAX_FOLIO_ORDER ) +return true;if (folio_test_hugetlb (folio)) {struct hstate *h;@@ -54,15 +60,16 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* The huge page may be freed so can not * use folio_hstate() directly. */ - h =size_to_hstate (folio_size (folio)); -if (h && !hugepage_migration_supported (h)) + h =size_to_hstate (PAGE_SIZE << order); +if (!h || !hugepage_migration_supported (h))return true; - - }else if (!folio_test_lru (folio)) {mm/page_isolation.c bool page_is_unmovable(struct zone *zone, struct page *page, · line 74
Quoted 10 lines
mm/page_isolation.c +4
-1+ }else if (!PageLRU (page)) {return true; } - *step =folio_nr_pages (folio) -folio_page_idx (folio, page); + nr_pages =1UL << order; + pfn =page_to_pfn (page); + *step = (pfn | (nr_pages -1 )) +1 - pfn;return false; }LGTM. Thanks.
Quoted 5 lines
Just a comment, order can be dropped and use
nr_pages=compound_nr(&folio->page)instead:
1. order >MAX_FOLIO_ORDER->nr_pages>MAX_FOLIO_NR_PAGES
2.PAGE_SIZE<< order ->PAGE_SIZE*nr_pages.
But it is not worth a new version.
Quoted 3 lines
If we use
compound_nr, we have to check for power-of-2, likescan_movable_pages(), asfolio_large_nr_pages()might use the per-computed value (which might read garbage).
The power-of-2 requirement comes from “pfn | (nr_pages - 1)”, right? Since otherwise the calculation is going to be bogus.
In terms of reading garbage from either compound_order() or compound_nr(), the code might skip undesired pages. Neither is better.
For the sake of discussion, to use compound_nr(), we probably can use *step = folio_pfn(folio) + nr_pages - page_to_pfn(page) instead.
Best Regards,
Yan, Zi
Quoted 13 lines · Zi Yan
Quoted 11 lines · David Hildenbrand (Arm)
Quoted 9 lines · Zi Yan
LGTM. Thanks.
Just a comment, order can be dropped and use
nr_pages=compound_nr(&folio->page)instead:
1. order >MAX_FOLIO_ORDER->nr_pages>MAX_FOLIO_NR_PAGES
2.PAGE_SIZE<< order ->PAGE_SIZE*nr_pages.
But it is not worth a new version.
Quoted 5 lines
Quoted 3 lines
If we use
compound_nr, we have to check for power-of-2, likescan_movable_pages(), asfolio_large_nr_pages()might use the per-computed value (which might read garbage).The power-of-2 requirement comes from “pfn | (
nr_pages- 1)”, right?
Yes, you could end up stepping backwards, at least in the scan_movable_pages() case.
Signature · 3 lines
Cheers, David
Quoted 53 lines · Kaitao Cheng
From: Kaitao Cheng <[email protected]>
page_is_unmovable()can inspect compound pages without holding a folio reference or any lock. The folio can therefore be freed, split or reused while the scanner is still looking at it.The existing HugeTLB handling already avoids
folio_hstate()for this reason, but it still derives the hstate fromfolio_size()and later derives the scan step fromfolio_nr_pages()andfolio_page_idx(). These helpers rely on the folio still being a valid folio head. If the folio changed concurrently, the scanner can read inconsistent folio metadata and compute a wrong step. In the worst case,folio_nr_pages()can return 1 for what used to be a tail page and the subtraction fromfolio_page_idx()can underflow.There is a similar issue for non-Hugetlb compound pages:
folio_test_lru()expects a valid folio. If the previously observed head page has been reused as a tail page of another compound page, the folio flag checks can triggerVM_BUG_ON_PGFLAGS().Read the compound order once with
compound_order(), reject obviously bogus orders, and derive the hstate and scan step from that order instead of querying folio size information again. Also use PageLRU(page), which is safe for the page being scanned, instead offolio_test_lru()on a potentially stale folio pointer.Treat an unknown HugeTLB hstate as unmovable so the scanner does not try to skip over an unstable HugeTLB folio.
Fixes a0a9f2180b90 ("mm: page_isolation: avoid calling folio_hstate() without hugetlb_lock")Signed-off-by Kaitao Cheng <[email protected]>---
Changes in v2:
- Avoid unsafe folio metadata reads in the unlocked scanner by deriving the hstate and scan step fromcompound_order(). (David Hildenbrand, Andrew Morton)
- Treat invalid compound orders or unknown HugeTLB hstates as unmovable.
- Use PageLRU(page) instead offolio_test_lru(folio)to avoid folio flag checks on a stale folio pointer. ()
- Update the commit log (David Hildenbrand)Link to v1:
https://lore.kernel.org/all/[email protected]/--- mm/page_isolation.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-)mm/page_isolation.c +0
-0
mm/page_isolation.c bool page_is_unmovable(struct zone *zone, struct page *page, · line 44
Quoted 5 lines
mm/page_isolation.c +1
-1@@ -41,8 +41,14 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* We need not scan over tail pages because we don't * handle each tail page individually in migration. */ -if (PageHuge (page) ||PageCompound (page)) { +if (PageCompound (page)) {
Nit: you're not spelling that change out in the patch description, but it's alright.
Quoted 11 lines
mm/page_isolation.c +6
-0struct folio *folio =page_folio (page); +unsigned long nr_pages, pfn; +unsigned int order; + + order =compound_order (&folio->page); +if (order >MAX_FOLIO_ORDER ) +return true;if (folio_test_hugetlb (folio)) {struct hstate *h;
mm/page_isolation.c bool page_is_unmovable(struct zone *zone, struct page *page, · line 64
Quoted 7 lines
mm/page_isolation.c +2
-2@@ -54,15 +60,16 @@ bool page_is_unmovable(struct zone *zone, struct page *page,* The huge page may be freed so can not * use folio_hstate() directly. */ - h =size_to_hstate (folio_size (folio)); -if (h && !hugepage_migration_supported (h)) + h =size_to_hstate (PAGE_SIZE << order); +if (!h || !hugepage_migration_supported (h))
This change might have been better in a separate patch, but it should also be alright (and never really trigger, ever ...).
Signature · 3 lines
Cheers, David
Quoted 26 lines · Kaitao Cheng
From: Kaitao Cheng <[email protected]>
page_is_unmovable()can inspect compound pages without holding a folio reference or any lock. The folio can therefore be freed, split or reused while the scanner is still looking at it.The existing HugeTLB handling already avoids
folio_hstate()for this reason, but it still derives the hstate fromfolio_size()and later derives the scan step fromfolio_nr_pages()andfolio_page_idx(). These helpers rely on the folio still being a valid folio head. If the folio changed concurrently, the scanner can read inconsistent folio metadata and compute a wrong step. In the worst case,folio_nr_pages()can return 1 for what used to be a tail page and the subtraction fromfolio_page_idx()can underflow.There is a similar issue for non-Hugetlb compound pages:
folio_test_lru()expects a valid folio. If the previously observed head page has been reused as a tail page of another compound page, the folio flag checks can triggerVM_BUG_ON_PGFLAGS().Read the compound order once with
compound_order(), reject obviously bogus orders, and derive the hstate and scan step from that order instead of querying folio size information again. Also use PageLRU(page), which is safe for the page being scanned, instead offolio_test_lru()on a potentially stale folio pointer.
Quoted 5 lines
Treat an unknown HugeTLB hstate as unmovable so the scanner does not try to skip over an unstable HugeTLB folio.
Fixes a0a9f2180b90 ("mm: page_isolation: avoid calling folio_hstate() without hugetlb_lock")Signed-off-by Kaitao Cheng <[email protected]>
Signature · 2 lines
Oscar Salvador SUSE Labs
Quoted 41 lines · Kaitao Cheng
From: Kaitao Cheng <[email protected]>
page_is_unmovable()can inspect compound pages without holding a folio reference or any lock. The folio can therefore be freed, split or reused while the scanner is still looking at it.The existing HugeTLB handling already avoids
folio_hstate()for this reason, but it still derives the hstate fromfolio_size()and later derives the scan step fromfolio_nr_pages()andfolio_page_idx(). These helpers rely on the folio still being a valid folio head. If the folio changed concurrently, the scanner can read inconsistent folio metadata and compute a wrong step. In the worst case,folio_nr_pages()can return 1 for what used to be a tail page and the subtraction fromfolio_page_idx()can underflow.There is a similar issue for non-Hugetlb compound pages:
folio_test_lru()expects a valid folio. If the previously observed head page has been reused as a tail page of another compound page, the folio flag checks can triggerVM_BUG_ON_PGFLAGS().Read the compound order once with
compound_order(), reject obviously bogus orders, and derive the hstate and scan step from that order instead of querying folio size information again. Also use PageLRU(page), which is safe for the page being scanned, instead offolio_test_lru()on a potentially stale folio pointer.Treat an unknown HugeTLB hstate as unmovable so the scanner does not try to skip over an unstable HugeTLB folio.
Fixes a0a9f2180b90 ("mm: page_isolation: avoid calling folio_hstate() without hugetlb_lock")Signed-off-by Kaitao Cheng <[email protected]>---
Changes in v2:
- Avoid unsafe folio metadata reads in the unlocked scanner by deriving the hstate and scan step fromcompound_order(). (David Hildenbrand, Andrew Morton)
- Treat invalid compound orders or unknown HugeTLB hstates as unmovable.
- Use PageLRU(page) instead offolio_test_lru(folio)to avoid folio flag checks on a stale folio pointer. ()
- Update the commit log (David Hildenbrand)
Quoted 2 lines
Signature · 2 lines
Oscar Salvador SUSE Labs