tracing: work around -Wmissing-format-attribute warning
Subsystems (20)
PATCH 1/2 tracing: work around -Wmissing-format-attribute warning
From: Arnd Bergmann <[email protected]>
A number of tracing headers turn off -Wsuggest-attribute=format for gcc, but they don't turn it off for clang, so the same warning still happens on new versions of clang that support the format attribute.
To avoid duplicating the same thing in each tracing header, as well as changing all of them to also turn it off for clang, add a new __vsnprintf() helper that is not annotated this way in linux/sprintf.h but is defined to work the same way as the regular vsprintf.
Aside from tracing, the same thing can be used in va_format(), which is part of lib/vsprintf.c itself.
---
This version is a fairly simplistic way to work around the warning reliably. I have resent two more patches to address actually missing annotations in device drivers, but with all of these out of the way, we can move the warning from the 'make W=1' into the default set.
I have also prototyped a variant of this patch that passes down a 'struct va_format' throughout the tracing code. That patch is a little more invasive and I have no idea if that actually works, but the result looks simpler.
--- drivers/infiniband/hw/hfi1/trace_dbg.h | 7 ------- .../broadcom/brcm80211/brcmfmac/tracepoint.h | 7 ------- .../brcm80211/brcmsmac/brcms_trace_brcmsmac_msg.h | 7 ------- drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c | 3 --- include/linux/sprintf.h | 1 + include/linux/trace_events.h | 2 +- include/trace/events/qla.h | 7 ------- include/trace/stages/stage6_event_callback.h | 2 +- lib/vsprintf.c | 12 +++++++----- samples/trace_events/trace-events-sample.c | 2 -- 10 files changed, 10 insertions(+), 40 deletions(-)
drivers/infiniband/hw/hfi1/trace_dbg.h +0 -7
@@ -22,11 +22,6 @@#define MAX_MSG_LEN 512 -#pragma GCC diagnostic push -#ifndef __clang__ -#pragma GCC diagnostic ignored "-Wsuggest-attribute=format" -#endif - DECLARE_EVENT_CLASS(hfi1_trace_template, TP_PROTO(const char *function, struct va_format *vaf), TP_ARGS(function, vaf),
@@ -41,8 +36,6 @@ DECLARE_EVENT_CLASS(hfi1_trace_template, __get_str(msg)) ); -#pragma GCC diagnostic pop -/* * It may be nice to macroize the __hfi1_trace but the va_* stuff requires an * actual function to work and can not be in a macro.
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.h +0 -7
@@ -28,11 +28,6 @@ static inline void trace_ ## name(proto) {}#define MAX_MSG_LEN 100 -#pragma GCC diagnostic push -#ifndef __clang__ -#pragma GCC diagnostic ignored "-Wsuggest-attribute=format" -#endif - TRACE_EVENT(brcmf_err, TP_PROTO(const char *func, struct va_format *vaf), TP_ARGS(func, vaf),
@@ -128,8 +123,6 @@ TRACE_EVENT(brcmf_sdpcm_hdr, __entry->len, ((u8 *)__get_dynamic_array(hdr))[4]) ); -#pragma GCC diagnostic pop -#ifdef CONFIG_BRCM_TRACING #undef TRACE_INCLUDE_PATH
drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_brcmsmac_msg.h +0 -7
@@ -24,11 +24,6 @@#define MAX_MSG_LEN 100 -#pragma GCC diagnostic push -#ifndef __clang__ -#pragma GCC diagnostic ignored "-Wsuggest-attribute=format" -#endif - DECLARE_EVENT_CLASS(brcms_msg_event, TP_PROTO(struct va_format *vaf), TP_ARGS(vaf),
@@ -77,8 +72,6 @@ TRACE_EVENT(brcms_dbg,TP_printk ("%s: %s" ,__get_str (func),__get_str (msg)) ); -#pragma GCC diagnostic pop -#endif /* __TRACE_BRCMSMAC_MSG_H */ #ifdef CONFIG_BRCM_TRACING
drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c +0 -3
@@ -12,9 +12,6 @@#include "iwl-trans.h" #define CREATE_TRACE_POINTS -#ifdef CONFIG_CC_IS_GCC -#pragma GCC diagnostic ignored "-Wsuggest-attribute=format" -#endif #include "iwl-devtrace.h" EXPORT_TRACEPOINT_SYMBOL (iwlwifi_dev_ucode_event);
include/linux/sprintf.h +1 -0
@@ -12,6 +12,7 @@ __printf(2, 3) int sprintf(char *buf, const char * fmt, ...); __printf(2, 0) int vsprintf(char *buf, const char *, va_list); __printf(3, 4) int snprintf(char *buf, size_t size, const char *fmt, ...); __printf(3, 0) int vsnprintf(char *buf, size_t size, const char *fmt, va_list args); +int __vsnprintf (char *buf,size_t size,const char *fmt,va_list args); __printf(3, 4) int scnprintf(char *buf, size_t size, const char *fmt, ...); __printf(3, 0) int vscnprintf(char *buf, size_t size, const char *fmt, va_list args); __printf(2, 3) __malloc char *kasprintf(gfp_t gfp, const char *fmt, ...);
include/linux/trace_events.h +1 -1
@@ -962,7 +962,7 @@ perf_trace_buf_submit(void *raw_data, int size, int rctx, u16 type,int __ret; \ \va_copy (__ap, *(va)); \ - __ret =vsnprintf (NULL ,0 , fmt, __ap) +1 ; \ + __ret =__vsnprintf (NULL ,0 , fmt, __ap) +1 ; \va_end (__ap); \ \min (__ret,TRACE_EVENT_STR_MAX ); \
include/trace/events/qla.h +0 -7
@@ -9,11 +9,6 @@#define QLA_MSG_MAX 256 -#pragma GCC diagnostic push -#ifndef __clang__ -#pragma GCC diagnostic ignored "-Wsuggest-attribute=format" -#endif - DECLARE_EVENT_CLASS(qla_log_event, TP_PROTO(const char *buf, struct va_format *vaf),
@@ -32,8 +27,6 @@ DECLARE_EVENT_CLASS(qla_log_event,TP_printk ("%s %s" ,__get_str (buf),__get_str (msg)) ); -#pragma GCC diagnostic pop -DEFINE_EVENT (qla_log_event, ql_dbg_log, TP_PROTO(const char *buf, struct va_format *vaf), TP_ARGS(buf, vaf)
include/trace/stages/stage6_event_callback.h +1 -1
@@ -45,7 +45,7 @@do { \va_list __cp_va; \va_copy (__cp_va, *(va)); \ -vsnprintf (__get_str (dst),TRACE_EVENT_STR_MAX , fmt, __cp_va); \ +__vsnprintf (__get_str (dst),TRACE_EVENT_STR_MAX , fmt, __cp_va); \va_end (__cp_va); \ }while (0 )
lib/vsprintf.c +7 -5
@@ -1702,9 +1702,6 @@ char *escaped_string(char *buf, char *end, u8 *addr, struct printf_spec spec,return buf; } -__diag_push (); -__diag_ignore (GCC , all,"-Wsuggest-attribute=format" , -"Not a valid __printf() conversion candidate." );static char *va_format (char *buf,char *end,struct va_format *va_fmt,struct printf_spec spec) {
@@ -1714,12 +1711,11 @@ static char *va_format(char *buf, char *end, struct va_format *va_fmt,return buf;va_copy (va, *va_fmt->va); - buf +=vsnprintf (buf, end > buf ? end - buf :0 , va_fmt->fmt, va); + buf +=__vsnprintf (buf, end > buf ? end - buf :0 , va_fmt->fmt, va);va_end (va);return buf; } -__diag_pop ();static noinline_for_stack char *uuid_string(char *buf, char *end, const u8 *addr,
@@ -2979,6 +2975,12 @@ int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) }EXPORT_SYMBOL (vsnprintf); +int __printf(3, 0) __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) +{ +return vsnprintf (buf, size, fmt_str, args); +} +EXPORT_SYMBOL (__vsnprintf); +/** * vscnprintf - Format a string and place it in a buffer * @buf: The buffer to place the result into
samples/trace_events/trace-events-sample.c +0 -2
@@ -9,8 +9,6 @@* creates the handles for the trace points. */ #define CREATE_TRACE_POINTS -__diag_ignore (GCC , all,"-Wsuggest-attribute=format" , -"trace_event_get_offsets_foo_bar can't easily be annotated as __printf" );#include "trace-events-sample.h" static const char *random_strings[] = {
Signature · 1 line
2.39.5
PATCH 2/2 tracing/osnoise: add printf attribute to osnoise_print
From: Arnd Bergmann <[email protected]>
gcc points out that tne newly added function uses printf style arguments and should get an attribute to allow verifying the format strings for its callers:
kernel/trace/trace_osnoise.c: In function 'osnoise_print':kernel/trace/trace_osnoise.c:96:17: error: function 'osnoise_print' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
96 | trace_array_vprintk(tr, _RET_IP_, fmt, ap);
| ^~~~~~~~~~~~~~~~~~~Add the attribute as suggested
--- kernel/trace/trace_osnoise.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_osnoise.c +1 -1
@@ -83,7 +83,7 @@ struct osnoise_instance {static struct list_head osnoise_instances; -static void osnoise_print (const char *fmt, ...) +static __printf(1, 2) void osnoise_print(const char *fmt, ...) { struct osnoise_instance *inst;struct trace_array *tr;
Signature · 1 line
2.39.5
Steven Rostedt
maintainerlib/vsprintf.c int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) · line 2977
Quoted 4 lines · On Tue, 2 Jun 2026 17:07:05 +0200 Arnd Bergmann <[email protected]> wrote:
lib/vsprintf.c +0
-0@@ -2979,6 +2975,12 @@ int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) }EXPORT_SYMBOL (vsnprintf);
Should add a comment here for why this is needed.
-- Steve
Quoted 6 lines
lib/vsprintf.c +6
-0+int __printf(3, 0) __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) +{ +return vsnprintf (buf, size, fmt_str, args); +} +EXPORT_SYMBOL (__vsnprintf); +
Andy Shevchenko
reviewerQuoted 9 lines · Arnd Bergmann
A number of tracing headers turn off -Wsuggest-attribute=format for gcc, but they don't turn it off for clang, so the same warning still happens on new versions of clang that support the format attribute.
To avoid duplicating the same thing in each tracing header, as well as changing all of them to also turn it off for clang, add a new
__vsnprintf()helper that is not annotated this way inlinux/sprintf.hbut is defined to work the same way as the regular vsprintf.
vsprintf()
Quoted 2 lines
Aside from tracing, the same thing can be used in
va_format(), which is part oflib/vsprintf.citself.
...
include/linux/sprintf.h __printf(2, 3) int sprintf(char *buf, const char * fmt, ...); · line 15
Quoted 7 lines
include/linux/sprintf.h +1
-0@@ -12,6 +12,7 @@ __printf(2, 3) int sprintf(char *buf, const char * fmt, ...); __printf(2, 0) int vsprintf(char *buf, const char *, va_list); __printf(3, 4) int snprintf(char *buf, size_t size, const char *fmt, ...); __printf(3, 0) int vsnprintf(char *buf, size_t size, const char *fmt, va_list args); +int __vsnprintf (char *buf,size_t size,const char *fmt,va_list args);
Why the __printf() annotation is in the C file and not here?
Is this all about headers as the second paragraph in the commit message explains? I would add a comment to explain it here, otherwise we might see false patches to "make things consistent" in a wrong way.
Quoted 3 lines
include/linux/sprintf.h +0
-0__printf(3, 4) int scnprintf(char *buf, size_t size, const char *fmt, ...); __printf(3, 0) int vscnprintf(char *buf, size_t size, const char *fmt, va_list args); __printf(2, 3) __malloc char *kasprintf(gfp_t gfp, const char *fmt, ...);
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Arnd Bergmann
A number of tracing headers turn off -Wsuggest-attribute=format for gcc, but they don't turn it off for clang, so the same warning still happens on new versions of clang that support the format attribute.
Quoted 6 lines
Quoted 4 lines
To avoid duplicating the same thing in each tracing header, as well as changing all of them to also turn it off for clang, add a new
__vsnprintf()helper that is not annotated this way inlinux/sprintf.hbut is defined to work the same way as the regular vsprintf.
vsprintf()
Fixed now
Quoted 5 lines
Why the
__printf()annotation is in the C file and not here? Is this all about headers as the second paragraph in the commit message explains?
I would add a comment to explain it here, otherwise we might see false patches to "make things consistent" in a wrong way.
I've tried to come up with a kerneldoc comment now, similar to the one for the vsnprintf() function, and added a separate prototype in the header. Does this address your concern?
Arnd
lib/vsprintf.c +17 -1
@@ -2975,7 +2975,23 @@ int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) }EXPORT_SYMBOL (vsnprintf); -int __printf(3, 0) __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) +/** +* __vsnprintf - vsnprintf() wrapper without __printf() attribute +* @buf: The buffer to place the result into +* @size: The size of the buffer, including the trailing null space +* @fmt_str: The format string to use +* @args: Arguments for the format string +* +* This has the exact same behavior as vsnprintf() but can be used in call +* sites that are missing a __printf() annotation, e.g. because they +* get a 'va_format' argument instead of format and varargs. +* +* For this to work, the attribute is added to the declaration here but +* not in the header. +*/ +int __printf(3, 0) __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args); + +int __vsnprintf (char *buf,size_t size,const char *fmt_str,va_list args) {return vsnprintf (buf, size, fmt_str, args); }
Andy Shevchenko
reviewerQuoted 2 lines · Arnd Bergmann
Quoted 1 line · Andy Shevchenko
On Tue, Jun 02, 2026 at 05:07:05PM +0200, Arnd Bergmann wrote:
...
Quoted 9 lines
Quoted 5 lines
Why the
__printf()annotation is in the C file and not here? Is this all about headers as the second paragraph in the commit message explains?
I would add a comment to explain it here, otherwise we might see false patches to "make things consistent" in a wrong way.I've tried to come up with a kerneldoc comment now, similar to the one for the
vsnprintf()function, and added a separate prototype in the header. Does this address your concern?
Yes, see one nit, though.
Quoted 4 lines
lib/vsprintf.c +3
-1-int __printf(3, 0) __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) +/** +* __vsnprintf - vsnprintf() wrapper without __printf() attribute +* @buf: The buffer to place the result into
lib/vsprintf.c int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) · line 2990
Quoted 10 lines
lib/vsprintf.c +10
-0+* @size: The size of the buffer, including the trailing null space +* @fmt_str: The format string to use +* @args: Arguments for the format string +* +* This has the exact same behavior as vsnprintf() but can be used in call +* sites that are missing a __printf() annotation, e.g. because they +* get a 'va_format' argument instead of format and varargs. +* +* For this to work, the attribute is added to the declaration here but +* not in the header.
+ *
+ * Return: ...
lib/vsprintf.c int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) · line 2994
Quoted 5 lines
+ */
lib/vsprintf.c +3
-0+int __printf(3, 0) __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args); + +int __vsnprintf (char *buf,size_t size,const char *fmt_str,va_list args)
Something slipped here...
Signature · 2 lines
With Best Regards, Andy Shevchenko
Masami Hiramatsu (Google)
maintainerQuoted 17 lines · On Tue, 2 Jun 2026 17:07:05 +0200 Arnd Bergmann <[email protected]> wrote:
include/linux/sprintf.h +1
-0@@ -12,6 +12,7 @@ __printf(2, 3) int sprintf(char *buf, const char * fmt, ...); __printf(2, 0) int vsprintf(char *buf, const char *, va_list); __printf(3, 4) int snprintf(char *buf, size_t size, const char *fmt, ...); __printf(3, 0) int vsnprintf(char *buf, size_t size, const char *fmt, va_list args); +int __vsnprintf (char *buf,size_t size,const char *fmt,va_list args); __printf(3, 4) int scnprintf(char *buf, size_t size, const char *fmt, ...); __printf(3, 0) int vscnprintf(char *buf, size_t size, const char *fmt, va_list args); __printf(2, 3) __malloc char *kasprintf(gfp_t gfp, const char *fmt, ...);include/linux/trace_events.h +0
-0
include/linux/trace_events.h perf_trace_buf_submit(void *raw_data, int size, int rctx, u16 type, · line 968
Quoted 8 lines
include/linux/trace_events.h +1
-1@@ -962,7 +962,7 @@ perf_trace_buf_submit(void *raw_data, int size, int rctx, u16 type,int __ret; \ \va_copy (__ap, *(va)); \ - __ret =vsnprintf (NULL ,0 , fmt, __ap) +1 ; \ + __ret =__vsnprintf (NULL ,0 , fmt, __ap) +1 ; \va_end (__ap); \ \min (__ret,TRACE_EVENT_STR_MAX ); \
I think this is a slightly confusing name. What about vsnprintf_nocheck()?
Thanks,
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>
Andy Shevchenko
reviewerQuoted 2 lines · Masami Hiramatsu
On Tue, 2 Jun 2026 17:07:05 +0200
Arnd Bergmann <[email protected]> wrote:
...
Quoted 1 line
I think this is a slightly confusing name. What about
vsnprintf_nocheck()?
What check? If you want to be more precise: vsnprintf_no_printf_attr() or vsnprintf_no_format_check(). But they also seem to me not the good choices. (Just slight preference to the latter one no_format_check.)
Signature · 2 lines
With Best Regards, Andy Shevchenko
Rasmus Villemoes
reviewerQuoted 47 lines · Arnd Bergmann
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Arnd Bergmann
A number of tracing headers turn off -Wsuggest-attribute=format for gcc, but they don't turn it off for clang, so the same warning still happens on new versions of clang that support the format attribute.
Quoted 6 lines
Quoted 4 lines
To avoid duplicating the same thing in each tracing header, as well as changing all of them to also turn it off for clang, add a new
__vsnprintf()helper that is not annotated this way inlinux/sprintf.hbut is defined to work the same way as the regular vsprintf.
vsprintf()Fixed now
Quoted 5 lines
Why the
__printf()annotation is in the C file and not here? Is this all about headers as the second paragraph in the commit message explains?
I would add a comment to explain it here, otherwise we might see false patches to "make things consistent" in a wrong way.I've tried to come up with a kerneldoc comment now, similar to the one for the
vsnprintf()function, and added a separate prototype in the header. Does this address your concern?Arnd
lib/vsprintf.c +10
-1@@ -2975,7 +2975,23 @@ int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) }EXPORT_SYMBOL (vsnprintf); -int __printf(3, 0) __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) +/** +* __vsnprintf - vsnprintf() wrapper without __printf() attribute +* @buf: The buffer to place the result into +* @size: The size of the buffer, including the trailing null space +* @fmt_str: The format string to use +* @args: Arguments for the format string +* +* This has the exact same behavior as vsnprintf() but can be used in call +* sites that are missing a __printf() annotation, e.g. because they +* get a 'va_format' argument instead of format and varargs.
lib/vsprintf.c int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) · line 2997
Quoted 10 lines
lib/vsprintf.c +7
-0+* +* For this to work, the attribute is added to the declaration here but +* not in the header. +*/ +int __printf(3, 0) __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args); + +int __vsnprintf (char *buf,size_t size,const char *fmt_str,va_list args) {return vsnprintf (buf, size, fmt_str, args); }
May I suggest a different approach, that avoids having that extra function emitted (which presumably compiles to a single jump instruction, but still, with retpoline and CFI and all that it all adds up): Keep the declaration of __vsnprintf() in the header without the __print() attribute, but then do
int __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args)
__alias(vsnprintf);
in vsprintf.c. Aside from reusing the same entry point, I could well imagine a compiler some day complaining about seeing the printf attribute applied in a local extra declaration but not having it in the header file.
Presumably it will need its own EXPORT_SYMBOL if any of the intended users are modular, and it certainly still needs a comment.
Rasmus
Quoted 13 lines · Rasmus Villemoes
Quoted 2 lines · Arnd Bergmann
Quoted 1 line · Andy Shevchenko
On Tue, Jun 02, 2026 at 05:07:05PM +0200, Arnd Bergmann wrote:
May I suggest a different approach, that avoids having that extra function emitted (which presumably compiles to a single jump instruction, but still, with retpoline and CFI and all that it all adds up): Keep the declaration of
__vsnprintf()in the header without the__print()attribute, but then doint
__vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args)
__alias(vsnprintf);
Quoted 7 lines
in
vsprintf.c. Aside from reusing the same entry point, I could well imagine a compiler some day complaining about seeing the printf attribute applied in a local extra declaration but not having it in the header file.Presumably it will need its own
EXPORT_SYMBOLif any of the intended users are modular, and it certainly still needs a comment.
I had tried that earlier but given up because the attributes have to match exactly.
This definition works with all currently supported versions of gcc, but may have to change when the there is a new version that adds even more attributes:
int__printf(3, 0)
__attribute__((nothrow)) __attribute__((nonnull(1)))
__vsnprintf(char *__restrict buf, size_t size,
const char * __restrict fmt_str, va_list args)
__alias(vsnprintf);
We'd probably want to also add __nothrow and __nonnull macros in linux/compiler-attributes.h if we do this.
For reference, see below for the alternative idea I had that avoids adding the __vsnprintf() alias altogether by passing down the va_format using "%pV".
I don't think I actually got this one right in the end since I only build-tested it, but I expect it could be done if someone is able to test and fix all the corner cases properly.
Arnd
include/linux/trace_events.h +2 -5
@@ -956,14 +956,11 @@ perf_trace_buf_submit(void *raw_data, int size, int rctx, u16 type,* gcc warns that you can not use a va_list in an inlined * function. But lets me make it into a macro :-/ */ -#define __trace_event_vstr_len (fmt, va) \ +#define __trace_event_vstr_len (vf) \ ({ \ - va_list __ap; \ int __ret; \ \ - va_copy(__ap, *(va)); \ - __ret = __vsnprintf(NULL, 0, fmt, __ap) + 1; \ - va_end(__ap); \ + __ret = snprintf(NULL, 0, "%pV", vf) + 1; \ \ min(__ret, TRACE_EVENT_STR_MAX); \ })
samples/trace_events/trace-events-sample.h +12 -12
@@ -143,20 +143,20 @@* saved string into the "foo" field. * * __vstring: This is similar to __string() but instead of taking a -* dynamic length, it takes a variable list va_list 'va' variable. +* dynamic length, it takes a variable list va_format 'vaf' variable. * Some event callers already have a message from parameters saved -* in a va_list. Passing in the format and the va_list variable -* will save just enough on the ring buffer for that string. -* Note, the va variable used is a pointer to a va_list, not -* to the va_list directly. +* in a va_format. Passing in the va_format variable will save just +* enough on the ring buffer for that string. * -* (va_list *va) +* (va_format *vaf) * -* __vstring(foo, fmt, va) is similar to: vsnprintf(foo, fmt, va) +* __vstring(foo, vaf) is similar to: +* +* vsnprintf(foo, "%pV", vaf) * * To assign the string, use the helper macro __assign_vstr(). * -* __assign_vstr(foo, fmt, va); +* __assign_vstr(foo, vaf); * * In most cases, the __assign_vstr() macro will take the same * parameters as the __vstring() macro had to declare the string.
@@ -292,9 +292,9 @@ TRACE_EVENT(foo_bar, TP_PROTO(const char *foo, int bar, const int *lst, const char *string, const struct cpumask *mask, - const char *fmt, va_list *va), + struct va_format *vaf), - TP_ARGS(foo, bar, lst, string, mask, fmt, va), + TP_ARGS(foo, bar, lst, string, mask, vaf), TP_STRUCT__entry( __array( char, foo, 10 )
@@ -303,7 +303,7 @@ TRACE_EVENT(foo_bar, __string( str, string ) __bitmask( cpus, num_possible_cpus() ) __cpumask( cpum ) - __vstring( vstr, fmt, va ) + __vstring( vstr, vaf ) __string_len( lstr, foo, bar / 2 < strlen(foo) ? bar / 2 : strlen(foo) ) ),
@@ -314,7 +314,7 @@ TRACE_EVENT(foo_bar, __length_of(lst) * sizeof(int));__assign_str (str);__assign_str (lstr); -__assign_vstr (vstr, fmt, va); +__assign_vstr (vstr, vaf);__assign_bitmask (cpus,cpumask_bits (mask),num_possible_cpus ());__assign_cpumask (cpum,cpumask_bits (mask)); ),
include/trace/stages/stage6_event_callback.h +3 -8
@@ -28,7 +28,7 @@#define __string_len (item, src, len) __dynamic_array(char, item, -1)#undef __vstring -#define __vstring (item, fmt, ap) __dynamic_array(char, item, -1) +#define __vstring (item, vf) __dynamic_array(char, item, -1)#undef __assign_str#define __assign_str (dst) \
@@ -41,13 +41,8 @@ } while (0)#undef __assign_vstr -#define __assign_vstr (dst, fmt, va) \ - do { \ - va_list __cp_va; \ - va_copy(__cp_va, *(va)); \ - __vsnprintf(__get_str(dst), TRACE_EVENT_STR_MAX, fmt, __cp_va); \ - va_end(__cp_va); \ - } while (0) +#define __assign_vstr (dst, vf) \ + snprintf(__get_str(dst), TRACE_EVENT_STR_MAX, "%pV", vf);#undef __bitmask#define __bitmask (item, nr_bits) __dynamic_array(unsigned long, item, -1)
drivers/infiniband/hw/hfi1/trace_dbg.h +2 -2
@@ -26,10 +26,10 @@ DECLARE_EVENT_CLASS(hfi1_trace_template, TP_PROTO(const char *function, struct va_format *vaf),TP_ARGS (function, vaf), TP_STRUCT__entry(__string(function, function) - __vstring(msg, vaf->fmt, vaf->va) +__vstring (msg ,vaf ) ), TP_fast_assign(__assign_str(function); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ), TP_printk("(%s) %s", __get_str(function),
drivers/net/wireless/ath/ath10k/trace.h +4 -4
@@ -52,12 +52,12 @@ DECLARE_EVENT_CLASS(ath10k_log_event,TP_STRUCT__entry ( __string(device, dev_name(ar->dev)) __string(driver, dev_driver_string(ar->dev)) -__vstring (msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(device);__assign_str (driver); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ), TP_printk( "%s %s %s",
@@ -89,13 +89,13 @@ TRACE_EVENT(ath10k_log_dbg, __string(device, dev_name(ar->dev)) __string(driver, dev_driver_string(ar->dev)) __field(unsigned int, level) - __vstring(msg, vaf->fmt, vaf->va) + __vstring(msg, vaf) ), TP_fast_assign( __assign_str(device); __assign_str(driver); __entry->level = level; - __assign_vstr(msg, vaf->fmt, vaf->va); + __assign_vstr(msg, vaf); ), TP_printk( "%s %s %s",
drivers/net/wireless/ath/ath11k/trace.h +2 -2
@@ -127,12 +127,12 @@ DECLARE_EVENT_CLASS(ath11k_log_event,TP_STRUCT__entry ( __string(device, dev_name(ab->dev)) __string(driver, dev_driver_string(ab->dev)) -__vstring (msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(device);__assign_str (driver); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ), TP_printk( "%s %s %s",
drivers/net/wireless/ath/ath6kl/trace.h +4 -4
@@ -253,10 +253,10 @@ DECLARE_EVENT_CLASS(ath6kl_log_event, TP_PROTO(struct va_format *vaf),TP_ARGS (vaf),TP_STRUCT__entry ( - __vstring(msg, vaf->fmt, vaf->va) + __vstring(msg ,vaf ) ),TP_fast_assign ( - __assign_vstr(msg, vaf->fmt, vaf->va); + __assign_vstr(msg, vaf); ), TP_printk("%s", __get_str(msg)) );
@@ -281,11 +281,11 @@ TRACE_EVENT(ath6kl_log_dbg,TP_ARGS (level, vaf),TP_STRUCT__entry ( __field(unsigned int, level) -__vstring (msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __entry->level = level; -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ),TP_printk ("%s" ,__get_str (msg)) );
drivers/net/wireless/ath/trace.h +2 -2
@@ -40,13 +40,13 @@ TRACE_EVENT(ath_log,TP_STRUCT__entry (__string (device ,wiphy_name (wiphy ))__string (driver,KBUILD_MODNAME ) - __vstring(msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(device);__assign_str (driver); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ), TP_printk(
drivers/net/wireless/ath/wil6210/trace.h +2 -2
@@ -70,10 +70,10 @@ DECLARE_EVENT_CLASS(wil6210_log_event, TP_PROTO(struct va_format *vaf),TP_ARGS (vaf),TP_STRUCT__entry ( - __vstring(msg, vaf->fmt, vaf->va) + __vstring(msg ,vaf ) ),TP_fast_assign ( - __assign_vstr(msg, vaf->fmt, vaf->va); + __assign_vstr(msg, vaf); ), TP_printk("%s", __get_str(msg)) );
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.h +4 -4
@@ -33,11 +33,11 @@ TRACE_EVENT(brcmf_err,TP_ARGS (func, vaf),TP_STRUCT__entry ( __string(func, func) -__vstring (msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(func); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ),TP_printk ("%s: %s" ,__get_str (func),__get_str (msg)) );
@@ -48,12 +48,12 @@ TRACE_EVENT(brcmf_dbg,TP_STRUCT__entry (__field (u32 ,level )__string (func, func) - __vstring(msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __entry->level = level;__assign_str (func); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ),TP_printk ("%s: %s" ,__get_str (func),__get_str (msg)) );
drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_brcmsmac_msg.h +4 -4
@@ -28,10 +28,10 @@ DECLARE_EVENT_CLASS(brcms_msg_event, TP_PROTO(struct va_format *vaf),TP_ARGS (vaf),TP_STRUCT__entry ( - __vstring(msg, vaf->fmt, vaf->va) + __vstring(msg ,vaf ) ),TP_fast_assign ( - __assign_vstr(msg, vaf->fmt, vaf->va); + __assign_vstr(msg, vaf); ), TP_printk("%s", __get_str(msg)) );
@@ -62,12 +62,12 @@ TRACE_EVENT(brcms_dbg,TP_STRUCT__entry (__field (u32 ,level )__string (func, func) - __vstring(msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __entry->level = level;__assign_str (func); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ),TP_printk ("%s: %s" ,__get_str (func),__get_str (msg)) );
drivers/net/wireless/intel/iwlwifi/iwl-devtrace-msg.h +4 -4
@@ -18,10 +18,10 @@ DECLARE_EVENT_CLASS(iwlwifi_msg_event, TP_PROTO(struct va_format *vaf),TP_ARGS (vaf),TP_STRUCT__entry ( - __vstring(msg, vaf->fmt, vaf->va) + __vstring(msg ,vaf ) ),TP_fast_assign ( - __assign_vstr(msg, vaf->fmt, vaf->va); + __assign_vstr(msg, vaf); ), TP_printk("%s", __get_str(msg)) );
@@ -53,12 +53,12 @@ TRACE_EVENT(iwlwifi_dbg,TP_STRUCT__entry (__field (u32 ,level )__string (function, function) - __vstring(msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __entry->level = level;__assign_str (function); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ),TP_printk ("%s" ,__get_str (msg)) );
drivers/usb/chipidea/trace.h +2 -2
@@ -28,11 +28,11 @@ TRACE_EVENT(ci_log,TP_ARGS (ci, vaf),TP_STRUCT__entry ( __string(name, dev_name(ci->dev)) -__vstring (msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(name); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ),TP_printk ("%s: %s" ,__get_str (name),__get_str (msg)) );
drivers/usb/host/xhci-trace.h +2 -2
@@ -28,9 +28,9 @@DECLARE_EVENT_CLASS (xhci_log_msg, TP_PROTO(struct va_format *vaf),TP_ARGS (vaf), -TP_STRUCT__entry (__vstring (msg, vaf->fmt, vaf->va)), +TP_STRUCT__entry (__vstring (msg, vaf)),TP_fast_assign ( - __assign_vstr(msg, vaf->fmt, vaf->va); + __assign_vstr(msg, vaf); ),TP_printk ("%s" ,__get_str (msg)) );
drivers/usb/mtu3/mtu3_trace.h +2 -2
@@ -23,11 +23,11 @@ TRACE_EVENT(mtu3_log,TP_ARGS (dev, vaf),TP_STRUCT__entry ( __string(name, dev_name(dev)) -__vstring (msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(name); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ),TP_printk ("%s: %s" ,__get_str (name),__get_str (msg)) );
drivers/usb/musb/musb_trace.h +2 -2
@@ -28,11 +28,11 @@ TRACE_EVENT(musb_log,TP_ARGS (musb, vaf),TP_STRUCT__entry ( __string(name, dev_name(musb->controller)) -__vstring (msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(name); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ),TP_printk ("%s: %s" ,__get_str (name),__get_str (msg)) );
include/trace/events/iscsi.h +2 -2
@@ -26,12 +26,12 @@ DECLARE_EVENT_CLASS(iscsi_log_msg,TP_STRUCT__entry (__string (dname ,dev_name (dev ) ) - __vstring(msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(dname); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ), TP_printk("%s: %s",__get_str(dname), __get_str(msg)
include/trace/events/qla.h +2 -2
@@ -17,11 +17,11 @@ DECLARE_EVENT_CLASS(qla_log_event,TP_STRUCT__entry (__string (buf ,buf ) - __vstring(msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(buf); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ),TP_printk ("%s %s" ,__get_str (buf),__get_str (msg))
include/trace/stages/stage1_struct_define.h +1 -1
@@ -27,7 +27,7 @@#define __string_len (item, src, len) __dynamic_array(char, item, -1)#undef __vstring -#define __vstring (item, fmt, ap) __dynamic_array(char, item, -1) +#define __vstring (item, vf) __dynamic_array(char, item, -1)#undef __bitmask#define __bitmask (item, nr_bits) __dynamic_array(char, item, -1)
include/trace/stages/stage2_data_offsets.h +1 -1
@@ -33,7 +33,7 @@#define __string_len (item, src, len) __dynamic_array(char, item, -1)#undef __vstring -#define __vstring (item, fmt, ap) __dynamic_array(char, item, -1) +#define __vstring (item, vf) __dynamic_array(char, item, -1)#undef __bitmask#define __bitmask (item, nr_bits) __dynamic_array(unsigned long, item, -1)
include/trace/stages/stage4_event_fields.h +1 -1
@@ -42,7 +42,7 @@#define __string_len (item, src, len) __dynamic_array(char, item, -1)#undef __vstring -#define __vstring (item, fmt, ap) __dynamic_array(char, item, -1) +#define __vstring (item, vf) __dynamic_array(char, item, -1)#undef __bitmask#define __bitmask (item, nr_bits) __dynamic_array(unsigned long, item, -1)
include/trace/stages/stage5_get_offsets.h +2 -2
@@ -65,8 +65,8 @@ static inline const char *__string_src(const char *str) __data_offsets->item##_ptr_ = src;#undef __vstring -#define __vstring (item, fmt, ap) __dynamic_array(char, item, \ - __trace_event_vstr_len(fmt, ap)) +#define __vstring (item, vf) __dynamic_array(char, item, \ + __trace_event_vstr_len(vf))#undef __rel_dynamic_array#define __rel_dynamic_array (type, item, len) \
net/batman-adv/trace.h +2 -2
@@ -36,13 +36,13 @@ TRACE_EVENT(batadv_dbg,TP_STRUCT__entry ( __string(device, bat_priv->mesh_iface->name) __string(driver, KBUILD_MODNAME) -__vstring (msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( __assign_str(device);__assign_str (driver); -__assign_vstr (msg, vaf->fmt, vaf->va); +__assign_vstr (msg, vaf); ), TP_printk(
net/mac80211/trace_msg.h +2 -2
@@ -22,11 +22,11 @@ DECLARE_EVENT_CLASS(mac80211_msg_event,TP_ARGS (vaf),TP_STRUCT__entry ( -__vstring (msg, vaf->fmt, vaf->va) +__vstring (msg, vaf) ),TP_fast_assign ( - __assign_vstr(msg, vaf->fmt, vaf->va); + __assign_vstr(msg, vaf); ),TP_printk ("%s" ,__get_str (msg))
samples/trace_events/trace-events-sample.c +3 -1
@@ -23,6 +23,7 @@ static void do_simple_thread_func(int cnt, const char *fmt, ...) {unsigned long bitmask[1 ] = {0xdeadbeefUL };va_list va; +struct va_format vf = { .fmt = fmt };int array[6 ];int len = cnt %5 ;int i;
@@ -35,10 +36,11 @@ static void do_simple_thread_func(int cnt, const char *fmt, ...) array[i] =0 ;va_start (va, fmt); + vf.va = &va;/* Silly tracepoints */ trace_foo_bar ("hello" , cnt, array, random_strings[len], - current->cpus_ptr, fmt, &va); + current->cpus_ptr, &vf);va_end (va);
Quoted 29 lines · Arnd Bergmann
Quoted 13 lines · Rasmus Villemoes
Quoted 2 lines · Arnd Bergmann
Quoted 1 line · Andy Shevchenko
On Tue, Jun 02, 2026 at 05:07:05PM +0200, Arnd Bergmann wrote:
May I suggest a different approach, that avoids having that extra function emitted (which presumably compiles to a single jump instruction, but still, with retpoline and CFI and all that it all adds up): Keep the declaration of
__vsnprintf()in the header without the__print()attribute, but then doint
__vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args)
__alias(vsnprintf);Quoted 7 lines
in
vsprintf.c. Aside from reusing the same entry point, I could well imagine a compiler some day complaining about seeing the printf attribute applied in a local extra declaration but not having it in the header file.Presumably it will need its own
EXPORT_SYMBOLif any of the intended users are modular, and it certainly still needs a comment.I had tried that earlier but given up because the attributes have to match exactly.
This definition works with all currently supported versions of gcc, but may have to change when the there is a new version that adds even more attributes:
Quoted 8 lines
int
__printf(3, 0)
__attribute__((nothrow)) __attribute__((nonnull(1)))
__vsnprintf(char*__restrictbuf,size_tsize,
const char *__restrictfmt_str,va_listargs)
__alias(vsnprintf);
Ah, I see. The documentation for the alias attribute does say that the types have to match, but I didn't know that the nothrow and nonnull attributes were considered part of the type identity. Oddly enough, if one does
typeof(vsnprintf) __vsnprintf __alias(vsnprintf);
that still fails, but only complains about nothrow, not nonnull.
I don't remember what minimum gcc we currently require, but gcc 9 introduced another attribute that is apperently meant for cases like
this: 'copy'. This seems to build:
lib/vsprintf.c +3 -0
@@ -2988,6 +2988,9 @@ int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) }EXPORT_SYMBOL (vsnprintf); +int __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) + __alias(vsnprintf) __attribute__((__copy__(vsnprintf))); +/** * vscnprintf - Format a string and place it in a buffer * @buf: The buffer to place the result into
That at least should handle any future "gcc knows this-or-that about the vsnprintf function". But I don't know if clang supports that copy mechanism or if the minimum supported gcc is too old.
Rasmus
Quoted 59 lines · On Wed, 03 Jun 2026 10:41:18 +0200 "Arnd Bergmann" <[email protected]> wrote:
Quoted 13 lines · Rasmus Villemoes
Quoted 2 lines · Arnd Bergmann
Quoted 1 line · Andy Shevchenko
On Tue, Jun 02, 2026 at 05:07:05PM +0200, Arnd Bergmann wrote:
May I suggest a different approach, that avoids having that extra function emitted (which presumably compiles to a single jump instruction, but still, with retpoline and CFI and all that it all adds up): Keep the declaration of
__vsnprintf()in the header without the__print()attribute, but then doint
__vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args)
__alias(vsnprintf);Quoted 7 lines
in
vsprintf.c. Aside from reusing the same entry point, I could well imagine a compiler some day complaining about seeing the printf attribute applied in a local extra declaration but not having it in the header file.Presumably it will need its own
EXPORT_SYMBOLif any of the intended users are modular, and it certainly still needs a comment.I had tried that earlier but given up because the attributes have to match exactly.
This definition works with all currently supported versions of gcc, but may have to change when the there is a new version that adds even more attributes:
int
__printf(3, 0)
__attribute__((nothrow)) __attribute__((nonnull(1)))
__vsnprintf(char*__restrictbuf,size_tsize,
const char *__restrictfmt_str,va_listargs)
__alias(vsnprintf);We'd probably want to also add
__nothrowand__nonnullmacros inlinux/compiler-attributes.hif we do this.For reference, see below for the alternative idea I had that avoids adding the
__vsnprintf()alias altogether by passing down theva_formatusing "%pV".I don't think I actually got this one right in the end since I only build-tested it, but I expect it could be done if someone is able to test and fix all the corner cases properly.
Arnd
include/linux/trace_events.h +0
-0@@ -956,14 +956,11 @@ perf_trace_buf_submit(void *raw_data, int size, int rctx, u16 type,* gcc warns that you can not use a va_list in an inlined * function. But lets me make it into a macro :-/ */
include/linux/trace_events.h perf_trace_buf_submit(void *raw_data, int size, int rctx, u16 type, · line 963
Quoted 10 lines
include/linux/trace_events.h +2
-5-#define __trace_event_vstr_len (fmt, va) \ +#define __trace_event_vstr_len (vf) \ ({ \ - va_list __ap; \ int __ret; \ \ - va_copy(__ap, *(va)); \ - __ret = __vsnprintf(NULL, 0, fmt, __ap) + 1; \ - va_end(__ap); \ + __ret = snprintf(NULL, 0, "%pV", vf) + 1; \
This adds an extra snprintf call - non-trivial and more stack. Can't you just use the old code with vf->fmt and vf->ap ?
And does the %pV" include the va_copy()?
It isn't normally needed.
Any scheme for avoiding doing the printf processing twice is likely to be a gain.
-- David
Quoted 6 lines · Rasmus Villemoes
Quoted 1 line · Arnd Bergmann
On Wed, Jun 3, 2026, at 09:15, Rasmus Villemoes wrote:
I don't remember what minimum gcc we currently require, but gcc 9 introduced another attribute that is apperently meant for cases like
this: 'copy'.
The minimum version is gcc-8.
Quoted 9 lines
This seems to build:
...lib/vsprintf.c +3
-0+int __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) + __alias(vsnprintf) __attribute__((__copy__(vsnprintf))); +That at least should handle any future "gcc knows this-or-that about the vsnprintf function". But I don't know if clang supports that copy mechanism or if the minimum supported gcc is too old.
clang-22 and gcc-8 don't like the attribute, but also don't complain about the other mismatched attributes, so simply using the __copy() macro we already have will work on all currently supported compilers and likely all future ones as well.
Arnd
Rasmus Villemoes
reviewerQuoted 68 lines · Rasmus Villemoes
Quoted 29 lines · Arnd Bergmann
Quoted 13 lines · Rasmus Villemoes
Quoted 2 lines · Arnd Bergmann
Quoted 1 line · Andy Shevchenko
On Tue, Jun 02, 2026 at 05:07:05PM +0200, Arnd Bergmann wrote:
May I suggest a different approach, that avoids having that extra function emitted (which presumably compiles to a single jump instruction, but still, with retpoline and CFI and all that it all adds up): Keep the declaration of
__vsnprintf()in the header without the__print()attribute, but then doint
__vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args)
__alias(vsnprintf);Quoted 7 lines
in
vsprintf.c. Aside from reusing the same entry point, I could well imagine a compiler some day complaining about seeing the printf attribute applied in a local extra declaration but not having it in the header file.Presumably it will need its own
EXPORT_SYMBOLif any of the intended users are modular, and it certainly still needs a comment.I had tried that earlier but given up because the attributes have to match exactly.
This definition works with all currently supported versions of gcc, but may have to change when the there is a new version that adds even more attributes:
Quoted 8 lines
int
__printf(3, 0)
__attribute__((nothrow)) __attribute__((nonnull(1)))
__vsnprintf(char*__restrictbuf,size_tsize,
const char *__restrictfmt_str,va_listargs)
__alias(vsnprintf);Ah, I see. The documentation for the alias attribute does say that the types have to match, but I didn't know that the nothrow and nonnull attributes were considered part of the type identity. Oddly enough, if one does
typeof(vsnprintf) __vsnprintf __alias(vsnprintf);that still fails, but only complains about nothrow, not nonnull.
I don't remember what minimum gcc we currently require, but gcc 9 introduced another attribute that is apperently meant for cases like
this: 'copy'. This seems to build:lib/vsprintf.c +3
-0@@ -2988,6 +2988,9 @@ int vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) }EXPORT_SYMBOL (vsnprintf); +int __vsnprintf(char *buf, size_t size, const char *fmt_str, va_list args) + __alias(vsnprintf) __attribute__((__copy__(vsnprintf))); +/** * vscnprintf - Format a string and place it in a buffer * @buf: The buffer to place the result into
Quoted 3 lines
That at least should handle any future "gcc knows this-or-that about the vsnprintf function". But I don't know if clang supports that copy mechanism or if the minimum supported gcc is too old.
Ah, so we already have __copy in compiler-attributes.h, stating that it's not supported by clang. Our current minimum gcc version is 8. But judging from the commit message for c0d9782f5, perhaps it's not actually a problem that it just expands to nothing for gcc 8, as the "less restrictive attribute" warning was also introduced with gcc 9, and the __copy macro is already used for module init/exit functions. Which also suggests that it might not be a problem that clang doesn't support it.
Rasmus