net: ibm: emac: Clear MAL descriptors without memset
Subsystems (2)
PATCH v2 1/1 net: ibm: emac: Clear MAL descriptors without memset
Clear MAL descriptor rings with explicit field stores instead of memset(). The descriptor rings are carved from MAL coherent DMA memory, which may be mapped uncached on 32-bit powerpc. The optimized memset() path can use dcbz there and trigger an alignment warning.
Use WRITE_ONCE() for each field to prevent the compiler from merging the stores back into a memset() call.
The skb tracking arrays remain ordinary CPU memory and still use memset().
---
v2: Use WRITE_ONCE
drivers/net/ethernet/ibm/emac/core.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)
drivers/net/ethernet/ibm/emac/core.c +13 -2
@@ -1162,6 +1162,17 @@ static void emac_clean_rx_ring(struct emac_instance *dev) } } +static void emac_clear_mal_desc (struct mal_descriptor *desc,int count) +{ +int i; + +for (i =0 ; i < count; i++) { +WRITE_ONCE (desc[i].ctrl,0 ); +WRITE_ONCE (desc[i].data_len,0 ); +WRITE_ONCE (desc[i].data_ptr,0 ); + } +} +static int __emac_prepare_rx_skb (struct sk_buff *skb,struct emac_instance *dev,int slot) {
@@ -3089,8 +3100,8 @@ static int emac_probe(struct platform_device *ofdev)DBG (dev,"rx_desc %p" NL , dev->rx_desc);/* Clean rings */ -memset (dev->tx_desc,0 ,NUM_TX_BUFF *sizeof (struct mal_descriptor )); -memset (dev->rx_desc,0 ,NUM_RX_BUFF *sizeof (struct mal_descriptor )); +emac_clear_mal_desc (dev->tx_desc,NUM_TX_BUFF ); +emac_clear_mal_desc (dev->rx_desc,NUM_RX_BUFF );memset (dev->tx_skb,0 ,NUM_TX_BUFF *sizeof (struct sk_buff *));memset (dev->rx_skb,0 ,NUM_RX_BUFF *sizeof (struct sk_buff *));
--
2.54.0
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Wed, 3 Jun 2026 16:07:53 -0700 you wrote:
Clear MAL descriptor rings with explicit field stores instead of
memset(). The descriptor rings are carved from MAL coherent DMA memory, which may be mapped uncached on 32-bit powerpc. The optimizedmemset()path can use dcbz there and trigger an alignment warning.Use
WRITE_ONCE()for each field to prevent the compiler from merging the stores back into amemset()call.[...]
Here is the summary with links:
- [PATCHv2,net-next] net: ibm: emac: Clear MAL descriptors without memset
https://git.kernel.org/netdev/net-next/c/f0ba7f385de1
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html