Skip to contentSkip to conversation

ALSA: usb-audio: qcom: Use PAGE_ALIGN macro for buffer size calculation

PATCH In review [email protected] 2 participants 2 messages Jun 5 Sound

lore
Share & tools
lore
#0 lore raw

PATCH v2 4/4 ALSA: usb-audio: qcom: Use PAGE_ALIGN macro for buffer size calculation

From: wangdicheng <[email protected]>

Use the kernel's PAGE_ALIGN() macro instead of open-coding the page alignment calculation. This improves code readability and follows kernel coding style.

The manual calculation:
mult = len / PAGE_SIZE;
remainder = len % PAGE_SIZE;
len = mult * PAGE_SIZE;
len += remainder ? PAGE_SIZE : 0;

is equivalent to:
len = PAGE_ALIGN(len);

---
v1->v2:
Remove unused variables 'remainder' and 'mult' to fix W=1 build warnings reported by kernel test robot.

 sound/usb/qcom/qc_audio_offload.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
sound/usb/qcom/qc_audio_offload.c +1 -6
index fa7ee61d6934..b2b719238b0b 100644
@@ -1042,8 +1042,6 @@ static int uaudio_transfer_buffer_setup(struct snd_usb_substream *subs,
 	u32 len = xfer_buf_len;
 	bool dma_coherent;
 	dma_addr_t xfer_buf_dma_sysdev;
-	u32 remainder;
-	u32 mult;
 	int ret;
 
 	dma_coherent = dev_is_dma_coherent(subs->dev->bus->sysdev);
@@ -1052,10 +1050,7 @@ static int uaudio_transfer_buffer_setup(struct snd_usb_substream *subs,
 	if (!len)
 		len = PAGE_SIZE;
 
-	mult = len / PAGE_SIZE;
-	remainder = len % PAGE_SIZE;
-	len = mult * PAGE_SIZE;
-	len += remainder ? PAGE_SIZE : 0;
+	len = PAGE_ALIGN(len);
 
 	if (len > MAX_XFER_BUFF_LEN) {
 		dev_err(uaudio_qdev->data->dev,
Signature · 1 line
2.25.1
#1 lore raw
Quoted 13 lines · On Fri, 05 Jun 2026 05:16:11 +0200, [email protected] wrote:

From: wangdicheng <[email protected]>

Use the kernel's PAGE_ALIGN() macro instead of open-coding the page alignment calculation. This improves code readability and follows kernel coding style.

The manual calculation:
mult = len / PAGE_SIZE;
remainder = len % PAGE_SIZE;
len = mult * PAGE_SIZE;
len += remainder ? PAGE_SIZE : 0;

Quoted 8 lines

is equivalent to:
len = PAGE_ALIGN(len);

---
v1->v2:
Remove unused variables 'remainder' and 'mult' to fix W=1 build warnings reported by kernel test robot.

This has been already addressed on for-next branch.

thanks,

Takashi