Skip to contentSkip to conversation

net: ncsi: Set ncsi_stop_dev() to inline while NET_NCSI not enabled

PATCH Applied Minda Chen 2 participants 2 messages Jun 5 – Jun 10

Subsystems (2)
lore
Share & tools
lore

Minda Chen

author
#0 lore raw

PATCH 1/1 net: ncsi: Set ncsi_stop_dev() to inline while NET_NCSI not enabled

While NET_NCSI not enabled, ncsi_stop_dev() is not inline and call with it, casue compile waring:

linux/include/net/ncsi.h:63:13: warning: 'ncsi_stop_dev' defined but not used [-Wunused-function]
static void ncsi_stop_dev(struct ncsi_dev *nd)

Setting ncsi_stop_dev() to inline like other function to remove compile warnings.

---
 include/net/ncsi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/ncsi.h +1 -1
index 08a50d9acb0a..e886358207aa 100644
@@ -60,7 +60,7 @@ static inline int ncsi_start_dev(struct ncsi_dev *nd)
 	return -ENOTTY;
 }
 
-static void ncsi_stop_dev(struct ncsi_dev *nd)
+static inline void ncsi_stop_dev(struct ncsi_dev *nd)
 {
 }
 
Signature · 1 line
2.17.1
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Fri, 5 Jun 2026 11:36:07 +0800 you wrote:

While NET_NCSI not enabled, ncsi_stop_dev() is not inline and call with it, casue compile waring:

linux/include/net/ncsi.h:63:13: warning: 'ncsi_stop_dev' defined but not used [-Wunused-function]
static void ncsi_stop_dev(struct ncsi_dev *nd)

[...]

Here is the summary with links:
- [net-next,v1] net: ncsi: Set ncsi_stop_dev() to inline while NET_NCSI not enabled

    https://git.kernel.org/netdev/net-next/c/5c9a6a124afd

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html