target/arm: align down misaligned PMSAv7 MPU region base instead of dropping it
PATCH 1/1 target/arm: align down misaligned PMSAv7 MPU region base instead of dropping it
When a PMSAv7 (ARMv7-M) MPU region's DRBAR base is not aligned to its DRSR region size, get_phys_addr_pmsav7() logged a guest-error and skipped the region entirely (continue). The architecture calls a misaligned base UNPREDICTABLE, but real Cortex-M hardware does not disable the region: RBAR.ADDR is only bits [31:log2(size)], so the sub-size low bits are simply ignored and the region matches against the aligned-down base.
NXP's i.MX95 Cortex-M7 firmware (and the MCUXpresso SDK demos) rely on this. The M7 sets up a deny-all background region (region 0, whole address space, AP=000) and then grants the peripheral space with a 512 MiB region programmed as DRBAR=0x4c800000 - misaligned, intended as 0x40000000. QEMU dropped that region, so a privileged access to e.g. LPUART3 at 0x42570000 fell through to the deny-all region and took a MemManage fault (CFSR.DACCVIOL), trapping the firmware in its default fault handler before it could print anything.
Align the base down to the region size (base &= ~rmask) to match silicon, and keep a (now-accurate) guest-error note. This only changes the previously-UNPREDICTABLE misaligned case; correctly-aligned regions are unaffected.
---
Found while bringing up the i.MX95 Cortex-M7 in an out-of-tree machine
model: the M7's MCUXpresso-SDK firmware programs the misaligned 512 MiB peripheral region described above. With this change the firmware reaches its FreeRTOS/UART banner; without it the region was dropped and the first peripheral access took a MemManage DACCVIOL.
The new branch only executes in the previously-UNPREDICTABLE misaligned case (base & rmask != 0), so correctly-aligned MPU regions are unchanged.
Tested on master: qemu-system-arm builds clean, and the ARMv7-M / MPS2 qtests pass with no regression -- boot-serial (incl. stm32vldiscovery, Cortex-M3), the stm32l4x5 suite (Cortex-M4: exti/gpio/rcc/syscfg/usart), microbit, sse-timer and cmsdk-apb-watchdog.
target/arm/ptw.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
target/arm/ptw.c +17 -4
@@ -2665,11 +2665,24 @@ static bool get_phys_addr_pmsav7(CPUARMState *env, rmask = (1ull << rsize) -1 ;if (base & rmask) { +/* +* The region base is not aligned to the region size. The +* architecture calls this UNPREDICTABLE, but real Cortex-M +* hardware ignores the sub-size low bits of RBAR.ADDR (the +* field is only [31:log2(size)]) and matches against the +* aligned-down base rather than disabling the region. NXP's +* i.MX95 M7 firmware relies on this for its peripheral +* region (e.g. DRBAR 0x4c800000 with a 512MB size, intended +* as 0x40000000), so align down to match silicon instead of +* dropping the region (which would leave the access to fall +* through to a lower-priority deny-all background region). +*/ qemu_log_mask (LOG_GUEST_ERROR , -"DRBAR[%d]: 0x%" PRIx32" misaligned " -"to DRSR region size, mask = 0x%" PRIx32"\n" , - n, base, rmask); -continue ; +"DRBAR[%d]: 0x%" PRIx32" not aligned to DRSR " +"region size (mask 0x%" PRIx32"); aligning down " +"to 0x%" PRIx32" to match Cortex-M behaviour\n" , + n, base, rmask, base & ~rmask); + base &= ~rmask; }if (address < base || address > base + rmask) {
Signature · 1 line
2.34.1
Quoted 9 lines · Kyle Fox
When a PMSAv7 (ARMv7-M) MPU region's DRBAR base is not aligned to its DRSR region size,
get_phys_addr_pmsav7()logged a guest-error and skipped the region entirely (continue). The architecture calls a misaligned base UNPREDICTABLE, but real Cortex-M hardware does not disable the region: RBAR.ADDR is only bits [31:log2(size)], so the sub-size low bits are simply ignored and the region matches against the aligned-down base.
Quoted 8 lines
NXP's i.MX95 Cortex-M7 firmware (and the MCUXpresso SDK demos) rely on this. The M7 sets up a deny-all background region (region 0, whole address space, AP=000) and then grants the peripheral space with a 512 MiB region programmed as DRBAR=0x4c800000 - misaligned, intended as
0x40000000. QEMU dropped that region, so a privileged access to e.g. LPUART3 at0x42570000fell through to the deny-all region and took a MemManage fault (CFSR.DACCVIOL), trapping the firmware in its default fault handler before it could print anything.
This is a guest software bug -- software must not rely on UNPREDICTABLE behaviour, even if the hardware implementation happens to do the same thing every time. Other M-profile CPUs might do something different. The right thing to do here is to fix the broken software...
thanks
-- PMM
Hi Peter,
yeah sorry for sending this in. Based on your feedback I went a bit deeper
and realized what you pointed out: I was chasing a software bug that exists in the guest and QEMU shouldn't emulate one particular implementation's choice as if it were architectural.
It is based on NXP's proprietary M7 sdk firmware which I can't modify. Plan is to clearly document local workaround and see if I can later convince NXP to fix it on their end.
Please drop this one; thanks for the review!!.
-- Kyle
Quoted 28 lines · Peter Maydell
Quoted 9 lines · Kyle Fox
When a PMSAv7 (ARMv7-M) MPU region's DRBAR base is not aligned to its DRSR region size,
get_phys_addr_pmsav7()logged a guest-error and skipped the region entirely (continue). The architecture calls a misaligned base UNPREDICTABLE, but real Cortex-M hardware does not disable the region: RBAR.ADDR is only bits [31:log2(size)], so the sub-size low bits are simply ignored and the region matches against the aligned-down base.Quoted 8 lines
NXP's i.MX95 Cortex-M7 firmware (and the MCUXpresso SDK demos) rely on this. The M7 sets up a deny-all background region (region 0, whole address space, AP=000) and then grants the peripheral space with a 512 MiB region programmed as DRBAR=0x4c800000 - misaligned, intended as
0x40000000. QEMU dropped that region, so a privileged access to e.g. LPUART3 at0x42570000fell through to the deny-all region and took a MemManage fault (CFSR.DACCVIOL), trapping the firmware in its default fault handler before it could print anything.This is a guest software bug -- software must not rely on UNPREDICTABLE behaviour, even if the hardware implementation happens to do the same thing every time. Other M-profile CPUs might do something different. The right thing to do here is to fix the broken software...
thanks
-- PMM
Quoted 10 lines · kylefoxaustin
Hi Peter,
yeah sorry for sending this in. Based on your feedback I went a bit deeper
and realized what you pointed out: I was chasing a software bug that exists in the guest and QEMU shouldn't emulate one particular implementation's choice as if it were architectural.It is based on NXP's proprietary M7 sdk firmware which I can't modify. Plan is to clearly document local workaround and see if I can later convince NXP to fix it on their end.
Thanks. As this isn't a particularly difficult or weird behaviour to implement, I'm not 100% opposed to making QEMU do it, but generally for this kind of thing I would want to see that more than one piece of guest software was assuming this particular UNPREDICTABLE case before we change QEMU.
-- PMM