bpf: reject sleepable BPF_LSM_CGROUP programs at load time
PATCH 1/1 bpf: reject sleepable BPF_LSM_CGROUP programs at load time
The cgroup shim runs under rcu_read_lock_dont_migrate(), so we should not attach any sleepable BPF programs there. Add support to the verifier to explicitly reject attempts to load sleepable BPF programs destined for LSM cgroup attachment.
Without this, we get the following splat from a BPF_LSM_CGROUP program marked BPF_F_SLEEPABLE attached to file_open when it calls bpf_get_dentry_xattr():
BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:1567 in_atomic(): 0, irqs_disabled(): 0, non_block: 0, pid: 34317, name: load preempt_count: 0, expected: 0 RCU nest depth: 2, expected: 0 Call Trace: down_read+0x76/0x480 ext4_xattr_get+0x11f/0x700 __vfs_getxattr+0xf0/0x150 bpf_get_dentry_xattr+0xbb/0xf0 bpf_prog_e76a298dac9218c6_test_open+0x6a/0x85 __cgroup_bpf_run_lsm_current+0x326/0x840 bpf_trampoline_6442534646+0x62/0x14d security_file_open+0x34/0x60 do_dentry_open+0x340/0x1260 vfs_open+0x7a/0x440 path_openat+0x1bac/0x30a0
libbpf provides a .s named section variant for every sleepable program type except lsm_cgroup, reflecting that per-cgroup LSM programs are intended to only run in a non-sleepable context.
The above splat was obtained by bypassing libbpf by using bpf(2) directly.
--- kernel/bpf/verifier.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
kernel/bpf/verifier.c +4 -2
@@ -19099,8 +19099,10 @@ static bool can_be_sleepable(struct bpf_prog *prog)return false; } } -return prog->type ==BPF_PROG_TYPE_LSM || - prog->type ==BPF_PROG_TYPE_KPROBE /* only for uprobes */ || +if (prog->type ==BPF_PROG_TYPE_LSM ) +return prog->expected_attach_type !=BPF_LSM_CGROUP ; + +return prog->type ==BPF_PROG_TYPE_KPROBE /* only for uprobes */ || prog->type ==BPF_PROG_TYPE_STRUCT_OPS || prog->type ==BPF_PROG_TYPE_RAW_TRACEPOINT || prog->type ==BPF_PROG_TYPE_TRACEPOINT ;
Signature · 1 line
2.53.0
Quoted 30 lines · David Windsor
The cgroup shim runs under
rcu_read_lock_dont_migrate(), so we should not attach any sleepable BPF programs there. Add support to the verifier to explicitly reject attempts to load sleepable BPF programs destined for LSM cgroup attachment.Without this, we get the following splat from a
BPF_LSM_CGROUPprogram markedBPF_F_SLEEPABLEattached tofile_openwhen it callsbpf_get_dentry_xattr():BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:1567 in_atomic(): 0, irqs_disabled(): 0, non_block: 0, pid: 34317, name: load preempt_count: 0, expected: 0 RCU nest depth: 2, expected: 0 Call Trace: down_read+0x76/0x480 ext4_xattr_get+0x11f/0x700 __vfs_getxattr+0xf0/0x150 bpf_get_dentry_xattr+0xbb/0xf0 bpf_prog_e76a298dac9218c6_test_open+0x6a/0x85 __cgroup_bpf_run_lsm_current+0x326/0x840 bpf_trampoline_6442534646+0x62/0x14d security_file_open+0x34/0x60 do_dentry_open+0x340/0x1260 vfs_open+0x7a/0x440 path_openat+0x1bac/0x30a0libbpf provides a .s named section variant for every sleepable program type except
lsm_cgroup, reflecting that per-cgroup LSM programs are intended to only run in a non-sleepable context.
Quoted 5 lines
The above splat was obtained by bypassing libbpf by using bpf(2) directly.
Fixes 69fd337a975c ("bpf: per-cgroup lsm flavor")Signed-off-by David Windsor <[email protected]>
Quoted 31 lines · David Windsor
The cgroup shim runs under
rcu_read_lock_dont_migrate(), so we should not attach any sleepable BPF programs there. Add support to the verifier to explicitly reject attempts to load sleepable BPF programs destined for LSM cgroup attachment.Without this, we get the following splat from a
BPF_LSM_CGROUPprogram markedBPF_F_SLEEPABLEattached tofile_openwhen it callsbpf_get_dentry_xattr():BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:1567 in_atomic(): 0, irqs_disabled(): 0, non_block: 0, pid: 34317, name: load preempt_count: 0, expected: 0 RCU nest depth: 2, expected: 0 Call Trace: down_read+0x76/0x480 ext4_xattr_get+0x11f/0x700 __vfs_getxattr+0xf0/0x150 bpf_get_dentry_xattr+0xbb/0xf0 bpf_prog_e76a298dac9218c6_test_open+0x6a/0x85 __cgroup_bpf_run_lsm_current+0x326/0x840 bpf_trampoline_6442534646+0x62/0x14d security_file_open+0x34/0x60 do_dentry_open+0x340/0x1260 vfs_open+0x7a/0x440 path_openat+0x1bac/0x30a0libbpf provides a .s named section variant for every sleepable program type except
lsm_cgroup, reflecting that per-cgroup LSM programs are intended to only run in a non-sleepable context.
Quoted 5 lines
The above splat was obtained by bypassing libbpf by using bpf(2) directly.
Fixes 69fd337a975c ("bpf: per-cgroup lsm flavor")Signed-off-by David Windsor <[email protected]>
We should add a "__failure __msg(...)" selftest for the reject case.
Other than this:
This patch was applied to bpf/bpf-next.git (master) by Kumar Kartikeya Dwivedi <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Kumar Kartikeya Dwivedi <[email protected]>:
Quoted 10 lines · On Fri, 5 Jun 2026 10:57:07 -0400 you wrote:
The cgroup shim runs under
rcu_read_lock_dont_migrate(), so we should not attach any sleepable BPF programs there. Add support to the verifier to explicitly reject attempts to load sleepable BPF programs destined for LSM cgroup attachment.Without this, we get the following splat from a
BPF_LSM_CGROUPprogram markedBPF_F_SLEEPABLEattached tofile_openwhen it callsbpf_get_dentry_xattr():[...]
Here is the summary with links:
- [bpf-next] bpf: reject sleepable BPF_LSM_CGROUP programs at load time
https://git.kernel.org/bpf/bpf-next/c/5b038319be44
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Kumar Kartikeya Dwivedi
maintainerQuoted 32 lines · Song Liu
Quoted 31 lines · David Windsor
The cgroup shim runs under
rcu_read_lock_dont_migrate(), so we should not attach any sleepable BPF programs there. Add support to the verifier to explicitly reject attempts to load sleepable BPF programs destined for LSM cgroup attachment.Without this, we get the following splat from a
BPF_LSM_CGROUPprogram markedBPF_F_SLEEPABLEattached tofile_openwhen it callsbpf_get_dentry_xattr():BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:1567 in_atomic(): 0, irqs_disabled(): 0, non_block: 0, pid: 34317, name: load preempt_count: 0, expected: 0 RCU nest depth: 2, expected: 0 Call Trace: down_read+0x76/0x480 ext4_xattr_get+0x11f/0x700 __vfs_getxattr+0xf0/0x150 bpf_get_dentry_xattr+0xbb/0xf0 bpf_prog_e76a298dac9218c6_test_open+0x6a/0x85 __cgroup_bpf_run_lsm_current+0x326/0x840 bpf_trampoline_6442534646+0x62/0x14d security_file_open+0x34/0x60 do_dentry_open+0x340/0x1260 vfs_open+0x7a/0x440 path_openat+0x1bac/0x30a0libbpf provides a .s named section variant for every sleepable program type except
lsm_cgroup, reflecting that per-cgroup LSM programs are intended to only run in a non-sleepable context.
Quoted 8 lines
Quoted 5 lines
The above splat was obtained by bypassing libbpf by using bpf(2) directly.
Fixes 69fd337a975c ("bpf: per-cgroup lsm flavor")Signed-off-by David Windsor <[email protected]>We should add a "
__failure__msg(...)" selftest for the reject case.
David,
Please follow up with selftest for the fix.
Quoted 37 lines · Kumar Kartikeya Dwivedi
Quoted 35 lines · Song Liu
Quoted 34 lines · David Windsor
The cgroup shim runs under
rcu_read_lock_dont_migrate(), so we should not attach any sleepable BPF programs there. Add support to the verifier to explicitly reject attempts to load sleepable BPF programs destined for LSM cgroup attachment.Without this, we get the following splat from a
BPF_LSM_CGROUPprogram markedBPF_F_SLEEPABLEattached tofile_openwhen it callsbpf_get_dentry_xattr():BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:1567 in_atomic(): 0, irqs_disabled(): 0, non_block: 0, pid: 34317, name: load preempt_count: 0, expected: 0 RCU nest depth: 2, expected: 0 Call Trace: down_read+0x76/0x480 ext4_xattr_get+0x11f/0x700 __vfs_getxattr+0xf0/0x150 bpf_get_dentry_xattr+0xbb/0xf0 bpf_prog_e76a298dac9218c6_test_open+0x6a/0x85 __cgroup_bpf_run_lsm_current+0x326/0x840 bpf_trampoline_6442534646+0x62/0x14d security_file_open+0x34/0x60 do_dentry_open+0x340/0x1260 vfs_open+0x7a/0x440 path_openat+0x1bac/0x30a0libbpf provides a .s named section variant for every sleepable program type except
lsm_cgroup, reflecting that per-cgroup LSM programs are intended to only run in a non-sleepable context.The above splat was obtained by bypassing libbpf by using bpf(2) directly.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Fixes 69fd337a975c ("bpf: per-cgroup lsm flavor")Signed-off-by David Windsor <[email protected]>We should add a "
__failure__msg(...)" selftest for the reject case.David,
Please follow up with selftest for the fix.
Thanks, will do.
If this gets selected for backporting, it'll fail on 6.1 and another version; I can send the fixups if needed.