hfs: return -EIO instead of BUG() in hfs_write_inode()
Subsystems (2)
PATCH 1/1 hfs: return -EIO instead of BUG() in hfs_write_inode()
hfs: return -EIO instead of BUG() in hfs_write_inode()
A corrupted or otherwise malformed HFS filesystem image can reach the default case in hfs_write_inode(). The current code calls BUG() there, which turns an on-disk filesystem condition into a kernel crash.
Return -EIO instead. The function already has an error-return path at that location, so this preserves the existing failure semantics while avoiding a reachable kernel BUG.
The issue is reproducible with the public syzbot C reproducer linked below. Before this change, the reproducer triggers a kernel BUG at fs/hfs/inode.c with RIP in hfs_write_inode(). After this change, the same reproducer no longer triggers kernel BUG, hfs_write_inode, KASAN, Oops, Call Trace, or RIP evidence in the validation window.
--- fs/hfs/inode.c | 1 - 1 file changed, 1 deletion(-)
fs/hfs/inode.c +0 -1
@@ -471,7 +471,6 @@ int hfs_write_inode(struct inode *inode, struct writeback_control *wbc)hfs_btree_write (HFS_SB (inode->i_sb)->cat_tree);return 0 ;default : -BUG ();return -EIO ; } }
Quoted 29 lines · David Maximiliano Hermitte
hfs: return
-EIOinstead ofBUG()inhfs_write_inode()A corrupted or otherwise malformed HFS filesystem image can reach the default case in
hfs_write_inode(). The current code callsBUG()there, which turns an on-disk filesystem condition into a kernel crash.Return
-EIOinstead. The function already has an error-return path at that location, so this preserves the existing failure semantics while avoiding a reachable kernel BUG.The issue is reproducible with the public syzbot C reproducer linked below. Before this change, the reproducer triggers a kernel BUG at
fs/hfs/inode.cwith RIP inhfs_write_inode(). After this change, the same reproducer no longer triggers kernel BUG,hfs_write_inode, KASAN, Oops, Call Trace, or RIP evidence in the validation window.Reported-by [email protected]Signed-off-by David Maximiliano Hermitte <[email protected]>--- fs/hfs/inode.c | 1 - 1 file changed, 1 deletion(-)fs/hfs/inode.c +0
-0
fs/hfs/inode.c int hfs_write_inode(struct inode *inode, struct writeback_control *wbc) · line 474
Quoted 5 lines
fs/hfs/inode.c +0
-1@@ -471,7 +471,6 @@ int hfs_write_inode(struct inode *inode, struct writeback_control *wbc)hfs_btree_write (HFS_SB (inode->i_sb)->cat_tree);return 0 ;default : -BUG ();return -EIO ;
If it's a metadata corruption, shouldn't you return EFSCORRUPTED like the other major filesystems?
--D
Quoted 3 lines
fs/hfs/inode.c +0
-0} }