drivers/clk/clk_test: Use strscpy() to copy the test description
PATCH 1/1 drivers/clk/clk_test: Use strscpy() to copy the test description
From: David Laight <[email protected]>
The buffer length is known to be KUNIT_PARAM_DESC_SIZE
---
This is one of a group of patches that remove potentially unbounded strcpy() calls.
They are mostly replaced by strscpy() or, when strlen() has just been called, with memcpy() (usually including the '\0').
Calls with copy string literals into arrays are left unchanged. They are safe and easily detected as such.
The changes were made by getting the compiler to detect the calls and then fixing the code by hand.
Note that all the changes are only compile tested.
Some Makefiles were changed to allow files to contain strcpy(). As well as 'difficult to fix' files, this included 'show' functions as they really need to use sysfs_emit() or seq_printf().
All the patches are being sent individually to avoid very long cc lists. Apologies for the terse commit messages and likely unexpected tags. (There are about 100 patches in total.)
drivers/clk/clk_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/clk_test.c +2 -2
@@ -2232,7 +2232,7 @@ static voidclk_leaf_mux_set_rate_parent_determine_rate_test_case_to_desc ( const struct clk_leaf_mux_set_rate_parent_determine_rate_test_case *t, char *desc) { - strcpy(desc, t->desc); + strscpy(desc, t->desc, KUNIT_PARAM_DESC_SIZE); } static const struct clk_leaf_mux_set_rate_parent_determine_rate_test_case
@@ -2644,7 +2644,7 @@ static voidclk_register_clk_parent_data_test_case_to_desc ( const struct clk_register_clk_parent_data_test_case *t, char *desc) { - strcpy(desc, t->desc); + strscpy(desc, t->desc, KUNIT_PARAM_DESC_SIZE); } static const struct clk_register_clk_parent_data_test_case
Signature · 1 line
2.39.5
Quoted 5 lines · On Sat, Jun 06, 2026 at 09:26:29PM +0100, [email protected] wrote:
From: David Laight <[email protected]>
The buffer length is known to be
KUNIT_PARAM_DESC_SIZESigned-off-by David Laight <[email protected]>