drivers/net/ethernet/qualcomm/emac: Use strscpy() to copy the ethtool strings
Subsystems (3)
PATCH 1/1 drivers/net/ethernet/qualcomm/emac: Use strscpy() to copy the ethtool strings
From: David Laight <[email protected]>
While the string is short it is still best to use strscpy() with length ETH_GSTRING_LEN.
Should still get optimised to a memcpy().
---
This is one of a group of patches that remove potentially unbounded strcpy() calls.
They are mostly replaced by strscpy() or, when strlen() has just been called, with memcpy() (usually including the '\0').
Calls with copy string literals into arrays are left unchanged. They are safe and easily detected as such.
The changes were made by getting the compiler to detect the calls and then fixing the code by hand.
Note that all the changes are only compile tested.
Some Makefiles were changed to allow files to contain strcpy(). As well as 'difficult to fix' files, this included 'show' functions as they really need to use sysfs_emit() or seq_printf().
All the patches are being sent individually to avoid very long cc lists. Apologies for the terse commit messages and likely unexpected tags. (There are about 100 patches in total.)
drivers/net/ethernet/qualcomm/emac/emac-ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/qualcomm/emac/emac-ethtool.c +1 -1
@@ -95,7 +95,7 @@ static void emac_get_strings(struct net_device *netdev, u32 stringset, u8 *data)switch (stringset) {case ETH_SS_PRIV_FLAGS : -strcpy (data,"single-pause-mode" ); +strscpy (data,"single-pause-mode" ,ETH_GSTRING_LEN );break ;case ETH_SS_STATS :
Signature · 1 line
2.39.5
Timur Tabi
maintainerdrivers/net/ethernet/qualcomm/emac/emac-ethtool.c static void emac_get_strings(struct net_device *netdev, u32 stringset, u8 *data) · line 99
Quoted 12 lines · On Mon, Jun 8, 2026 at 4:55 AM <[email protected]> wrote:
drivers/net/ethernet/qualcomm/emac/emac-ethtool.c +1
-1@@ -95,7 +95,7 @@ static void emac_get_strings(struct net_device *netdev, u32 stringset, u8 *data)switch (stringset) {case ETH_SS_PRIV_FLAGS : -strcpy (data,"single-pause-mode" ); +strscpy (data,"single-pause-mode" ,ETH_GSTRING_LEN );break ;
It would be better to replace this with a call to ethtool_sprintf(), which already takes ETH_GSTRING_LEN into account. And may as well update the ETH_SS_STATS case underneath it.
Quoted 4 lines
drivers/net/ethernet/qualcomm/emac/emac-ethtool.c +0
-1case ETH_SS_STATS : --2.39.5
Timur Tabi
maintainerQuoted 3 lines · Timur Tabi
It would be better to replace this with a call to
ethtool_sprintf(), which already takesETH_GSTRING_LENinto account. And may as well update theETH_SS_STATScase underneath it.
Actually, on second thought, I take that back. There are no format strings, so no need for sprintf.
drivers/net/ethernet/qualcomm/emac/emac-ethtool.c static void emac_get_strings(struct net_device *netdev, u32 stringset, u8 *data) · line 99
Quoted 11 lines
drivers/net/ethernet/qualcomm/emac/emac-ethtool.c +1
-1@@ -95,7 +95,7 @@ static void emac_get_strings(struct net_device *netdev, u32 stringset, u8 *data)switch (stringset) {case ETH_SS_PRIV_FLAGS : -strcpy (data,"single-pause-mode" ); +strscpy (data,"single-pause-mode" ,ETH_GSTRING_LEN );break ;