driver core: attribute_container: Unwind device_add() on attr failure
PATCH 1/1 driver core: attribute_container: Unwind device_add() on attr failure
attribute_container_add_class_device() first calls device_add() and then creates the container attributes. If attribute_container_add_attrs() fails, the helper returns the error with the class device still registered.
Callers use an error from this helper as a failed add and do not call device_del() on that path. Undo the successful device_add() before returning the attribute creation error.
Signed-off-by Yuho Choi <[email protected]>
--- drivers/base/attribute_container.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/base/attribute_container.c +6 -1
@@ -425,7 +425,12 @@ attribute_container_add_class_device(struct device *classdev)if (error)return error; -return attribute_container_add_attrs (classdev); + + error =attribute_container_add_attrs (classdev); +if (error) +device_del (classdev); + +return error; }/**
Signature · 1 line
2.43.0