Skip to contentSkip to conversation

net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option

PATCH Applied Ethan Nelson-Moore 3 participants 3 messages Jun 9 – Jun 11

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option

The CONFIG_GILBARCONAP option has never been defined by the kernel, but is referred to by drivers/net/ethernet/freescale/fec_main.c. Remove this reference to eliminate dead code.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/fec_main.c +1 -1
index 6ebde65d7f1b..ced4dbf8cd90 100644
@@ -218,7 +218,7 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address");
  */
 #if defined(CONFIG_NETtel)
 #define	FEC_FLASHMAC	0xf0006006
-#elif defined(CONFIG_GILBARCONAP) || defined(CONFIG_SCALES)
+#elif defined(CONFIG_SCALES)
 #define	FEC_FLASHMAC	0xf0006000
 #elif defined(CONFIG_CANCam)
 #define	FEC_FLASHMAC	0xf0020000
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 26 lines

The CONFIG_GILBARCONAP option has never been defined by the kernel, but is referred to by drivers/net/ethernet/freescale/fec_main.c. Remove this reference to eliminate dead code.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/fec_main.c +1 -1
index 6ebde65d7f1b..ced4dbf8cd90 100644
@@ -218,7 +218,7 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC
 address");
  */
 #if defined(CONFIG_NETtel)
 #define	FEC_FLASHMAC	0xf0006006
-#elif defined(CONFIG_GILBARCONAP) || defined(CONFIG_SCALES)
+#elif defined(CONFIG_SCALES)
 #define	FEC_FLASHMAC	0xf0006000
 #elif defined(CONFIG_CANCam)
Quoted 3 lines

#define FEC_FLASHMAC 0xf0020000
--
2.43.0

#2 lore raw
In reply to Ethan Nelson-Moore
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 8 Jun 2026 21:52:00 -0700 you wrote:

The CONFIG_GILBARCONAP option has never been defined by the kernel, but is referred to by drivers/net/ethernet/freescale/fec_main.c. Remove this reference to eliminate dead code.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

[...]

Here is the summary with links:
- net: fec: remove reference to nonexistent CONFIG_GILBARCONAP option

    https://git.kernel.org/netdev/net-next/c/f8142f5578b4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html