Skip to contentSkip to conversation

xfce4-cpufreq-plugin: Fix aggregate init failure with gcc16

PATCH New [email protected] 1 participant 4 messages Jun 9

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 xfce4-cpufreq-plugin: Fix aggregate init failure with gcc16

From: Mingli Yu <[email protected]>

Fixes:
../../../sources/xfce4-cpufreq-plugin-1.3.0/xfce4++/util/gtk.cc:25:37: error: no matching function for call to 'xfce4::PluginSize::PluginSize(<brace-enclosed initializer list>)'
25 | const PluginSize RECTANGLE{true}, SQUARE{false};
| ^
• there are 2 candidates
In file included from ../../../sources/xfce4-cpufreq-plugin-1.3.0/xfce4++/util/gtk.cc:21:
• candidate 1: 'constexpr xfce4::PluginSize::PluginSize(const xfce4::PluginSize&)' ../../../sources/xfce4-cpufreq-plugin-1.3.0/xfce4++/util/gtk.h:64:8:
64 | struct PluginSize {
| ^~~~~~~~~~
• no known conversion for argument 1 from 'bool' to 'const xfce4::PluginSize&'
• candidate 2: 'constexpr xfce4::PluginSize::PluginSize(xfce4::PluginSize&&)'
• no known conversion for argument 1 from 'bool' to 'xfce4::PluginSize&&'

---
 ...ix-aggregate-init-failure-with-gcc16.patch | 49 +++++++++++++++++++
 .../cpufreq/xfce4-cpufreq-plugin_1.3.0.bb     |  4 ++
 2 files changed, 53 insertions(+)
 create mode 100644 meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch
meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch new file +49 -0
new file mode 100644
index 0000000000..b786d0d153
@@ -0,0 +1,49 @@
+From b9dc593f2843bd0f18309bde4d79b88d9f37e32f Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Tue, 2 Jun 2026 23:07:08 -0700
+Subject: [PATCH] Fix aggregate init failure with gcc16
+
+Replace deleted default constructors with explicit bool constructors
+to fix aggregate init failure with gcc16.
+
+Upstream-Status: Submitted [https://gitlab.xfce.org/panel-plugins/xfce4-cpufreq-plugin/-/merge_requests/68]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ xfce4++/util/gtk.h | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/xfce4++/util/gtk.h b/xfce4++/util/gtk.h
+index 1443cb2..ef03dd1 100644
+--- a/xfce4++/util/gtk.h
++++ b/xfce4++/util/gtk.h
+@@ -63,22 +63,22 @@ void connect(GtkToggleButton *widget, const char *signal, const std::function<vo
+ 
+ struct PluginSize {
+     bool rectangle; /* Whether the panel plugin size is forced to be a square. Otherwise, the plugin can be a rectangle. */
+-    PluginSize() = delete;
++    constexpr explicit PluginSize(bool r) : rectangle(r) {}
+ };
+ 
+ struct Propagation {
+     bool stop; /* Whether to prevent the event from propagating to other handlers */
+-    Propagation() = delete;
++    constexpr explicit Propagation(bool s) : stop(s) {}
+ };
+ 
+ struct TimeoutResponse {
+     bool again; /* Invoke the timeout handler again, otherwise stop the timer */
+-    TimeoutResponse() = delete;
++    constexpr explicit TimeoutResponse(bool a) : again(a) {}
+ };
+ 
+ struct TooltipTime {
+     bool now; /* Whether to show the tooltip now or later */
+-    TooltipTime() = delete;
++    constexpr explicit TooltipTime(bool n) : now(n) {}
+ };
+ 
+ extern const PluginSize      RECTANGLE, SQUARE;
+-- 
+2.49.0
+
meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin_1.3.0.bb +4 -0
index a0b48b8671..093b43c88f 100644
@@ -7,4 +7,8 @@ XFCE_COMPRESS_TYPE = "xz"
 
 inherit xfce-panel-plugin perlnative
 
+SRC_URI += "\
+           file://0001-Fix-aggregate-init-failure-with-gcc16.patch \
+"
+
 SRC_URI[sha256sum] = "baa5b90f72e8c262777f1e246acae125af489e2c168a5f7f890d9d2b5567ec20"
Signature · 1 line
2.49.0
#2 lore raw

PATCH 3/4 minifi-cpp: Fix build with gcc 16

From: Mingli Yu <[email protected]>

Fixes:
extensions/systemd/libwrapper/LibWrapper.h:38:31: error: 'uint64_t' has not been declared 38 | virtual int getRealtimeUsec(uint64_t* usec_out) noexcept = 0;
| ^~~~~~~~

---
 .../files/0001-Fix-build-with-gcc-16.patch    | 49 +++++++++++++++++++
 .../minifi-cpp/minifi-cpp_0.99.2.bb           |  1 +
 2 files changed, 50 insertions(+)
 create mode 100644 meta-oe/recipes-extended/minifi-cpp/files/0001-Fix-build-with-gcc-16.patch
meta-oe/recipes-extended/minifi-cpp/files/0001-Fix-build-with-gcc-16.patch new file +49 -0
new file mode 100644
index 0000000000..f1d83760b2
@@ -0,0 +1,49 @@
+From 950aea28ffefd88f230d6bd25fa0352e9ca157c9 Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 3 Jun 2026 02:12:01 -0700
+Subject: [PATCH] Fix build with gcc 16
+
+Fixes:
+  extensions/systemd/libwrapper/LibWrapper.h:38:31: error: 'uint64_t' has not been declared
+   38 |   virtual int getRealtimeUsec(uint64_t* usec_out) noexcept = 0;
+      |                               ^~~~~~~~
+
+  libminifi/include/core/RepositoryMetricsSource.h:29:5: error: 'uint64_t' does not name a type
+  |    29 |     uint64_t table_readers_size{};
+  |       |     ^~~~~~~~
+
+Upstream-Status: Submitted [https://github.com/apache/nifi-minifi-cpp/pull/2194]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ extensions/systemd/libwrapper/LibWrapper.h       | 1 +
+ libminifi/include/core/RepositoryMetricsSource.h | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/extensions/systemd/libwrapper/LibWrapper.h b/extensions/systemd/libwrapper/LibWrapper.h
+index d7e7b7c..c8af00e 100644
+--- a/extensions/systemd/libwrapper/LibWrapper.h
++++ b/extensions/systemd/libwrapper/LibWrapper.h
+@@ -19,6 +19,7 @@
+ #pragma once
+ 
+ #include <memory>
++#include <cstdint>
+ 
+ #include "../Common.h"
+ #include "utils/gsl.h"
+diff --git a/libminifi/include/core/RepositoryMetricsSource.h b/libminifi/include/core/RepositoryMetricsSource.h
+index 6c933b7..f39fccf 100644
+--- a/libminifi/include/core/RepositoryMetricsSource.h
++++ b/libminifi/include/core/RepositoryMetricsSource.h
+@@ -20,6 +20,7 @@
+ 
+ #include <string>
+ #include <optional>
++#include <cstdint>
+ 
+ namespace org::apache::nifi::minifi::core {
+ 
+-- 
+2.49.0
+
meta-oe/recipes-extended/minifi-cpp/minifi-cpp_0.99.2.bb +1 -0
index 4ac5b87ba9..6c64046161 100644
@@ -29,6 +29,7 @@ SRC_URI = "git://github.com/apache/nifi-minifi-cpp.git;protocol=https;branch=mai
            file://0007-libsodium-aarch64-set-compiler-attributes-after-including-arm_.patch \
            file://0001-Add-missing-include-for-malloc-free.patch;patchdir=thirdparty/fmt-src \
            file://0001-generateVersion.sh-set-BUILD_DATE-to-SOURCE_DATE_EPO.patch \
+           file://0001-Fix-build-with-gcc-16.patch \
            file://systemd-volatile.conf \
            file://sysvinit-volatile.conf \
           "
Signature · 1 line
2.49.0
#1 lore raw

PATCH 2/4 xfce4-sensors-plugin: Fix aggregate init failure with gcc16

In reply to [email protected]

From: Mingli Yu <[email protected]>

Fixes:
../../../sources/xfce4-sensors-plugin-1.5.0/xfce4++/util/gtk.cc:25:37: error: no matching function for call to 'xfce4::PluginSize::PluginSize(<brace-enclosed initializer list>)'
25 | const PluginSize RECTANGLE{true}, SQUARE{false};
| ^
• there are 2 candidates
In file included from ../../../sources/xfce4-sensors-plugin-1.5.0/xfce4++/util/gtk.cc:21:
• candidate 1: 'constexpr xfce4::PluginSize::PluginSize(const xfce4::PluginSize&)' ../../../sources/xfce4-sensors-plugin-1.5.0/xfce4++/util/gtk.h:64:8:
64 | struct PluginSize {
| ^~~~~~~~~~
• no known conversion for argument 1 from 'bool' to 'const xfce4::PluginSize&'
• candidate 2: 'constexpr xfce4::PluginSize::PluginSize(xfce4::PluginSize&&)'
• no known conversion for argument 1 from 'bool' to 'xfce4::PluginSize&&'

---
 ...ix-aggregate-init-failure-with-gcc16.patch | 49 +++++++++++++++++++
 .../sensors/xfce4-sensors-plugin_1.5.0.bb     |  4 +-
 2 files changed, 52 insertions(+), 1 deletion(-)
 create mode 100644 meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch
meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch new file +49 -0
new file mode 100644
index 0000000000..6cace545c5
@@ -0,0 +1,49 @@
+From 72f7f681c11d3f8a8ba0f4fb83d397108e16309a Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 3 Jun 2026 00:00:00 -0700
+Subject: [PATCH] Fix aggregate init failure with gcc16
+
+Replace deleted default constructors with explicit bool constructors
+to fix aggregate init failure with gcc16.
+
+Upstream-Status: Submitted [https://gitlab.xfce.org/panel-plugins/xfce4-sensors-plugin/-/merge_requests/78]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ xfce4++/util/gtk.h | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/xfce4++/util/gtk.h b/xfce4++/util/gtk.h
+index 1443cb2..ef03dd1 100644
+--- a/xfce4++/util/gtk.h
++++ b/xfce4++/util/gtk.h
+@@ -63,22 +63,22 @@ void connect(GtkToggleButton *widget, const char *signal, const std::function<vo
+ 
+ struct PluginSize {
+     bool rectangle; /* Whether the panel plugin size is forced to be a square. Otherwise, the plugin can be a rectangle. */
+-    PluginSize() = delete;
++    constexpr explicit PluginSize(bool r) : rectangle(r) {}
+ };
+ 
+ struct Propagation {
+     bool stop; /* Whether to prevent the event from propagating to other handlers */
+-    Propagation() = delete;
++    constexpr explicit Propagation(bool s) : stop(s) {}
+ };
+ 
+ struct TimeoutResponse {
+     bool again; /* Invoke the timeout handler again, otherwise stop the timer */
+-    TimeoutResponse() = delete;
++    constexpr explicit TimeoutResponse(bool a) : again(a) {}
+ };
+ 
+ struct TooltipTime {
+     bool now; /* Whether to show the tooltip now or later */
+-    TooltipTime() = delete;
++    constexpr explicit TooltipTime(bool n) : now(n) {}
+ };
+ 
+ extern const PluginSize      RECTANGLE, SQUARE;
+-- 
+2.49.0
+
meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin_1.5.0.bb +3 -1
index 1d9f7c205a..70e30164ae 100644
@@ -7,7 +7,9 @@ XFCE_COMPRESS_TYPE = "xz"
 
 inherit xfce-panel-plugin
 
-SRC_URI += "file://0001-Do-not-check-for-sys-class-power_supply-we-are-cross.patch"
+SRC_URI += "file://0001-Do-not-check-for-sys-class-power_supply-we-are-cross.patch \
+            file://0001-Fix-aggregate-init-failure-with-gcc16.patch \
+"
 SRC_URI[sha256sum] = "840442b87fdddcd8595bd9f83ea8b81f771fe296bb9d2abf0e1979e208727ae9"
 
 EXTRA_OECONF = " \
Signature · 1 line
2.49.0
#3 lore raw

PATCH 4/4 freeradius: Fix do_patch fuzz QA Issue

In reply to [email protected]

From: Mingli Yu <[email protected]>

Fixes:
ERROR: freeradius-3.2.9-r0.wr2600 do_patch: QA Issue: Fuzz detected:

checking file src/main/version.c
Hunk #1 succeeded at 622 with fuzz 1 (offset 8 lines).

patching file src/main/version.c
Hunk #1 succeeded at 622 with fuzz 1 (offset 8 lines).

---
 .../0016-version.c-don-t-print-build-flags.patch      | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
meta-networking/recipes-connectivity/freeradius/files/0016-version.c-don-t-print-build-flags.patch +4 -7
index 8917457ec2..6fb9d9fa3b 100644
@@ -1,4 +1,4 @@
-From 99ea83d998d3b8957830afa15cec42ba265b67ca Mon Sep 17 00:00:00 2001
+From ac503b5395d566c677013c051165290ab024cdef Mon Sep 17 00:00:00 2001
 From: Mingli Yu <[email protected]>
 Date: Wed, 3 Aug 2022 16:44:29 +0800
 Subject: [PATCH] version.c: don't print build flags
@@ -13,10 +13,10 @@ Signed-off-by: Mingli Yu <[email protected]>
  1 file changed, 13 deletions(-)
 
 diff --git a/src/main/version.c b/src/main/version.c
-index 44a6edc699..a0e6f26911 100644
+index 1bdb562..0368fba 100644
 --- a/src/main/version.c
 +++ b/src/main/version.c
-@@ -614,19 +614,6 @@ void version_print(void)
+@@ -622,19 +622,6 @@ void version_print(void)
  		DEBUG2("  unknown");
  #endif
  
@@ -35,7 +35,4 @@ index 44a6edc699..a0e6f26911 100644
 -#endif
  		DEBUG2("  ");
  	}
- 	INFO("FreeRADIUS Version " RADIUSD_VERSION_STRING);
--- 
-2.25.1
-
+ 
Signature · 1 line
2.49.0