Skip to contentSkip to conversation

xtensa: correct CONFIG_XTENSA_CALIBRATE_CCOUNT macro name in comment

PATCH In review Ethan Nelson-Moore 2 participants 4 messages Jun 9 – Jun 10 Tensilica Xtensa port (xtensa)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xtensa: correct CONFIG_XTENSA_CALIBRATE_CCOUNT macro name in comment

A comment in arch/xtensa/include/asm/platform.h incorrectly refers to CONFIG_XTENSA_CALIBRATE instead of CONFIG_XTENSA_CALIBRATE_CCOUNT. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 arch/xtensa/include/asm/platform.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/xtensa/include/asm/platform.h +1 -1
index 94f13fabf7cd..f2e50fc12b4d 100644
@@ -33,7 +33,7 @@ extern void platform_setup (char **);
 extern void platform_idle (void);
 
 /*
- * platform_calibrate_ccount calibrates cpu clock freq (CONFIG_XTENSA_CALIBRATE)
+ * platform_calibrate_ccount calibrates cpu clock freq (CONFIG_XTENSA_CALIBRATE_CCOUNT)
  */
 extern void platform_calibrate_ccount (void);
 
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 7 lines · Ethan Nelson-Moore

A comment in arch/xtensa/include/asm/platform.h incorrectly refers to CONFIG_XTENSA_CALIBRATE instead of CONFIG_XTENSA_CALIBRATE_CCOUNT. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

The change looks good to me.
Please add you Signed-off-by tag.

Quoted 20 lines
---
 arch/xtensa/include/asm/platform.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/xtensa/include/asm/platform.h +1 -2
index 94f13fabf7cd..f2e50fc12b4d 100644
@@ -33,7 +33,7 @@ extern void platform_setup (char **);
 extern void platform_idle (void);
 
 /*
- * platform_calibrate_ccount calibrates cpu clock freq (CONFIG_XTENSA_CALIBRATE)
+ * platform_calibrate_ccount calibrates cpu clock freq (CONFIG_XTENSA_CALIBRATE_CCOUNT)
  */
 extern void platform_calibrate_ccount (void);
 
--

2.43.0

Signature · 2 lines
Thanks.
-- Max
#2 lore raw

Hi, Max,

Quoted 2 lines · Max Filippov

The change looks good to me.
Please add you Signed-off-by tag.

Thanks for your review.
I am not sure how the tag got omitted - I used a script that calls git format-patch with -s to ensure it is included.
I will resend the patch with the tag tomorrow.

Ethan

#3 lore raw

Hi, Max,

Quoted 3 lines · Ethan Nelson-Moore

I am not sure how the tag got omitted - I used a script that calls git format-patch with -s to ensure it is included.
I will resend the patch with the tag tomorrow.

I figured this out - it was a bug in another one of my scripts. It shouldn't happen again.

Ethan