Skip to contentSkip to conversation

ALSA: docs: remove references to removed CONFIG_SND_HDA_POWER_SAVE

PATCH In review Ethan Nelson-Moore 2 participants 2 messages Jun 10

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: docs: remove references to removed CONFIG_SND_HDA_POWER_SAVE

The CONFIG_SND_HDA_POWER_SAVE option was removed in commit 83012a7ccbb9 ("ALSA: hda - Clean up CONFIG_SND_HDA_POWER_SAVE"), but references to it remained in documentation. Remove them.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 Documentation/sound/designs/powersave.rst | 5 +++--
 Documentation/sound/hd-audio/notes.rst    | 3 ---
 2 files changed, 3 insertions(+), 5 deletions(-)
Documentation/sound/designs/powersave.rst +3 -2
index ca7d1e838b4d..4b9d6d0b0d98 100644
@@ -3,8 +3,9 @@ Notes on Power-Saving Mode
 ==========================
 
 AC97 and HD-audio drivers have the automatic power-saving mode.
-This feature is enabled via Kconfig ``CONFIG_SND_AC97_POWER_SAVE``
-and ``CONFIG_SND_HDA_POWER_SAVE`` options, respectively.
+For HD-audio devices, this feature is enabled if ``CONFIG_PM`` is
+enabled. For AC97 devices, it is enabled via the Kconfig
+``CONFIG_SND_AC97_POWER_SAVE`` option.
 
 With the automatic power-saving, the driver turns off the codec power
 appropriately when no operation is required.  When no applications use
Documentation/sound/hd-audio/notes.rst +0 -3
index 6993bfa159b4..1412a8eabfa8 100644
@@ -341,9 +341,6 @@ hwdep option above.  When enabled, you'll have some sysfs files under
 the corresponding hwdep directory.  See "HD-audio reconfiguration"
 section below.
 
-``CONFIG_SND_HDA_POWER_SAVE`` option enables the power-saving feature.
-See "Power-saving" section below.
-
 
 Codec Proc-File
 ---------------
Signature · 1 line
2.43.0
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Ethan Nelson-Moore

The CONFIG_SND_HDA_POWER_SAVE option was removed in commit 83012a7ccbb9 ("ALSA: hda - Clean up CONFIG_SND_HDA_POWER_SAVE"), but references to it remained in documentation. Remove them.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

LGTM. Thanks.

Quoted 35 lines
---
 Documentation/sound/designs/powersave.rst | 5 +++--
 Documentation/sound/hd-audio/notes.rst    | 3 ---
 2 files changed, 3 insertions(+), 5 deletions(-)
Documentation/sound/designs/powersave.rst +3 -2
index ca7d1e838b4d..4b9d6d0b0d98 100644
@@ -3,8 +3,9 @@ Notes on Power-Saving Mode
 ==========================
 
 AC97 and HD-audio drivers have the automatic power-saving mode.
-This feature is enabled via Kconfig ``CONFIG_SND_AC97_POWER_SAVE``
-and ``CONFIG_SND_HDA_POWER_SAVE`` options, respectively.
+For HD-audio devices, this feature is enabled if ``CONFIG_PM`` is
+enabled. For AC97 devices, it is enabled via the Kconfig
+``CONFIG_SND_AC97_POWER_SAVE`` option.
 
 With the automatic power-saving, the driver turns off the codec power
 appropriately when no operation is required.  When no applications use
Documentation/sound/hd-audio/notes.rst +0 -3
index 6993bfa159b4..1412a8eabfa8 100644
@@ -341,9 +341,6 @@ hwdep option above.  When enabled, you'll have some sysfs files under
 the corresponding hwdep directory.  See "HD-audio reconfiguration"
 section below.
 
-``CONFIG_SND_HDA_POWER_SAVE`` option enables the power-saving feature.
-See "Power-saving" section below.
-
 
 Codec Proc-File
 ---------------
Signature · 1 line
~Randy