Skip to contentSkip to conversation

wifi: mt76: mt7996: remove code guarded by nonexistent config option

PATCH In review Ethan Nelson-Moore 2 participants 2 messages Jun 10

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wifi: mt76: mt7996: remove code guarded by nonexistent config option

A small piece of code in mt7996.h depends on CONFIG_MTK_DEBUG, which has never been defined in the kernel. Remove this dead code.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h +0 -4
index bdcf72457954..39c525a40412 100644
@@ -921,10 +921,6 @@ int mt7996_mmio_wed_init(struct mt7996_dev *dev, void *pdev_ptr,
 			 bool hif2, int *irq);
 u32 mt7996_wed_init_buf(void *ptr, dma_addr_t phys, int token_id);
 
-#ifdef CONFIG_MTK_DEBUG
-int mt7996_mtk_init_debugfs(struct mt7996_phy *phy, struct dentry *dir);
-#endif
-
 int mt7996_dma_rro_init(struct mt7996_dev *dev);
 void mt7996_dma_rro_start(struct mt7996_dev *dev);
 
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ethan Nelson-Moore

A small piece of code in mt7996.h depends on CONFIG_MTK_DEBUG, which has never been defined in the kernel. Remove this dead code.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

Quoted 19 lines
---
  drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h | 4 ----
  1 file changed, 4 deletions(-)
drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h +0 -4
index bdcf72457954..39c525a40412 100644
@@ -921,10 +921,6 @@ int mt7996_mmio_wed_init(struct mt7996_dev *dev, void *pdev_ptr,
  			 bool hif2, int *irq);
  u32 mt7996_wed_init_buf(void *ptr, dma_addr_t phys, int token_id);
 
-#ifdef CONFIG_MTK_DEBUG
-int mt7996_mtk_init_debugfs(struct mt7996_phy *phy, struct dentry *dir);
-#endif
-
  int mt7996_dma_rro_init(struct mt7996_dev *dev);
  void mt7996_dma_rro_start(struct mt7996_dev *dev);