cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING
PATCH 1/1 cxl/port: update reference to removed CONFIG_PROVE_CXL_LOCKING
A comment in drivers/cxl/port.c refers to CONFIG_PROVE_CXL_LOCKING, which was removed in commit 38a34e10768c ("cxl: Drop cxl_device_lock()"). That commit switched CXL subsystem locking to custom lock classes, which can be validated via the standard CONFIG_PROVE_LOCKING option. Update the comment to reflect this.
Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.
--- drivers/cxl/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cxl/port.c +1 -1
@@ -18,7 +18,7 @@* firmware) are managed in this drivers context. Each driver instance * is responsible for tearing down the driver context of immediate * descendant ports. The locking for this is validated by -* CONFIG_PROVE_CXL_LOCKING. +* CONFIG_PROVE_LOCKING. * * The primary service this driver provides is presenting APIs to other * drivers to utilize the decoders, and indicating to userspace (via bind
Signature · 1 line
2.43.0
Quoted 9 lines · Ethan Nelson-Moore
A comment in
drivers/cxl/port.crefers toCONFIG_PROVE_CXL_LOCKING, which was removed in commit38a34e10768c("cxl: Dropcxl_device_lock()"). That commit switched CXL subsystem locking to custom lock classes, which can be validated via the standardCONFIG_PROVE_LOCKINGoption. Update the comment to reflect this.Discovered while searching for CONFIG_* symbols referenced in code but not defined in any
Kconfigfile.
Hi Ethan,
Thanks for this, LGTM.
Best regards,
Richard Cheng.
Quoted 22 lines
Signed-off-by Ethan Nelson-Moore <[email protected]>--- drivers/cxl/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cxl/port.c +1
-1@@ -18,7 +18,7 @@* firmware) are managed in this drivers context. Each driver instance * is responsible for tearing down the driver context of immediate * descendant ports. The locking for this is validated by -* CONFIG_PROVE_CXL_LOCKING. +* CONFIG_PROVE_LOCKING. * * The primary service this driver provides is presenting APIs to other * drivers to utilize the decoders, and indicating to userspace (via bind Signature · 1 line
2.43.0
Quoted 11 lines · Ethan Nelson-Moore
A comment in
drivers/cxl/port.crefers toCONFIG_PROVE_CXL_LOCKING, which was removed in commit38a34e10768c("cxl: Dropcxl_device_lock()"). That commit switched CXL subsystem locking to custom lock classes, which can be validated via the standardCONFIG_PROVE_LOCKINGoption. Update the comment to reflect this.Discovered while searching for CONFIG_* symbols referenced in code but not defined in any
Kconfigfile.Signed-off-by Ethan Nelson-Moore <[email protected]>---
Looks good,
Quoted 10 lines · Ethan Nelson-Moore
A comment in
drivers/cxl/port.crefers toCONFIG_PROVE_CXL_LOCKING, which was removed in commit38a34e10768c("cxl: Dropcxl_device_lock()"). That commit switched CXL subsystem locking to custom lock classes, which can be validated via the standardCONFIG_PROVE_LOCKINGoption. Update the comment to reflect this.Discovered while searching for CONFIG_* symbols referenced in code but not defined in any
Kconfigfile.Signed-off-by Ethan Nelson-Moore <[email protected]>
Quoted 17 lines
--- drivers/cxl/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cxl/port.c +1
-1@@ -18,7 +18,7 @@* firmware) are managed in this drivers context. Each driver instance * is responsible for tearing down the driver context of immediate * descendant ports. The locking for this is validated by -* CONFIG_PROVE_CXL_LOCKING. +* CONFIG_PROVE_LOCKING. * * The primary service this driver provides is presenting APIs to other * drivers to utilize the decoders, and indicating to userspace (via bind
Quoted 8 lines · Ethan Nelson-Moore
A comment in
drivers/cxl/port.crefers toCONFIG_PROVE_CXL_LOCKING, which was removed in commit38a34e10768c("cxl: Dropcxl_device_lock()"). That commit switched CXL subsystem locking to custom lock classes, which can be validated via the standardCONFIG_PROVE_LOCKINGoption. Update the comment to reflect this.Discovered while searching for CONFIG_* symbols referenced in code but not defined in any
Kconfigfile.
Quoted 10 lines · Ethan Nelson-Moore
A comment in
drivers/cxl/port.crefers toCONFIG_PROVE_CXL_LOCKING, which was removed in commit38a34e10768c("cxl: Dropcxl_device_lock()"). That commit switched CXL subsystem locking to custom lock classes, which can be validated via the standardCONFIG_PROVE_LOCKINGoption. Update the comment to reflect this.Discovered while searching for CONFIG_* symbols referenced in code but not defined in any
Kconfigfile.Signed-off-by Ethan Nelson-Moore <[email protected]>
Applied to cxl/nextf9f82e97d9c5411c2cb3b8338a21be91148ff18b
Quoted 17 lines
--- drivers/cxl/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cxl/port.c +1
-1@@ -18,7 +18,7 @@* firmware) are managed in this drivers context. Each driver instance * is responsible for tearing down the driver context of immediate * descendant ports. The locking for this is validated by -* CONFIG_PROVE_CXL_LOCKING. +* CONFIG_PROVE_LOCKING. * * The primary service this driver provides is presenting APIs to other * drivers to utilize the decoders, and indicating to userspace (via bind