ARM: remove the last few uses of do_bad_IRQ()
Subsystems (5)
PATCH 1/1 ARM: remove the last few uses of do_bad_IRQ()
The do_bad_IRQ() macro simply calls handle_bad_irq() with a lock around it. It also carries a comment stating that uses of it should be replaced. According to commit aec0095653cd ("irqchip: gic: Call handle_bad_irq() directly"), which replaced another use of do_bad_IRQ(), locking the IRQ descriptor is not necessary for error reporting. Therefore, replace all uses of do_bad_IRQ() with calls to handle_bad_irq() and remove do_bad_IRQ().
--- arch/arm/common/sa1111.c | 2 +- arch/arm/include/asm/mach/irq.h | 10 ---------- arch/arm/mach-footbridge/isa-irq.c | 2 +- drivers/irqchip/irq-versatile-fpga.c | 2 +- 4 files changed, 3 insertions(+), 13 deletions(-)
arch/arm/common/sa1111.c +1 -1
@@ -221,7 +221,7 @@ static void sa1111_irq_handler(struct irq_desc *desc)writel_relaxed (stat1, mapbase +SA1111_INTSTATCLR1 );if (stat0 ==0 && stat1 ==0 ) { -do_bad_IRQ (desc); +handle_bad_irq (desc);return ; }
arch/arm/include/asm/mach/irq.h +0 -10
@@ -17,14 +17,4 @@ struct seq_file;extern void init_FIQ (int );extern int show_fiq_list (struct seq_file *,int ); -/* -* This is for easy migration, but should be changed in the source -*/ -#define do_bad_IRQ (desc) \ -do { \ - raw_spin_lock(&desc->lock); \ - handle_bad_irq(desc); \ - raw_spin_unlock(&desc->lock); \ -} while(0) -#endif
arch/arm/mach-footbridge/isa-irq.c +1 -1
@@ -89,7 +89,7 @@ static void isa_irq_handler(struct irq_desc *desc)unsigned int isa_irq = *(unsigned char *)PCIIACK_BASE ;if (isa_irq <_ISA_IRQ (0 ) || isa_irq >=_ISA_IRQ (16 )) { -do_bad_IRQ (desc); +handle_bad_irq (desc);return ; }
drivers/irqchip/irq-versatile-fpga.c +1 -1
@@ -89,7 +89,7 @@ static void fpga_irq_handle(struct irq_desc *desc) status =readl (f->base +IRQ_STATUS );if (status ==0 ) { -do_bad_IRQ (desc); +handle_bad_irq (desc); goto out; }
Signature · 1 line
2.43.0
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:
Hello:
This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:
Quoted 9 lines · On Tue, 9 Jun 2026 21:56:26 -0700 you wrote:
The
do_bad_IRQ()macro simply callshandle_bad_irq()with a lock around it. It also carries a comment stating that uses of it should be replaced. According to commitaec0095653cd("irqchip: gic: Callhandle_bad_irq()directly"), which replaced another use ofdo_bad_IRQ(), locking the IRQ descriptor is not necessary for error reporting. Therefore, replace all uses ofdo_bad_IRQ()with calls tohandle_bad_irq()and removedo_bad_IRQ().[...]
Here is the summary with links:
- ARM: remove the last few uses of do_bad_IRQ()
https://git.kernel.org/soc/soc/c/d7a163856803
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html