Skip to contentSkip to conversation

tools/power/x86/intel-speed-select: correct macro name in debug output

PATCH In review Ethan Nelson-Moore 2 participants 2 messages Jun 10 – Sep 10

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/power/x86/intel-speed-select: correct macro name in debug output

A call to debug_printf() in isst-core-mbox.c incorrectly refers to CONFIG_TDP_GET_TURBO_LIMIT instead of CONFIG_TDP_GET_TURBO_LIMIT_RATIOS. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined.

---
 tools/power/x86/intel-speed-select/isst-core-mbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/intel-speed-select/isst-core-mbox.c +1 -1
index c81ecd602bcf..baadeb75376c 100644
@@ -561,7 +561,7 @@ static int mbox_get_get_trl(struct isst_id *id, int level, int avx_level, int *t
 	if (ret)
 		return ret;
 
-	debug_printf("cpu:%d CONFIG_TDP_GET_TURBO_LIMIT req:%x resp:%x\n", id->cpu,
+	debug_printf("cpu:%d CONFIG_TDP_GET_TURBO_LIMIT_RATIOS req:%x resp:%x\n", id->cpu,
 		     req, resp);
 
 	trl[4] = resp & GENMASK(7, 0);
Signature · 1 line
2.43.0
#1 lore raw
Quoted 9 lines · Ethan Nelson-Moore

A call to debug_printf() in isst-core-mbox.c incorrectly refers to CONFIG_TDP_GET_TURBO_LIMIT instead of CONFIG_TDP_GET_TURBO_LIMIT_RATIOS. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but
not defined.

Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/spandruvada/linux.git/log/?h=for-sst-v7.4.rc1

Thanks,
Srinivas

Quoted 21 lines

---
 tools/power/x86/intel-speed-select/isst-core-mbox.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/intel-speed-select/isst-core-mbox.c +0 -0
index c81ecd602bcf..baadeb75376c 100644
@@ -561,7 +561,7 @@ static int mbox_get_get_trl(struct isst_id *id,

int level, int avx_level, int *t
  if (ret)
  return ret;

tools/power/x86/intel-speed-select/isst-core-mbox.c +0 -1
-	debug_printf("cpu:%d CONFIG_TDP_GET_TURBO_LIMIT req:%x

resp:%x\n", id->cpu,

tools/power/x86/intel-speed-select/isst-core-mbox.c +1 -0
+	debug_printf("cpu:%d CONFIG_TDP_GET_TURBO_LIMIT_RATIOS

req:%x resp:%x\n", id->cpu,
       req, resp);

  trl[4] = resp & GENMASK(7, 0);