Skip to contentSkip to conversation

MIPS: mm: remove comment referring to removed CONFIG_MIPS_CMP

PATCH Applied Ethan Nelson-Moore 2 participants 2 messages Jun 10 – Jun 16 MIPS

lore
Share & tools
lore

Ethan Nelson-Moore

author
#0 lore raw

PATCH 1/1 MIPS: mm: remove comment referring to removed CONFIG_MIPS_CMP

CMP support was removed in commit 7fb6f7b0af67 ("MIPS: Remove deprecated CONFIG_MIPS_CMP"), but a comment referring to it remained in arch/mips/mm/c-r4k.c. Remove it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

Signed-off-by Ethan Nelson-Moore <[email protected]>
---
 arch/mips/mm/c-r4k.c | 5 -----
 1 file changed, 5 deletions(-)
arch/mips/mm/c-r4k.c +0 -5
index 10413b6f6662..d8aadd3dc057 100644
@@ -1757,11 +1757,6 @@ void r4k_cache_init(void)
 	build_clear_page();
 	build_copy_page();
 
-	/*
-	 * We want to run CMP kernels on core with and without coherent
-	 * caches. Therefore, do not use CONFIG_MIPS_CMP to decide whether
-	 * or not to flush caches.
-	 */
 	local_r4k___flush_cache_all(NULL);
 
 	coherency_setup();
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 30 lines · Ethan Nelson-Moore

CMP support was removed in commit 7fb6f7b0af67 ("MIPS: Remove deprecated CONFIG_MIPS_CMP"), but a comment referring to it remained in arch/mips/mm/c-r4k.c. Remove it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

Signed-off-by Ethan Nelson-Moore <[email protected]>
---
 arch/mips/mm/c-r4k.c | 5 -----
 1 file changed, 5 deletions(-)
arch/mips/mm/c-r4k.c +0 -5
index 10413b6f6662..d8aadd3dc057 100644
@@ -1757,11 +1757,6 @@ void r4k_cache_init(void)
 	build_clear_page();
 	build_copy_page();
 
-	/*
-	 * We want to run CMP kernels on core with and without coherent
-	 * caches. Therefore, do not use CONFIG_MIPS_CMP to decide whether
-	 * or not to flush caches.
-	 */
 	local_r4k___flush_cache_all(NULL);
 
 	coherency_setup();
Signature · 1 line
2.43.0

applied to mips-next

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]