Skip to contentSkip to conversation

staging: rtl8723bs: remove unused channel format/arg macros

PATCH New Chen-Yu Yeh 1 participant 3 messages Jun 11 Staging

lore
Share & tools
lore

Chen-Yu Yeh

author
#0 lore raw

PATCH 1/1 staging: rtl8723bs: remove unused channel format/arg macros

CHAN_FMT and CHAN_ARG are defined but never used anywhere in the driver. Most of their content is commented-out dead code. Remove them.

This also fixes a checkpatch error:
ERROR: Macros with complex values should be enclosed in parentheses

Signed-off-by Chen-Yu Yeh <[email protected]>
---
 drivers/staging/rtl8723bs/include/ieee80211.h | 26 -------------------
 1 file changed, 26 deletions(-)
drivers/staging/rtl8723bs/include/ieee80211.h +0 -26
index 39ee139f1..bb7c2ecb1 100644
@@ -623,32 +623,6 @@ struct rtw_ieee80211_channel {
 	/* int orig_mpwr; */
 };
 
-#define CHAN_FMT \
-	/*"band:%d, "*/ \
-	/*"center_freq:%u, "*/ \
-	"hw_value:%u, " \
-	"flags:0x%08x" \
-	/*"max_antenna_gain:%d\n"*/ \
-	/*"max_power:%d\n"*/ \
-	/*"max_reg_power:%d\n"*/ \
-	/*"beacon_found:%u\n"*/ \
-	/*"orig_flags:0x%08x\n"*/ \
-	/*"orig_mag:%d\n"*/ \
-	/*"orig_mpwr:%d\n"*/
-
-#define CHAN_ARG(channel) \
-	/*(channel)->band*/ \
-	/*, (channel)->center_freq*/ \
-	(channel)->hw_value \
-	, (channel)->flags \
-	/*, (channel)->max_antenna_gain*/ \
-	/*, (channel)->max_power*/ \
-	/*, (channel)->max_reg_power*/ \
-	/*, (channel)->beacon_found*/ \
-	/*, (channel)->orig_flags*/ \
-	/*, (channel)->orig_mag*/ \
-	/*, (channel)->orig_mpwr*/ \
-
 /* Parsed Information Elements */
 struct rtw_ieee802_11_elems {
 	u8 *ssid;
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH 1/1 staging: rtl8723bs: remove unused netdev format/arg macros

NDEV_ARG, FUNC_NDEV_FMT and FUNC_NDEV_ARG are defined but never used anywhere in the driver. Remove them.

This also fixes a checkpatch error:
ERROR: Macros with complex values should be enclosed in parentheses

Signed-off-by Chen-Yu Yeh <[email protected]>
---
 drivers/staging/rtl8723bs/include/osdep_service_linux.h | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/include/osdep_service_linux.h +0 -3
index 2ec54f9e1..c8274da94 100644
@@ -98,10 +98,7 @@ static inline void rtw_netif_stop_queue(struct net_device *pnetdev)
 
 #define rtw_signal_process(pid, sig) kill_pid(find_vpid((pid)), (sig), 1)
 
-#define NDEV_ARG(ndev) ndev->name
 #define ADPT_ARG(adapter) adapter->pnetdev->name
-#define FUNC_NDEV_FMT "%s(%s)"
-#define FUNC_NDEV_ARG(ndev) __func__, ndev->name
 #define FUNC_ADPT_FMT "%s(%s)"
 #define FUNC_ADPT_ARG(adapter) __func__, adapter->pnetdev->name
Signature · 1 line
2.43.0
author
#2 lore raw

Re: [PATCH] staging: rtl8723bs: remove unused netdev format/arg macros

Sorry, please disregard this mail. It duplicates my earlier submission of the same patch:

https://lore.kernel.org/all/[email protected]/

It was accidentally resent due to a shell glob matching an already-sent patch file.

Chen-Yu

Chen-Yu Yeh <[email protected]> 於 2026年6月11日週四 下午4:17寫道：

Quoted 30 lines

NDEV_ARG, FUNC_NDEV_FMT and FUNC_NDEV_ARG are defined but never used anywhere in the driver. Remove them.

This also fixes a checkpatch error:
ERROR: Macros with complex values should be enclosed in parentheses

Signed-off-by Chen-Yu Yeh <[email protected]>
---
 drivers/staging/rtl8723bs/include/osdep_service_linux.h | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/include/osdep_service_linux.h +0 -4
index 2ec54f9e1..c8274da94 100644
@@ -98,10 +98,7 @@ static inline void rtw_netif_stop_queue(struct net_device *pnetdev)
 
 #define rtw_signal_process(pid, sig) kill_pid(find_vpid((pid)), (sig), 1)
 
-#define NDEV_ARG(ndev) ndev->name
 #define ADPT_ARG(adapter) adapter->pnetdev->name
-#define FUNC_NDEV_FMT "%s(%s)"
-#define FUNC_NDEV_ARG(ndev) __func__, ndev->name
 #define FUNC_ADPT_FMT "%s(%s)"
 #define FUNC_ADPT_ARG(adapter) __func__, adapter->pnetdev->name
 
--

2.43.0