crypto: atmel-ecc - drop unused curve id from atmel_ecdh_ctx
Subsystems (3)
PATCH 1/1 crypto: atmel-ecc - drop unused curve id from atmel_ecdh_ctx
->curve_id is only set once, but never used - remove it.
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/crypto/atmel-ecc.c | 3 --- 1 file changed, 3 deletions(-)
drivers/crypto/atmel-ecc.c +0 -3
@@ -33,7 +33,6 @@ static struct atmel_ecc_driver_data driver_data;* @public_key : generated when calling set_secret(). It's the responsibility * of the user to not call set_secret() while * generate_public_key() or compute_shared_secret() are in flight. -* @curve_id : elliptic curve id * @do_fallback: true when the device doesn't support the curve or when the user * wants to use its own private key. */
@@ -41,7 +40,6 @@ struct atmel_ecdh_ctx {struct i2c_client *client;struct crypto_kpp *fallback;const u8 *public_key; -unsigned int curve_id;bool do_fallback; };
@@ -250,7 +248,6 @@ static int atmel_ecdh_init_tfm(struct crypto_kpp *tfm)struct crypto_kpp *fallback;struct atmel_ecdh_ctx *ctx =kpp_tfm_ctx (tfm); - ctx->curve_id =ECC_CURVE_NIST_P256 ; ctx->client =atmel_ecc_i2c_client_alloc ();if (IS_ERR (ctx->client)) {pr_err ("tfm - i2c_client binding failed\n" );
Quoted 28 lines · Thorsten Blum
->curve_id is only set once, but never used - remove it.
Signed-off-by Thorsten Blum <[email protected]>--- drivers/crypto/atmel-ecc.c | 3 --- 1 file changed, 3 deletions(-)drivers/crypto/atmel-ecc.c +0
-2@@ -33,7 +33,6 @@ static struct atmel_ecc_driver_data driver_data;* @public_key : generated when calling set_secret(). It's the responsibility * of the user to not call set_secret() while * generate_public_key() or compute_shared_secret() are in flight. -* @curve_id : elliptic curve id * @do_fallback: true when the device doesn't support the curve or when the user * wants to use its own private key. */ @@ -41,7 +40,6 @@ struct atmel_ecdh_ctx {struct i2c_client *client;struct crypto_kpp *fallback;const u8 *public_key; -unsigned int curve_id;bool do_fallback; };
drivers/crypto/atmel-ecc.c static int atmel_ecdh_init_tfm(struct crypto_kpp *tfm) · line 253
Quoted 7 lines
drivers/crypto/atmel-ecc.c +0
-1@@ -250,7 +248,6 @@ static int atmel_ecdh_init_tfm(struct crypto_kpp *tfm)struct crypto_kpp *fallback;struct atmel_ecdh_ctx *ctx =kpp_tfm_ctx (tfm); - ctx->curve_id =ECC_CURVE_NIST_P256 ; ctx->client =atmel_ecc_i2c_client_alloc ();if (IS_ERR (ctx->client)) {pr_err ("tfm - i2c_client binding failed\n" );
I'll need to rebase and resend this assuming [1] is applied first, as it currently doesn't apply cleanly.
Herbert Xu
maintainerQuoted 6 lines · Thorsten Blum
->curve_id is only set once, but never used - remove it.
Signed-off-by Thorsten Blum <[email protected]>--- drivers/crypto/atmel-ecc.c | 3 --- 1 file changed, 3 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt