Skip to contentSkip to conversation

nvmem: airoha: add ARM64 dependency

PATCH Applied Arnd Bergmann 3 participants 3 messages Jun 11 – Jul 16 NVMEM framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvmem: airoha: add ARM64 dependency

From: Arnd Bergmann <[email protected]>

The driver already depends on HAVE_ARM_SMCCC and ARCH_AIROHA, but both are available for 32-bit and 64-bit targets. However, the smccc invocation fails on thumb2 builds with clang:

drivers/nvmem/airoha-smc-efuses.c:38:2: error: write to reserved register 'R7'

   38 |         arm_smccc_1_1_invoke(AIROHA_SMC_EFUSE_FID,
      |         ^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
arch/arm/include/asm/opcodes.h:215:2: note: expanded from macro '__inst_arm_thumb32'
  215 |         __inst_thumb32(thumb_opcode)
      |         ^

Since the driver is only used on the 64-bit an7581 soc, avoid this problem with a stricter dependency.

Fixes 25e001fcc1e6 ("nvmem: airoha: Add support for SMC eFUSE")
---
 drivers/nvmem/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/nvmem/Kconfig +1 -0
index e10f7ff725ff..f33ee18930ae 100644
@@ -30,6 +30,7 @@ source "drivers/nvmem/layouts/Kconfig"
 
 config NVMEM_AIROHA_SMC_EFUSES
 	tristate "Airoha SMC eFuse support"
+	depends on ARM64
 	depends on ARCH_AIROHA || COMPILE_TEST
 	depends on HAVE_ARM_SMCCC
 	default ARCH_AIROHA
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The driver already depends on HAVE_ARM_SMCCC and ARCH_AIROHA, but both are available for 32-bit and 64-bit targets. However, the smccc invocation fails on thumb2 builds with clang:

drivers/nvmem/airoha-smc-efuses.c:38:2: error: write to reserved register 'R7'

   38 |         arm_smccc_1_1_invoke(AIROHA_SMC_EFUSE_FID,
      |         ^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
arch/arm/include/asm/opcodes.h:215:2: note: expanded from macro '__inst_arm_thumb32'
  215 |         __inst_thumb32(thumb_opcode)
      |         ^
Quoted 5 lines

Since the driver is only used on the 64-bit an7581 soc, avoid this problem with a stricter dependency.

Fixes 25e001fcc1e6 ("nvmem: airoha: Add support for SMC eFUSE")
Signature · 1 line
	Ansuel
maintainer Applied
#2 lore raw
In reply to Arnd Bergmann
Quoted 5 lines · Arnd Bergmann

The driver already depends on HAVE_ARM_SMCCC and ARCH_AIROHA, but both are available for 32-bit and 64-bit targets. However, the smccc invocation fails on thumb2 builds with clang:

drivers/nvmem/airoha-smc-efuses.c:38:2: error: write to reserved register 'R7'

Quoted 8 lines
   38 |         arm_smccc_1_1_invoke(AIROHA_SMC_EFUSE_FID,
      |         ^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
arch/arm/include/asm/opcodes.h:215:2: note: expanded from macro '__inst_arm_thumb32'
  215 |         __inst_thumb32(thumb_opcode)
      |         ^

[...]

Applied, thanks!

[1/1] nvmem: airoha: add ARM64 dependency

      commit: 29d8d70e55efed7c2edf3a458d2e60e9ca41bde6

Best regards,

Signature · 1 line
Srinivas Kandagatla <[email protected]>