NFSD: remove flawed WARN_ON_ONCE from nfsd_mode_check
Subsystems (2)
PATCH 1/1 NFSD: remove flawed WARN_ON_ONCE from nfsd_mode_check
The header for commit e75b23f9e323 ("nfsd: check d_can_lookup in fh_verify of directories") details the assumption that justified adding the WARN_ON_ONCE to nfsd_mode_check(), that assumption is invalid (in the case of NFS reexport).
When NFSD exports an NFS filesystem it is very possible for nfsd_mode_check() to encounter a @dentry that doesn't have i_op->lookup (see nfs_fhget()'s NFS_ATTR_FATTR_MOUNTPOINT and NFS_ATTR_FATTR_V4_REFERRAL handling, and d_flags_for_inode()).
So remove nfsd_mode_check()'s WARN_ON_ONCE().
--- fs/nfsd/nfsfh.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
fs/nfsd/nfsfh.c +1 -3
@@ -70,10 +70,8 @@ nfsd_mode_check(struct dentry *dentry, umode_t requested)if (requested ==0 )/* the caller doesn't care */ return nfs_ok;if (mode == requested) { -if (mode ==S_IFDIR && !d_can_lookup (dentry)) { -WARN_ON_ONCE (1 ); +if (mode ==S_IFDIR && !d_can_lookup (dentry))return nfserr_notdir; - }return nfs_ok; }if (mode ==S_IFLNK ) {
Signature · 1 line
2.44.0
Chuck Lever
maintainerQuoted 11 lines · Mike Snitzer
The header for commit
e75b23f9e323("nfsd: checkd_can_lookupinfh_verifyof directories") details the assumption that justified adding theWARN_ON_ONCEtonfsd_mode_check(), that assumption is invalid (in the case of NFS reexport).When NFSD exports an NFS filesystem it is very possible for
nfsd_mode_check()to encounter a @dentry that doesn't havei_op->lookup(see nfs_fhget()'sNFS_ATTR_FATTR_MOUNTPOINTandNFS_ATTR_FATTR_V4_REFERRALhandling, andd_flags_for_inode()).[...]
Applied to nfsd-testing, thanks!
[1/1] NFSD: remove flawed WARN_ON_ONCE from nfsd_mode_check
commit: 4b4af25d320d077102026bf72fa2b73614f2605c
--
Chuck Lever