Skip to contentSkip to conversation

cpufreq: powernow-k6: replace symbolic permissions with octal

PATCH In review Jack Lee 4 participants 5 messages Jun 12 – Jun 23 CPU frequency scaling framework

lore
Share & tools
lore

Jack Lee

author
#0 lore raw

PATCH 1/1 cpufreq: powernow-k6: replace symbolic permissions with octal

Symbolic permissions S_IRUGO are deprecated in favor of octal permissions. Replace S_IRUGO with 0444.

---
 drivers/cpufreq/powernow-k6.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/powernow-k6.c +2 -2
index 99d2244e03b0..764907b04c04 100644
@@ -29,10 +29,10 @@ static unsigned int                     max_multiplier;
 static unsigned int			param_busfreq = 0;
 static unsigned int			param_max_multiplier = 0;
 
-module_param_named(max_multiplier, param_max_multiplier, uint, S_IRUGO);
+module_param_named(max_multiplier, param_max_multiplier, uint, 0444);
 MODULE_PARM_DESC(max_multiplier, "Maximum multiplier (allowed values: 20 30 35 40 45 50 55 60)");
 
-module_param_named(bus_frequency, param_busfreq, uint, S_IRUGO);
+module_param_named(bus_frequency, param_busfreq, uint, 0444);
 MODULE_PARM_DESC(bus_frequency, "Bus frequency in kHz");
 
 /* Clock ratio multiplied by 10 - see table 27 in AMD#23446 */
Signature · 1 line
2.54.0
#1 lore raw
Quoted 2 lines · Jack Lee

Symbolic permissions S_IRUGO are deprecated in favor of octal permissions. Replace S_IRUGO with 0444.

Hi Jack,

Thanks for the patch, the change itself looks reasonable.

However, I'm not sure whether this cleanup alone is compelling enough for merge.

It might be worth clarifying the commit message, though — as far as I know, S_IRUGO is not formally deprecated, but rather not preferred, with octal permissions generally recommended instead (see Documentation/dev-tools/checkpatch.rst[1]). Using wording closer to that might be more precise.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/tree/Documentation/dev-tools/checkpatch.rst#n1060

Quoted 23 lines
---
  drivers/cpufreq/powernow-k6.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/powernow-k6.c +2 -2
index 99d2244e03b0..764907b04c04 100644
@@ -29,10 +29,10 @@ static unsigned int                     max_multiplier;
  static unsigned int			param_busfreq = 0;
  static unsigned int			param_max_multiplier = 0;
 
-module_param_named(max_multiplier, param_max_multiplier, uint, S_IRUGO);
+module_param_named(max_multiplier, param_max_multiplier, uint, 0444);
  MODULE_PARM_DESC(max_multiplier, "Maximum multiplier (allowed values: 20 30 35 40 45 50 55 60)");
 
-module_param_named(bus_frequency, param_busfreq, uint, S_IRUGO);
+module_param_named(bus_frequency, param_busfreq, uint, 0444);
  MODULE_PARM_DESC(bus_frequency, "Bus frequency in kHz");
 
  /* Clock ratio multiplied by 10 - see table 27 in AMD#23446 */
Signature · 2 lines
Thx and BRs,
Zhongqiu Han
author
#2 lore raw

PATCH 1/1 cpufreq: powernow-k6: replace symbolic permissions with octal

Symbolic permissions S_IRUGO are not preferred. Replace with octal permissions 0444 as recommended by checkpatch.

---
 drivers/cpufreq/powernow-k6.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/powernow-k6.c +2 -2
index 99d2244e03b0..764907b04c04 100644
@@ -29,10 +29,10 @@ static unsigned int                     max_multiplier;
 static unsigned int			param_busfreq = 0;
 static unsigned int			param_max_multiplier = 0;
 
-module_param_named(max_multiplier, param_max_multiplier, uint, S_IRUGO);
+module_param_named(max_multiplier, param_max_multiplier, uint, 0444);
 MODULE_PARM_DESC(max_multiplier, "Maximum multiplier (allowed values: 20 30 35 40 45 50 55 60)");
 
-module_param_named(bus_frequency, param_busfreq, uint, S_IRUGO);
+module_param_named(bus_frequency, param_busfreq, uint, 0444);
 MODULE_PARM_DESC(bus_frequency, "Bus frequency in kHz");
 
 /* Clock ratio multiplied by 10 - see table 27 in AMD#23446 */
Signature · 1 line
2.54.0
maintainer Acked-by on v1 1/1
#3 lore raw
Quoted 15 lines · Jack Lee

Symbolic permissions S_IRUGO are not preferred. Replace with octal permissions 0444 as recommended by checkpatch.

---
 drivers/cpufreq/powernow-k6.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/powernow-k6.c +0 -0
index 99d2244e03b0..764907b04c04 100644
@@ -29,10 +29,10 @@ static unsigned int                     max_multiplier;
 static unsigned int			param_busfreq = 0;
 static unsigned int			param_max_multiplier = 0;

drivers/cpufreq/powernow-k6.c static unsigned int max_multiplier; · line 38

Quoted 10 lines
drivers/cpufreq/powernow-k6.c +2 -2
 
-module_param_named(max_multiplier, param_max_multiplier, uint, S_IRUGO);
+module_param_named(max_multiplier, param_max_multiplier, uint, 0444);
 MODULE_PARM_DESC(max_multiplier, "Maximum multiplier (allowed values: 20 30 35 40 45 50 55 60)");
 
-module_param_named(bus_frequency, param_busfreq, uint, S_IRUGO);
+module_param_named(bus_frequency, param_busfreq, uint, 0444);
 MODULE_PARM_DESC(bus_frequency, "Bus frequency in kHz");
 
 /* Clock ratio multiplied by 10 - see table 27 in AMD#23446 */
Signature · 1 line
viresh
#4 lore raw
In reply to Jack Lee
Quoted 5 lines · Jack Lee

Symbolic permissions S_IRUGO are not preferred. Replace with octal permissions 0444 as recommended by checkpatch.

I don't see a good enough reason for making this change, sorry.

First, checkpatch.pl messages regarding the existing code are irrelevant.

Second, this particular driver is in a deep maintenance mode and the particular update in question is not significant enough for touching it IMV.

Quoted 24 lines
---
 drivers/cpufreq/powernow-k6.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/powernow-k6.c +2 -3
index 99d2244e03b0..764907b04c04 100644
@@ -29,10 +29,10 @@ static unsigned int                     max_multiplier;
 static unsigned int                    param_busfreq = 0;
 static unsigned int                    param_max_multiplier = 0;
 
-module_param_named(max_multiplier, param_max_multiplier, uint, S_IRUGO);
+module_param_named(max_multiplier, param_max_multiplier, uint, 0444);
 MODULE_PARM_DESC(max_multiplier, "Maximum multiplier (allowed values: 20 30 35 40 45 50 55 60)");
 
-module_param_named(bus_frequency, param_busfreq, uint, S_IRUGO);
+module_param_named(bus_frequency, param_busfreq, uint, 0444);
 MODULE_PARM_DESC(bus_frequency, "Bus frequency in kHz");
 
 /* Clock ratio multiplied by 10 - see table 27 in AMD#23446 */
--

2.54.0