Skip to contentSkip to conversation

crypto: s5p-sss - correct CONFIG_CRYPTO_DEV_EXYNOS_RNG macro name in comment

PATCH In review Ethan Nelson-Moore 2 participants 3 messages Jun 13 – Jun 14

Subsystems (3)
Crypto API Arm Samsung Exynos Samsung S5P Security SubSystem (sss) driver
lore
Share & tools
lore

Ethan Nelson-Moore

author
#0 lore raw

PATCH 1/1 crypto: s5p-sss - correct CONFIG_CRYPTO_DEV_EXYNOS_RNG macro name in comment

A comment in drivers/crypto/s5p-sss.c incorrectly refers to CONFIG_EXYNOS_RNG instead of CONFIG_CRYPTO_DEV_EXYNOS_RNG. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

Signed-off-by Ethan Nelson-Moore <[email protected]>
---
 drivers/crypto/s5p-sss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/s5p-sss.c +2 -2
index bdda7b39af85..9bb1b1661174 100644
@@ -2151,8 +2151,8 @@ static int s5p_aes_probe(struct platform_device *pdev)
 
 	/*
 	 * Note: HASH and PRNG uses the same registers in secss, avoid
-	 * overwrite each other. This will drop HASH when CONFIG_EXYNOS_RNG
-	 * is enabled in config. We need larger size for HASH registers in
+	 * overwrite each other. This will drop HASH when CONFIG_CRYPTO_DEV_EXYNOS_RNG
+	 * is enabled. We need larger size for HASH registers in
 	 * secss, current describe only AES/DES
 	 */
 	if (IS_ENABLED(CONFIG_CRYPTO_DEV_EXYNOS_HASH)) {
Signature · 1 line
2.43.0
#1 lore raw
Quoted 16 lines · Ethan Nelson-Moore

A comment in drivers/crypto/s5p-sss.c incorrectly refers to CONFIG_EXYNOS_RNG instead of CONFIG_CRYPTO_DEV_EXYNOS_RNG. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

Signed-off-by Ethan Nelson-Moore <[email protected]>
---
 drivers/crypto/s5p-sss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/s5p-sss.c +0 -0
index bdda7b39af85..9bb1b1661174 100644

drivers/crypto/s5p-sss.c static int s5p_aes_probe(struct platform_device *pdev) · line 2158

Quoted 10 lines
drivers/crypto/s5p-sss.c +2 -2
@@ -2151,8 +2151,8 @@ static int s5p_aes_probe(struct platform_device *pdev)
 
 	/*
 	 * Note: HASH and PRNG uses the same registers in secss, avoid
-	 * overwrite each other. This will drop HASH when CONFIG_EXYNOS_RNG
-	 * is enabled in config. We need larger size for HASH registers in
+	 * overwrite each other. This will drop HASH when CONFIG_CRYPTO_DEV_EXYNOS_RNG
+	 * is enabled. We need larger size for HASH registers in
 	 * secss, current describe only AES/DES
 	 */
 	if (IS_ENABLED(CONFIG_CRYPTO_DEV_EXYNOS_HASH)) {

CONFIG_CRYPTO_DEV_EXYNOS_RNG was already removed by
https://lore.kernel.org/linux-crypto/[email protected]/

I didn't want to touch this comment which is nonsense anyway. But if you're going to try to update it, it should be updated to correctly explain that the driver is working around broken devicetree bindings.

- Eric

author
#2 lore raw

Hi, Eric,

Quoted 2 lines · Eric Biggers

CONFIG_CRYPTO_DEV_EXYNOS_RNG was already removed by
https://lore.kernel.org/linux-crypto/[email protected]/

Thanks for letting me know.

Quoted 3 lines

I didn't want to touch this comment which is nonsense anyway. But if you're going to try to update it, it should be updated to correctly explain that the driver is working around broken devicetree bindings.

Yes, that comment definitely needs rewriting - I had no idea that is what it is referring to.

Ethan