crypto: amcc: move ioremapping up
PATCH 1/1 crypto: amcc: move ioremapping up
There's no need for devm_platform_ioremap_resource() to be so far down. In fact, putting it up allows direct return instead of having to goto some branch. Also, remove the error message as the function complains loudly itself. No need to duplicate.
Signed-off-by Rosen Penev <[email protected]>
--- drivers/crypto/amcc/crypto4xx_core.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/crypto/amcc/crypto4xx_core.c +4 -7
@@ -1251,6 +1251,10 @@ static int crypto4xx_probe(struct platform_device *ofdev)if (!core_dev->dev)return -ENOMEM ; + core_dev->dev->ce_base =devm_platform_ioremap_resource (ofdev,0 ); +if (IS_ERR (core_dev->dev->ce_base)) +return PTR_ERR (core_dev->dev->ce_base); +/* * Older version of 460EX/GT have a hardware bug. * Hence they do not support H/W based security intr coalescing
@@ -1286,13 +1290,6 @@ static int crypto4xx_probe(struct platform_device *ofdev)tasklet_init (&core_dev->tasklet, crypto4xx_bh_tasklet_cb, (unsigned long ) dev); - core_dev->dev->ce_base =devm_platform_ioremap_resource (ofdev,0 ); -if (IS_ERR (core_dev->dev->ce_base)) { -dev_err (&ofdev->dev,"failed to ioremap resource" ); - rc =PTR_ERR (core_dev->dev->ce_base); - goto err_build_sdr; - } -/* Register for Crypto isr, Crypto Engine IRQ */ core_dev->irq =platform_get_irq (ofdev,0 );if (core_dev->irq <0 ) {
Signature · 1 line
2.54.0
Herbert Xu
maintainerQuoted 9 lines · Rosen Penev
There's no need for
devm_platform_ioremap_resource()to be so far down. In fact, putting it up allows direct return instead of having to goto some branch. Also, remove the error message as the function complains loudly itself. No need to duplicate.Signed-off-by Rosen Penev <[email protected]>--- drivers/crypto/amcc/crypto4xx_core.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt