powerpc/pseries: fix memory leak on krealloc failure in papr_init
Subsystems (2)
PATCH 1/1 powerpc/pseries: fix memory leak on krealloc failure in papr_init
When krealloc() fails, free the original esi_buf before returning to avoid a memory leak.
Fixes 3c14b73454cf ("powerpc/pseries: Interface to represent PAPR firmware attributes")
Signed-off-by Thorsten Blum <[email protected]>
--- arch/powerpc/platforms/pseries/papr_platform_attributes.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
arch/powerpc/platforms/pseries/papr_platform_attributes.c +3 -5
@@ -271,11 +271,9 @@ static int __init papr_init(void) esi_buf_size =ESI_HDR_SIZE + (CURR_MAX_ESI_ATTRS * max_esi_attrs); temp_esi_buf =krealloc (esi_buf, esi_buf_size,GFP_KERNEL ); -if (temp_esi_buf) - esi_buf = temp_esi_buf; -else -return -ENOMEM ; - +if (!temp_esi_buf) + goto out_free_esi_buf; + esi_buf = temp_esi_buf; goto retry; }
Quoted 4 lines · Thorsten Blum
When
krealloc()fails, free the originalesi_bufbefore returning to avoid a memory leak.
Applied to powerpc/fixes.
[1/1] powerpc/pseries: fix memory leak on krealloc failure in papr_init
https://git.kernel.org/powerpc/c/bd83c98b988d2c560531084e296dbfb530aff829
cheers