Skip to contentSkip to conversation

appletalk: move the protocol out of tree

PATCH Applied Jakub Kicinski 9 participants 15 messages Jun 15 – Jun 18

Subsystems (8)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

cover appletalk: move the protocol out of tree

This tiny series moves appletalk out of tree, to:

https://github.com/linux-netdev/mod-orphan

Core maintainainers are unable to keep up with the rate of security bug reports and fixes. Nobody seems to care about appletalk enough to review the patches.

As Eric pointed out Mac OS dropped AppleTalk over a decade ago.

Jakub Kicinski (2):
appletalk: stop storing per-interface state in struct net_device
appletalk: move the protocol out of tree

 MAINTAINERS                                   |    5 +-
 Documentation/admin-guide/sysctl/net.rst      |   46 +-
 .../networking/net_cachelines/net_device.rst  |    1 -
 net/Kconfig                                   |    1 -
 net/appletalk/Kconfig                         |   30 -
 net/802/Makefile                              |    1 -
 net/Makefile                                  |    1 -
 net/appletalk/Makefile                        |   10 -
 include/linux/atalk.h                         |  186 --
 include/linux/netdevice.h                     |    4 -
 net/appletalk/aarp.c                          | 1041 ---------
 net/appletalk/atalk_proc.c                    |  242 --
 net/appletalk/ddp.c                           | 2017 -----------------
 net/appletalk/sysctl_net_atalk.c              |   58 -
 arch/arm/configs/ixp4xx_defconfig             |    1 -
 arch/m68k/configs/amiga_defconfig             |    1 -
 arch/m68k/configs/apollo_defconfig            |    1 -
 arch/m68k/configs/atari_defconfig             |    1 -
 arch/m68k/configs/bvme6000_defconfig          |    1 -
 arch/m68k/configs/hp300_defconfig             |    1 -
 arch/m68k/configs/mac_defconfig               |    1 -
 arch/m68k/configs/multi_defconfig             |    1 -
 arch/m68k/configs/mvme147_defconfig           |    1 -
 arch/m68k/configs/mvme16x_defconfig           |    1 -
 arch/m68k/configs/q40_defconfig               |    1 -
 arch/m68k/configs/sun3_defconfig              |    1 -
 arch/m68k/configs/sun3x_defconfig             |    1 -
 arch/mips/configs/gpr_defconfig               |    1 -
 arch/mips/configs/malta_defconfig             |    1 -
 arch/mips/configs/malta_kvm_defconfig         |    1 -
 arch/mips/configs/malta_qemu_32r6_defconfig   |    1 -
 arch/mips/configs/maltaaprp_defconfig         |    1 -
 arch/mips/configs/maltasmvp_defconfig         |    1 -
 arch/mips/configs/maltasmvp_eva_defconfig     |    1 -
 arch/mips/configs/maltaup_defconfig           |    1 -
 arch/mips/configs/maltaup_xpa_defconfig       |    1 -
 arch/mips/configs/mtx1_defconfig              |    1 -
 arch/powerpc/configs/ppc6xx_defconfig         |    1 -
 arch/sh/configs/landisk_defconfig             |    1 -
 39 files changed, 3 insertions(+), 3665 deletions(-)
 delete mode 100644 net/appletalk/Kconfig
 delete mode 100644 net/appletalk/Makefile
 delete mode 100644 include/linux/atalk.h
 delete mode 100644 net/appletalk/aarp.c
 delete mode 100644 net/appletalk/atalk_proc.c
 delete mode 100644 net/appletalk/ddp.c
 delete mode 100644 net/appletalk/sysctl_net_atalk.c
Signature · 1 line
2.54.0
author maintainer
#1 lore raw

PATCH 1/2 appletalk: stop storing per-interface state in struct net_device

AppleTalk keeps its per-interface control block (struct atalk_iface) directly in struct netdevice (dev->atalk_ptr). This is the only thing tying the protocol into the core net_device layout and is the sole blocker to moving AppleTalk out of tree.

Replace dev->atalk_ptr with a small ifindex-keyed hashtable internal to ddp.c. The existing atalk_interfaces list stays the owner of the iface objects; the hashtable is purely a fast dev->iface index and reuses the same atalk_interfaces_lock.

AFAICT this patch does not make this code any more racy than it already is, I'm sure Sashiko will point out some basically existing bugs. AFAICT atalk_interfaces_lock is the innermost lock already.

---
 .../networking/net_cachelines/net_device.rst  |  1 -
 include/linux/atalk.h                         |  8 +---
 include/linux/netdevice.h                     |  4 --
 net/appletalk/ddp.c                           | 48 +++++++++++++++++--
 4 files changed, 45 insertions(+), 16 deletions(-)
Documentation/networking/net_cachelines/net_device.rst +0 -1
index eb2e6851c6f6..512f6d6fa3d8 100644
@@ -90,7 +90,6 @@ struct inet6_dev*                   ip6_ptr                     read_mostly
 struct vlan_info*                   vlan_info
 struct dsa_port*                    dsa_ptr
 struct tipc_bearer*                 tipc_ptr
-void*                               atalk_ptr
 struct wireless_dev*                ieee80211_ptr
 struct wpan_dev*                    ieee802154_ptr
 struct mpls_dev*                    mpls_ptr
include/linux/atalk.h +2 -6
index a55bfc6567d0..ce7e6bfa9e2a 100644
@@ -30,6 +30,7 @@ struct atalk_iface {
 #define ATIF_PROBE_FAIL	2		/* Probe collided */
 	struct atalk_netrange	nets;
 	struct atalk_iface	*next;
+	struct hlist_node	hash_node;	/* keyed on dev->ifindex */
 };
 	
 struct atalk_sock {
@@ -113,12 +114,7 @@ extern int aarp_proto_init(void);
 /* Inter module exports */
 
 /* Give a device find its atif control structure */
-#if IS_ENABLED(CONFIG_ATALK)
-static inline struct atalk_iface *atalk_find_dev(struct net_device *dev)
-{
-	return dev->atalk_ptr;
-}
-#endif
+extern struct atalk_iface *atalk_find_dev(struct net_device *dev);
 
 extern struct atalk_addr *atalk_find_dev_addr(struct net_device *dev);
 extern struct net_device *atrtr_get_dev(struct atalk_addr *sa);
include/linux/netdevice.h +0 -4
index 7f4f0837c09f..655564621f28 100644
@@ -1947,7 +1947,6 @@ enum netdev_reg_state {
  *	@vlan_info:	VLAN info
  *	@dsa_ptr:	dsa specific data
  *	@tipc_ptr:	TIPC specific data
- *	@atalk_ptr:	AppleTalk link
  *	@ip_ptr:	IPv4 specific data
  *	@ip6_ptr:	IPv6 specific data
  *	@ieee80211_ptr:	IEEE 802.11 specific data, assign before registering
@@ -2349,9 +2348,6 @@ struct net_device {
 #if IS_ENABLED(CONFIG_TIPC)
 	struct tipc_bearer __rcu *tipc_ptr;
 #endif
-#if IS_ENABLED(CONFIG_ATALK)
-	void 			*atalk_ptr;
-#endif
 #if IS_ENABLED(CONFIG_CFG80211)
 	struct wireless_dev	*ieee80211_ptr;
 #endif
net/appletalk/ddp.c +43 -5

99 lines not on this page · raw message

Signature · 1 line
2.54.0
author maintainer
#2 lore raw

PATCH 2/2 appletalk: move the protocol out of tree

In reply to Jakub Kicinski

AppleTalk has been removed in MacOS X 10.6 (Snow Leopard), in 2009, according to Wikipedia. We recently got a burst of AI generated fixes to this protocol which nobody is reviewing.

Let AppleTalk follow AX.25 and hamradio out of the Linux tree. We we will maintain the code at: github.com/linux-netdev/mod-orphan for anyone interested in playing with it.

Retain the uAPI for now. No strong reason, simply because I suspect keeping it will be less controversial.

---
 MAINTAINERS                                 |    5 +-
 Documentation/admin-guide/sysctl/net.rst    |   46 +-
 net/Kconfig                                 |    1 -
 net/appletalk/Kconfig                       |   30 -
 net/802/Makefile                            |    1 -
 net/Makefile                                |    1 -
 net/appletalk/Makefile                      |   10 -
 include/linux/atalk.h                       |  182 --
 net/appletalk/aarp.c                        | 1041 ----------
 net/appletalk/atalk_proc.c                  |  242 ---
 net/appletalk/ddp.c                         | 2055 -------------------
 net/appletalk/sysctl_net_atalk.c            |   58 -
 arch/arm/configs/ixp4xx_defconfig           |    1 -
 arch/m68k/configs/amiga_defconfig           |    1 -
 arch/m68k/configs/apollo_defconfig          |    1 -
 arch/m68k/configs/atari_defconfig           |    1 -
 arch/m68k/configs/bvme6000_defconfig        |    1 -
 arch/m68k/configs/hp300_defconfig           |    1 -
 arch/m68k/configs/mac_defconfig             |    1 -
 arch/m68k/configs/multi_defconfig           |    1 -
 arch/m68k/configs/mvme147_defconfig         |    1 -
 arch/m68k/configs/mvme16x_defconfig         |    1 -
 arch/m68k/configs/q40_defconfig             |    1 -
 arch/m68k/configs/sun3_defconfig            |    1 -
 arch/m68k/configs/sun3x_defconfig           |    1 -
 arch/mips/configs/gpr_defconfig             |    1 -
 arch/mips/configs/malta_defconfig           |    1 -
 arch/mips/configs/malta_kvm_defconfig       |    1 -
 arch/mips/configs/malta_qemu_32r6_defconfig |    1 -
 arch/mips/configs/maltaaprp_defconfig       |    1 -
 arch/mips/configs/maltasmvp_defconfig       |    1 -
 arch/mips/configs/maltasmvp_eva_defconfig   |    1 -
 arch/mips/configs/maltaup_defconfig         |    1 -
 arch/mips/configs/maltaup_xpa_defconfig     |    1 -
 arch/mips/configs/mtx1_defconfig            |    1 -
 arch/powerpc/configs/ppc6xx_defconfig       |    1 -
 arch/sh/configs/landisk_defconfig           |    1 -
 37 files changed, 3 insertions(+), 3694 deletions(-)
 delete mode 100644 net/appletalk/Kconfig
 delete mode 100644 net/appletalk/Makefile
 delete mode 100644 include/linux/atalk.h
 delete mode 100644 net/appletalk/aarp.c
 delete mode 100644 net/appletalk/atalk_proc.c
 delete mode 100644 net/appletalk/ddp.c
 delete mode 100644 net/appletalk/sysctl_net_atalk.c
MAINTAINERS +2 -3
index cc1dde0c9067..06df1171f4cf 100644
@@ -1968,10 +1968,9 @@ F:	drivers/hwmon/applesmc.c
 
 APPLETALK NETWORK LAYER
 L:	[email protected]
-S:	Odd fixes
-F:	include/linux/atalk.h
+S:	Obsolete
 F:	include/uapi/linux/atalk.h
-F:	net/appletalk/
+F:	include/uapi/linux/if_ltalk.h
 
 APPLIED MICRO (APM) X-GENE DEVICE TREE SUPPORT
 M:	Khuong Dinh <[email protected]>
Documentation/admin-guide/sysctl/net.rst +1 -45

52 lines not on this page · raw message

net/Kconfig +0 -1
index bdea8aef7983..e38477393551 100644
@@ -261,7 +261,6 @@ source "net/bridge/Kconfig"
 source "net/dsa/Kconfig"
 source "net/8021q/Kconfig"
 source "net/llc/Kconfig"
-source "net/appletalk/Kconfig"
 source "net/x25/Kconfig"
 source "net/lapb/Kconfig"
 source "net/phonet/Kconfig"
net/appletalk/Kconfig deleted +0 -30
deleted file mode 100644
index 041141abf925..000000000000
@@ -1,30 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-#
-# Appletalk configuration
-#
-config ATALK
-	tristate "Appletalk protocol support"
-	select LLC
-	help
-	  AppleTalk is the protocol that Apple computers can use to communicate
-	  on a network.  If your Linux box is connected to such a network and you
-	  wish to connect to it, say Y.  You will need to use the netatalk package
-	  so that your Linux box can act as a print and file server for Macs as
-	  well as access AppleTalk printers.  Check out
-	  <http://www.zettabyte.net/netatalk/> on the WWW for details.
-	  EtherTalk is the name used for AppleTalk over Ethernet and the
-	  cheaper and slower LocalTalk is AppleTalk over a proprietary Apple
-	  network using serial links.  EtherTalk and LocalTalk are fully
-	  supported by Linux.
-
-	  General information about how to connect Linux, Windows machines and
-	  Macs is on the WWW at <http://www.eats.com/linux_mac_win.html>.  The
-	  NET3-4-HOWTO, available from
-	  <http://www.tldp.org/docs.html#howto>, contains valuable
-	  information as well.
-
-	  To compile this driver as a module, choose M here: the module will be
-	  called appletalk. You almost certainly want to compile it as a
-	  module so you can restart your AppleTalk stack without rebooting
-	  your machine. I hear that the GNU boycott of Apple is over, so
-	  even politically correct people are allowed to say Y here.
net/802/Makefile +0 -1
index 9503ef6b2e06..54784f3cae5a 100644
@@ -6,7 +6,6 @@
 obj-$(CONFIG_LLC)	+= psnap.o
 obj-$(CONFIG_NET_FC)	+=                 fc.o
 obj-$(CONFIG_FDDI)	+=                 fddi.o
-obj-$(CONFIG_ATALK)	+= psnap.o
 obj-$(CONFIG_STP)	+= stp.o
 obj-$(CONFIG_GARP)	+= garp.o
 obj-$(CONFIG_MRP)	+= mrp.o
net/Makefile +0 -1
index d2175fce0406..5b2dd7f07a85 100644
@@ -25,7 +25,6 @@ obj-$(CONFIG_NET_KEY)		+= key/
 obj-$(CONFIG_BRIDGE)		+= bridge/
 obj-$(CONFIG_NET_DEVLINK)	+= devlink/
 obj-y				+= dsa/
-obj-$(CONFIG_ATALK)		+= appletalk/
 obj-$(CONFIG_X25)		+= x25/
 obj-$(CONFIG_LAPB)		+= lapb/
 obj-$(CONFIG_CAN)		+= can/
net/appletalk/Makefile deleted +0 -10
deleted file mode 100644
index 152312a15180..000000000000
@@ -1,10 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-#
-# Makefile for the Linux AppleTalk layer.
-#
-
-obj-$(CONFIG_ATALK) += appletalk.o
-
-appletalk-y			:= aarp.o ddp.o
-appletalk-$(CONFIG_PROC_FS)	+= atalk_proc.o
-appletalk-$(CONFIG_SYSCTL)	+= sysctl_net_atalk.o
include/linux/atalk.h deleted +0 -182

182 lines not on this page · raw message

net/appletalk/aarp.c deleted +0 -1041

1,041 lines not on this page · raw message

net/appletalk/atalk_proc.c deleted +0 -242

242 lines not on this page · raw message

net/appletalk/ddp.c deleted +0 -2055

1,410 lines not on this page · raw message

net/appletalk/sysctl_net_atalk.c deleted +0 -58

58 lines not on this page · raw message

arch/arm/configs/ixp4xx_defconfig +0 -1
index 01d72580bcc5..418ef909572b 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/amiga_defconfig +0 -1
index aadff466830f..93b1cb632b19 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/apollo_defconfig +0 -1
index ea9487a39884..6edfa55c8b9f 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/atari_defconfig +0 -1
index a70127ac7a2d..f8808aac9e63 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/bvme6000_defconfig +0 -1
index 83da79382538..067ecf850201 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/hp300_defconfig +0 -1
index cea5ab74b3b1..aa93c67caa43 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/mac_defconfig +0 -1
index 26406777376d..79d2e0383484 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/multi_defconfig +0 -1
index 8357491645ad..b13889268ff5 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/mvme147_defconfig +0 -1
index fe94f95862e7..cd773d2509bb 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/mvme16x_defconfig +0 -1
index ba67cacc079e..af921f24a5c8 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/q40_defconfig +0 -1
index 552399979e4b..f2eb67618e97 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/sun3_defconfig +0 -1
index b4f3935d3d18..108dac7ed55e 100644

Lines of this file are not shown. View the raw message.

arch/m68k/configs/sun3x_defconfig +0 -1
index bb519520ae6e..1e1d946cbe23 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/gpr_defconfig +0 -1
index 47016655a089..7834569a8314 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/malta_defconfig +0 -1
index 61c9d5cd1a75..89d7c47ca7f0 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/malta_kvm_defconfig +0 -1
index f862fbc7fbb7..39c69af12adc 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/malta_qemu_32r6_defconfig +0 -1
index 14cdd23f1acb..5feb1dc43bae 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/maltaaprp_defconfig +0 -1
index 2943593264b9..a69fb992b82a 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/maltasmvp_defconfig +0 -1
index 47226fca0548..689edb56c055 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/maltasmvp_eva_defconfig +0 -1
index 09187a78409f..a56db606b2d8 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/maltaup_defconfig +0 -1
index a80783097c1e..ee10762ab593 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/maltaup_xpa_defconfig +0 -1
index e660c503654e..0e207bb0f794 100644

Lines of this file are not shown. View the raw message.

arch/mips/configs/mtx1_defconfig +0 -1
index a1c374bd4785..46b40784a828 100644

Lines of this file are not shown. View the raw message.

arch/powerpc/configs/ppc6xx_defconfig +0 -1
index c9bdaed06d03..f528cab1c6cf 100644

Lines of this file are not shown. View the raw message.

arch/sh/configs/landisk_defconfig +0 -1
index 4c39a23e6e0d..2b7e10c9acee 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.54.0

Part of the diff is not shown here. View the raw message.

#3 lore raw
In reply to Jakub Kicinski

Hello Jakub,

Quoted 7 lines · Jakub Kicinski

This tiny series moves appletalk out of tree, to:

https://github.com/linux-netdev/mod-orphan

Core maintainainers are unable to keep up with the rate of security bug reports and fixes. Nobody seems to care about appletalk enough to review the patches.

Why would fixing these vulnerabilities be relevant? No one is going to expose an Apple Talk server to an untrusted network, are they? The same applies to hamradio and AX.25, they are all used by hobbyists in DMZ networks, so no one really cares about vulnerabilities in these protocols.

I find it sad that AI tools are basically used to shoot at the kernel to kill off features as some people are apparently getting scared by these AI reports and just nuke everything in a panic reaction as if it wouldn't just be possible to disable these protocols at compile time to reduce the attack surface.

Quoted 1 line

As Eric pointed out Mac OS dropped AppleTalk over a decade ago.

That's not the point though. No one is going to use AppleTalk to network a Linux box to a modern macOS machine. The usefulness lies in hooking up a Linux box to a vintage Mac or other retro computer.

So far, one of the huge advantages of open source operating systems has always been that even niche use cases were supported and people could make use of old hardware by using open source operating systems over commercial offerings such as Windows or macOS.

With the advent of AI security reports, these niche use cases are more and more being killed off with the argument that a vulnerability in the harmradio code could pose a threat to a large SAP database running on a Linux enterprise distribution. However, if your enterprise distribution is enabling kernel features their customers aren't using and therefore enlarging the attack surface, it's more a problem of said enterprise distribution and not of these old and obscure network protocols.

I am trying my best to save as many classic features in the kernel as possible to enable retro computing but I am sometimes fearing that commercial interest in the kernel is taking over too much making my efforts harder every day.

Adrian

Signature · 4 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
author maintainer
#4 lore raw
Quoted 39 lines · On Tue, 16 Jun 2026 01:34:06 +0200 John Paul Adrian Glaubitz wrote:
Quoted 7 lines · Jakub Kicinski

This tiny series moves appletalk out of tree, to:

https://github.com/linux-netdev/mod-orphan

Core maintainainers are unable to keep up with the rate of security bug reports and fixes. Nobody seems to care about appletalk enough to review the patches.

Why would fixing these vulnerabilities be relevant? No one is going to expose an Apple Talk server to an untrusted network, are they? The same applies to hamradio and AX.25, they are all used by hobbyists in DMZ networks, so no one really cares about vulnerabilities in these protocols.

I find it sad that AI tools are basically used to shoot at the kernel to kill off features as some people are apparently getting scared by these AI reports and just nuke everything in a panic reaction as if it wouldn't just be possible to disable these protocols at compile time to reduce the attack surface.

Quoted 1 line

As Eric pointed out Mac OS dropped AppleTalk over a decade ago.

That's not the point though. No one is going to use AppleTalk to network a Linux box to a modern macOS machine. The usefulness lies in hooking up a Linux box to a vintage Mac or other retro computer.

So far, one of the huge advantages of open source operating systems has always been that even niche use cases were supported and people could make use of old hardware by using open source operating systems over commercial offerings such as Windows or macOS.

With the advent of AI security reports, these niche use cases are more and more being killed off with the argument that a vulnerability in the harmradio code could pose a threat to a large SAP database running on a Linux enterprise distribution. However, if your enterprise distribution is enabling kernel features their customers aren't using and therefore enlarging the attack surface, it's more a problem of said enterprise distribution and not of these old and obscure network protocols.

Quoted 3 lines

I am trying my best to save as many classic features in the kernel as possible to enable retro computing but I am sometimes fearing that commercial interest in the kernel is taking over too much making my efforts harder every day.

We can complain about the AI slop til the cows comes home. I don't like it, you don't like it. What difference does it make?

If y'all have real solutions please share. Complaining about "commercial interests" and "nuk[ing] everything in a panic reaction" is not helpful.

Acked-by on the v1 series
#13 lore raw
In reply to Jakub Kicinski
Quoted 9 lines · On Mon, 15 Jun 2026 15:29:33 -0700 Jakub Kicinski <[email protected]> wrote:

This tiny series moves appletalk out of tree, to:

https://github.com/linux-netdev/mod-orphan

Core maintainainers are unable to keep up with the rate of security bug reports and fixes. Nobody seems to care about appletalk enough to review the patches.

As Eric pointed out Mac OS dropped AppleTalk over a decade ago.

#5 lore raw
In reply to Jakub Kicinski

Hi,

I'm a user of AppleTalk and other "Retro"-Features in the Linux Kernel.

Quoted 6 lines · Jakub Kicinski

We can complain about the AI slop til the cows comes home. I don't like it, you don't like it. What difference does it make?

If y'all have real solutions please share. Complaining about "commercial interests" and "nuk[ing] everything in a panic reaction" is not helpful.

the solution, as Adrian pointed out, is to leave these features in the Linux kernel but have them disabled by default. Maybe put a warning message in the kernel config tools that people should only enable these if they know what they are doing.

These "retro"-features should not pose any security risk of they are not compiled into a kernel.

Greetings

Carsten

author maintainer
#6 lore raw
Quoted 7 lines · On Tue, 16 Jun 2026 09:13:46 +0200 Carsten Strotmann wrote:

I'm a user of AppleTalk and other "Retro"-Features in the Linux Kernel.

Quoted 3 lines · Jakub Kicinski

We can complain about the AI slop til the cows comes home. I don't like it, you don't like it. What difference does it make?

Quoted 6 lines
Quoted 3 lines

If y'all have real solutions please share. Complaining about "commercial interests" and "nuk[ing] everything in a panic reaction" is not helpful.

the solution, as Adrian pointed out, is to leave these features in the Linux kernel but have them disabled by default.

I think y'all need to internalize that "just leave it in" means work. _Someone_ has to handle the reports and patches. And since nobody is doing that the code is going to GitHub, where it can continue to "just be left" or whatever, without racking up CVEs for the Linux kernel and leading to maintainer burn out :/

Quoted 5 lines

Maybe put a warning message in the kernel config tools that people should only enable these if they know what they are doing.

These "retro"-features should not pose any security risk of they are not compiled into a kernel.

Nobody is stopping you from using this code! It's perfectly suitable to be an out of tree module. Maybe it'd be harder if someone wanted to remove a CPU architecture you want to use, but protocols are perfectly fine as loadable modules. You can continue to use the code from:
https://github.com/linux-netdev/mod-orphan

Presumably you could get Debian to package that and you wouldn't even know the sources no longer live in the kernel tree.

#14 lore raw
In reply to Jakub Kicinski
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Mon, 15 Jun 2026 15:29:33 -0700 you wrote:

This tiny series moves appletalk out of tree, to:

https://github.com/linux-netdev/mod-orphan

Core maintainainers are unable to keep up with the rate of security bug reports and fixes. Nobody seems to care about appletalk enough to review the patches.

[...]

Here is the summary with links:
- [net-next,1/2] appletalk: stop storing per-interface state in struct net_device

    https://git.kernel.org/netdev/net-next/c/023f9b0f2f4f
  - [net-next,2/2] appletalk: move the protocol out of tree
    https://git.kernel.org/netdev/net-next/c/8a398a0c189e

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#7 lore raw
In reply to Jakub Kicinski

Hi Jakub,

Quoted 8 lines · Jakub Kicinski
Quoted 3 lines

the solution, as Adrian pointed out, is to leave these features in the Linux kernel but have them disabled by default.
I think y'all need to internalize that "just leave it in" means work.

_Someone_ has to handle the reports and patches. And since nobody is doing that the code is going to GitHub, where it can continue to "just be left" or whatever, without racking up CVEs for the Linux kernel and leading to maintainer burn out :/

That's a good point. The large influx of reports is a problem, and burn out of maintainers is a too high cost.

Quoted 11 lines
Quoted 5 lines

Maybe put a warning message in the kernel config tools that people should only enable these if they know what they are doing.

Quoted 1 line
Quoted 1 line

These "retro"-features should not pose any security risk of they are

not compiled into a kernel.
Nobody is stopping you from using this code! It's perfectly suitable > to be an out of tree module. Maybe it'd be harder if someone wanted to

remove a CPU architecture you want to use, but protocols are perfectly fine as loadable modules. You can continue to use the code from:
https://github.com/linux-netdev/mod-orphan

Quoted 1 line

Presumably you could get Debian to package that and you wouldn't even

know the sources no longer live in the kernel tree.

It seems the current situation is the price of success (of Linux, which is good).

I guess the way to go would be to move these old drivers to userspace in order to reduce dependencies on the Linux Kernel. But that is not a task for the Linux-Maintainers, but for the Retro-Community.

Thanks for your work and the background information

Carsten

Signature · 1 line
https://strotmann.de
#8 lore raw
Quoted 9 lines · Carsten Strotmann
Quoted 5 lines

_Someone_ has to handle the reports and patches. And since nobody is doing that the code is going to GitHub, where it can continue to "just be left" or whatever, without racking up CVEs for the Linux kernel and leading to maintainer burn out :/

That's a good point. The large influx of reports is a problem, and burn out of maintainers is a too high cost.

Carsten, if, as a maintainer, you want to avoid burnout then

1) don't promise what you can't deliver (that is, decline sponsorship)

2) delegate (that is, leverage AI as an ally not as a lame excuse)

So the question remains: what is it which _can_ be delivered by and for the "community" (by which I mean, that group of people which includes actual end users -- not merely paying customers and sponsored developers).

This question has precious little to do with burnout, but it's the question we need to address.

#9 lore raw
Quoted 9 lines · Finn Thain
Quoted 6 lines · Carsten Strotmann
Quoted 5 lines

_Someone_ has to handle the reports and patches. And since nobody is doing that the code is going to GitHub, where it can continue to "just be left" or whatever, without racking up CVEs for the Linux kernel and leading to maintainer burn out :/

Quoted 5 lines
Quoted 3 lines

That's a good point. The large influx of reports is a problem, and burn out of maintainers is a too high cost.

Carsten, if, as a maintainer, you want to avoid burnout then

It is not necessarily Carsten who is heading towards burnout. appletalk is just one of many many drivers where the listed Maintainers does not respond to patches, or there is no Maintainer at all. So a lot of work falls on the top level netdev Maintainers. In fact, a lot of the AI driven bug fixes tend to fall into this category of old drivers with no active Maintainers, since that tends to be where the poorer quality code is. So top level netdev Maintainers are having to do a lot more work, on old drivers which very few people care about. That is a poor use of their talent, when we actually want them working on drivers for modern hardware with a lot of users.

If the appletalk community can take the workload off the top level maintainers, respond to all patches within 2 to 3 days, give Reviewed-by, or make change requests, it can probably stay in the Mainline kernel. Otherwise it will move out of tree.

Andrew

#10 lore raw

Hi Andrew,

Quoted 4 lines · Andrew Lunn

If the appletalk community can take the workload off the top level maintainers, respond to all patches within 2 to 3 days, give Reviewed-by, or make change requests, it can probably stay in the Mainline kernel. Otherwise it will move out of tree.

"2 or 3 days" is rather short. If we would have to move all code maintained by people who cannot respond to all patches within 2 to 3 days out of the mainline kernel, you'd end up with a networking subsystem without supporting OS ;-)

git grep three.*week -- Documentation/

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#12 lore raw
In reply to Andrew Lunn
Quoted 3 lines · Andrew Lunn

appletalk is just one of many many drivers where the listed Maintainers does not respond to patches, or there is no Maintainer at all. So a lot of work falls on the top level netdev Maintainers.

It goes with the territory. If that messes up their performance reviews, I am okay with that. We all make our own choices.

Quoted 3 lines

In fact, a lot of the AI driven bug fixes tend to fall into this category of old drivers with no active Maintainers, since that tends to be where the poorer quality code is.

That has not been my experience. I rarely see a review from sashiko-bot on the scsi mailing list that doesn't list as many pre-existing bugs as new bugs. This is almost always actively developed code, not mature code.

In anycase, quality is irrelevant here. I'm happy to see fixes for any code base whatever its level of quality and whatever the quality metric.

What matters more to me than quality is utility.

Quoted 5 lines

So top level netdev Maintainers are having to do a lot more work, on old drivers which very few people care about. That is a poor use of their talent, when we actually want them working on drivers for modern hardware with a lot of users.

Again, that has not been my experience. Linux often gets installed because the hardware is not modern enough so the vendor has abandoned it and so there's no better alternative than Linux.

As for wasted talent, this industry discards skillsets just as fast as you discard e-waste. It goes with the territory. Moreover, if maintainers are not using AI to make themselves more effective then they should admit to retro-computing.

#11 lore raw
In reply to Geert Uytterhoeven
Quoted 8 lines · Geert Uytterhoeven

Hi Andrew,

Quoted 4 lines · Andrew Lunn

If the appletalk community can take the workload off the top level maintainers, respond to all patches within 2 to 3 days, give Reviewed-by, or make change requests, it can probably stay in the Mainline kernel. Otherwise it will move out of tree.

Quoted 4 lines

"2 or 3 days" is rather short. If we would have to move all code maintained by people who cannot respond to all patches within 2 to 3 days out of the mainline kernel, you'd end up with a networking subsystem without supporting OS ;-)

I do agree that every subsystem is different, but that is the speed netdev goes, often faster. There are around 150 patches a day submitted, and in order to not drown in those patches, they need to be processed fast.

It is however known for a sub-subsystem to move out of netdev to a mailing list and a git tree of its own, and just send git pull requests to netdev. It can then move at its own speed.

Andrew