Skip to contentSkip to conversation

PCI: imx6: fix building against host-common

PATCH Applied Arnd Bergmann 4 participants 4 messages Jun 16 – Jul 1

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: imx6: fix building against host-common

From: Arnd Bergmann <[email protected]>

When CONFIG_PCI_HOST_COMMON is set to =m, the i.MX6 PCIe driver fails to link. This can happen when only i.MX endpoint mode is enabled but not host mode, which would indirectly enable the host-common driver itself.

ld.lld: error: undefined symbol: pci_host_common_parse_ports

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a

ld.lld: error: undefined symbol: pci_host_common_delete_ports

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a

Select the common module from the endpoint support directly.

Fixes 250eea5c06f5 ("PCI: imx6: Parse 'reset-gpios' in Root Port nodes")
---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/Kconfig +1 -0
index aa0b784c85b4..7d49027c6736 100644
@@ -126,6 +126,7 @@ config PCI_IMX6_EP
 	depends on ARCH_MXC || COMPILE_TEST
 	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
+	select PCI_HOST_COMMON
 	select PCI_IMX6
 	help
 	  Enables support for the PCIe controller in the i.MX SoCs to
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When CONFIG_PCI_HOST_COMMON is set to =m, the i.MX6 PCIe driver fails to link. This can happen when only i.MX endpoint mode is enabled but not host mode, which would indirectly enable the host-common driver itself.

ld.lld: error: undefined symbol: pci_host_common_parse_ports

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a

ld.lld: error: undefined symbol: pci_host_common_delete_ports

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a

Quoted 5 lines

Select the common module from the endpoint support directly.

Fixes 250eea5c06f5 ("PCI: imx6: Parse 'reset-gpios' in Root Port nodes")

---

Quoted 18 lines
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/Kconfig +1 -1
index aa0b784c85b4..7d49027c6736 100644
@@ -126,6 +126,7 @@ config PCI_IMX6_EP
 	depends on ARCH_MXC || COMPILE_TEST
 	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
+	select PCI_HOST_COMMON
 	select PCI_IMX6
 	help
 	  Enables support for the PCIe controller in the i.MX SoCs to
--

2.39.5

#2 lore raw
In reply to Arnd Bergmann
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 17 lines

From: Arnd Bergmann <[email protected]>

When CONFIG_PCI_HOST_COMMON is set to =m, the i.MX6 PCIe driver fails to link. This can happen when only i.MX endpoint mode is enabled but not host mode, which would indirectly enable the host-common driver itself.

ld.lld: error: undefined symbol: pci_host_common_parse_ports

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a

ld.lld: error: undefined symbol: pci_host_common_delete_ports

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a
referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a

Quoted 4 lines

Select the common module from the endpoint support directly.

Fixes 250eea5c06f5 ("PCI: imx6: Parse 'reset-gpios' in Root Port nodes")

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#3 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

When CONFIG_PCI_HOST_COMMON is set to =m, the i.MX6 PCIe driver fails to link. This can happen when only i.MX endpoint mode is enabled but not host mode, which would indirectly enable the host-common driver itself.

ld.lld: error: undefined symbol: pci_host_common_parse_ports

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by pci-imx6.c
drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_host_init) in archive vmlinux.a

[...]

Applied, thanks!

[1/1] PCI: imx6: fix building against host-common

      commit: d4e0984f12ea958e0f2def90ddb1e193a896932b

Best regards,

Signature · 1 line
மணிவண்ணன் சதாசிவம்