vmcoreinfo: GHES: track fatal hardware errors
Subsystems (5)
cover vmcoreinfo: GHES: track fatal hardware errors
Hardware errors reported through APEI/GHES are recorded in the kernel's hwerr_data array so that crash tooling can tell from the vmcore whether a hardware error preceded a crash.
This short series improves that path:
* The first patch is just a fix.
* The second adds a HWERR_FATAL bucket that records panic-severity errors -- the ones most likely to have caused the crash -- when GHES reports them.
---
Breno Leitao (2):
ACPI: APEI: GHES: fix severity namespace in ghes_log_hwerr()
vmcore_info: track fatal hardware errors
drivers/acpi/apei/ghes.c | 7 ++++++- include/uapi/linux/vmcore.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-)
---
base-commit: 4fa3f5fabb30bf00d7475d5a33459ea83d639bf9
change-id: 20260617-hwerr-a28d5d66ae87
Best regards,
Signature · 1 line
Breno Leitao <[email protected]>
PATCH 1/2 ACPI: APEI: GHES: fix severity namespace in ghes_log_hwerr()
ghes_log_hwerr() receives a GHES_SEV_* value from ghes_severity() but tests it against CPER_SEV_RECOVERABLE. GHES_SEV_RECOVERABLE is 2 while CPER_SEV_RECOVERABLE is 0, so every recoverable error is dropped and only GHES_SEV_NO slips through; nothing useful is recorded through the APEI/GHES path, which is the only one arm64 has.
Compare against GHES_SEV_RECOVERABLE so recoverable hardware errors are tracked as intended.
--- drivers/acpi/apei/ghes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/ghes.c +1 -1
@@ -877,7 +877,7 @@ EXPORT_SYMBOL_NS_GPL(cxl_cper_kfifo_get, "CXL");static void ghes_log_hwerr (int sev,guid_t *sec_type) { -if (sev !=CPER_SEV_RECOVERABLE ) +if (sev !=GHES_SEV_RECOVERABLE )return ; if (guid_equal(sec_type, &CPER_SEC_PROC_ARM) ||
Signature · 1 line
2.53.0-Meta
PATCH 2/2 vmcore_info: track fatal hardware errors
In reply to Breno LeitaoFatal (panic-severity) hardware errors reported through APEI/GHES are the ones most likely to have caused a crash, but hwerr_data did not record them. Add a HWERR_FATAL bucket and bump it from ghes_log_hwerr() when a GHES_SEV_PANIC error is seen, so crash tooling can tell from the vmcore that a fatal hardware error preceded the crash.
Tools reading hwerr_data gain one entry (HWERR_FATAL).
--- drivers/acpi/apei/ghes.c | 5 +++++ include/uapi/linux/vmcore.h | 1 + 2 files changed, 6 insertions(+)
drivers/acpi/apei/ghes.c +5 -0
@@ -877,6 +877,11 @@ EXPORT_SYMBOL_NS_GPL(cxl_cper_kfifo_get, "CXL");static void ghes_log_hwerr (int sev,guid_t *sec_type) { +if (sev ==GHES_SEV_PANIC ) { +hwerr_log_error_type (HWERR_FATAL ); +return ; + } +if (sev !=GHES_SEV_RECOVERABLE )return ;
include/uapi/linux/vmcore.h +1 -0
@@ -21,6 +21,7 @@ enum hwerr_error_type {HWERR_RECOV_PCI ,HWERR_RECOV_CXL ,HWERR_RECOV_OTHERS , +HWERR_FATAL ,/* fatal hardware errors */ HWERR_RECOV_MAX, };
Signature · 1 line
2.53.0-Meta
Quoted 3 lines · Breno Leitao
Hardware errors reported through APEI/GHES are recorded in the kernel's
hwerr_dataarray so that crash tooling can tell from the vmcore whether a hardware error preceded a crash.
This Hardware error tracking "thing" is currently in an awkward location—it doesn't belong in RAS and has minimal connection to vmcore info.
Following Baoquan's earlier suggestion, I'll refactor this as a standalone driver, which should make the code organization clearer and more maintainable.