s390/traps: Add exception statistics
Heiko Carstens
maintainerPATCH 1/1 s390/traps: Add exception statistics
From: Sven Schnelle <[email protected]>
Add a new debugfs file which displays the number of exceptions (program checks) per CPU. This is helpful for debugging purposes.
The statistics are typically available at/sys/kernel/debug/s390/exceptions.
[ [email protected]: Forward ported code, changed file location ]
--- arch/s390/kernel/traps.c | 44 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 43 insertions(+), 1 deletion(-)
arch/s390/kernel/traps.c +43 -1
@@ -9,7 +9,9 @@* Copyright (C) 1991, 1992 Linus Torvalds */ +#include <linux/capability.h> #include <linux/cpufeature.h> +#include <linux/debugfs.h> #include <linux/kprobes.h> #include <linux/kdebug.h> #include <linux/randomize_kstack.h>
@@ -33,6 +35,12 @@#include <asm/fault.h> #include "entry.h" +struct pgm_stat { +unsigned int count[128 ]; +}; + +static DEFINE_PER_CPU_SHARED_ALIGNED(struct pgm_stat, pgm_stat); +static inline void __user *get_trap_ip (struct pt_regs *regs) {unsigned long address;
@@ -332,6 +340,7 @@ void noinstr __do_pgm_check(struct pt_regs *regs)struct lowcore *lc =get_lowcore ();bool percpu_needs_fixup;irqentry_state_t state; +struct pgm_stat *stat;unsigned int trapnr;union teid teid;
@@ -339,6 +348,10 @@ void noinstr __do_pgm_check(struct pt_regs *regs) regs->int_code = lc->pgm_int_code; regs->int_parm_long = teid.val; regs->monitor_code = lc->monitor_code; + + trapnr = regs->int_code &PGM_INT_CODE_MASK ; + stat =this_cpu_ptr (&pgm_stat); + stat->count[trapnr]++;/* * In case of a guest fault, short-circuit the fault handler and return. * This way the sie64a() function will return 0; fault address and
@@ -383,7 +396,6 @@ void noinstr __do_pgm_check(struct pt_regs *regs)if (!irqs_disabled_flags (regs->psw.mask))trace_hardirqs_on ();__arch_local_irq_ssm (regs->psw.mask & ~PSW_MASK_PER ); - trapnr = regs->int_code &PGM_INT_CODE_MASK ;if (trapnr) pgm_check_table[trapnr](regs); out:
@@ -393,6 +405,36 @@ void noinstr __do_pgm_check(struct pt_regs *regs)percpu_exit (regs, percpu_needs_fixup); } +static int pgm_check_stat_show (struct seq_file *p,void *v) +{ +int cpu, i = *(loff_t *)v; + +cpus_read_lock (); +if (i ==0 ) { +seq_puts (p," " ); +for_each_online_cpu (cpu) +seq_printf (p,"CPU%-8d" , cpu); +seq_putc (p,'\n' ); + } +for (i =0 ; i <128 ; i++) { +seq_printf (p,"%02x: " , i); +for_each_online_cpu (cpu) +seq_printf (p,"%10u " ,per_cpu (pgm_stat, cpu).count[i]); +seq_putc (p,'\n' ); + } +cpus_read_unlock (); +return 0 ; +} + +DEFINE_SHOW_ATTRIBUTE (pgm_check_stat); + +static int __init debugfs_pgm_check_init (void ) +{ +debugfs_create_file ("exceptions" ,0400 , arch_debugfs_dir,NULL , &pgm_check_stat_fops); +return 0 ; +} +late_initcall (debugfs_pgm_check_init); +/* * The program check table contains exactly 128 (0x00-0x7f) entries. Each * line defines the function to be called corresponding to the program check
Signature · 1 line
2.53.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Reading the `/sys/kernel/debug/s390/exceptions` file causes a guaranteed kernel panic because the…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Reading the /sys/kernel/debug/s390/exceptions file causes a guaranteed kernel panic because the iterator v is dereferenced despite being SEQ_START_TOKEN ((void *)1). --
commit ceb79d6258f172b6199fd66640ff5b739564b3ed
Author: Sven Schnelle <[email protected]>
s390/traps: Add exception statistics
This commit adds a new debugfs file at /sys/kernel/debug/s390/exceptions. The file displays the number of program check exceptions per CPU for debugging purposes.
Quoted 4 lines
arch/s390/kernel/traps.c +0
-0
[ ... ]
arch/s390/kernel/traps.c void noinstr __do_pgm_check(struct pt_regs *regs) · line 410
Quoted 7 lines
arch/s390/kernel/traps.c +3
-0@@ -393,6 +405,36 @@ void noinstr __do_pgm_check(struct pt_regs *regs)percpu_exit (regs, percpu_needs_fixup); } +static int pgm_check_stat_show (struct seq_file *p,void *v) +{ +int cpu, i = *(loff_t *)v;
[Severity: High]
Will reading this debugfs file cause a kernel panic?
Since DEFINE_SHOW_ATTRIBUTE(pgm_check_stat) is used below, the file operations are created using single_open(). The show callback for single_open() seq_files is always passed SEQ_START_TOKEN (defined as ((void *)1)) as its iterator argument v.
Dereferencing v here via *(loff_t *)v will attempt to read from memory address 0x1, which would result in an unhandled page fault and kernel panic.
Quoted 19 lines
arch/s390/kernel/traps.c +19
-0+ +cpus_read_lock (); +if (i ==0 ) { +seq_puts (p," " ); +for_each_online_cpu (cpu) +seq_printf (p,"CPU%-8d" , cpu); +seq_putc (p,'\n' ); + } +for (i =0 ; i <128 ; i++) { +seq_printf (p,"%02x: " , i); +for_each_online_cpu (cpu) +seq_printf (p,"%10u " ,per_cpu (pgm_stat, cpu).count[i]); +seq_putc (p,'\n' ); + } +cpus_read_unlock (); +return 0 ; +} + +DEFINE_SHOW_ATTRIBUTE (pgm_check_stat);
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1