staging: octeon: is the FIXME in cvm_oct_sgmii_init stale?

Hi Greg,

While looking at drivers/staging/octeon/ethernet-sgmii.c I noticed a FIXME comment in cvm_oct_sgmii_init():

    cvm_oct_common_init(dev);
    /* FIXME: Need autoneg logic */
    return 0;

After tracing the code, I believe autoneg is already handled when the interface is opened:

cvm_oct_sgmii_open()

      -> cvm_oct_common_open()
          -> cvm_oct_phy_setup_device()
              -> phy_start()
                  -> phy_state_machine()
                      -> _phy_start_aneg()
                          -> genphy_config_aneg()

Is my analysis correct? If so, should I send a patch to remove the stale FIXME comment?

Thanks,
Pablo D. Bergamasco

I have no idea, sorry, test it out on the hardware and see!

thanks,

greg k-h