Skip to contentSkip to conversation

remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev

PATCH Applied Uday Khare 3 participants 3 messages Jun 18 – Jul 10

Subsystems (2)
lore
Share & tools
lore

Uday Khare

author
#0 lore raw

PATCH 1/4 remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev

In qcom_add_glink_subdev(), the device node reference acquired via of_get_child_by_name() is stored in glink->node. If the subsequent kstrdup_const() allocation for glink->ssr_name fails, the function returns early without calling of_node_put() on glink->node, leaking the reference count.

Fix this by adding of_node_put(glink->node) on the error path before returning.

Fixes cd9fc8f1b35b ("remoteproc: qcom: Pass ssr_name to glink subdevice")
---
 drivers/remoteproc/qcom_common.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/remoteproc/qcom_common.c +3 -1
index fd2b6824ad26..8af90d4bdbdf 100644
@@ -247,8 +247,10 @@ void qcom_add_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink,
 		return;
 
 	glink->ssr_name = kstrdup_const(ssr_name, GFP_KERNEL);
-	if (!glink->ssr_name)
+	if (!glink->ssr_name) {
+		of_node_put(glink->node);
 		return;
+	}
 
 	glink->dev = dev;
 	glink->subdev.start = glink_subdev_start;
Signature · 1 line
2.54.0
#1 lore raw

Re: (subset) [PATCH 1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev

Quoted 1 line · Uday Khare

remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.3

Thanks!

[4/4] regulator: tps6594: Fix device node reference leaks in multiphase loop

      https://git.kernel.org/broonie/regulator/c/7fd28093b3ef

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

maintainer Applied
#2 lore raw

Re: (subset) [PATCH 1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev

In reply to Uday Khare
Quoted 10 lines · Uday Khare

In qcom_add_glink_subdev(), the device node reference acquired via of_get_child_by_name() is stored in glink->node. If the subsequent kstrdup_const() allocation for glink->ssr_name fails, the function returns early without calling of_node_put() on glink->node, leaking the reference count.

Fix this by adding of_node_put(glink->node) on the error path before returning.

[...]

Applied, thanks!

[1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev

      commit: ed5dd2a9b716568ff7d6446322ee60846af313aa

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>