KVM: x86: Bug the VM, not the kernel, if the ISR count {under,over}flows
Sean Christopherson
maintainerPATCH 1/1 KVM: x86: Bug the VM, not the kernel, if the ISR count {under,over}flows
Bug the VM, not the host kernel, if KVM's ISR count {under,over}flows when tracking in-flight ISRs. There is zero danger to the host if KVM messes up its IRQ tracking.
Signed-off-by Sean Christopherson <[email protected]>
--- arch/x86/kvm/lapic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kvm/lapic.c +2 -2
@@ -767,7 +767,7 @@ static inline void apic_set_isr(int vec, struct kvm_lapic *apic)kvm_x86_call (hwapic_isr_update)(apic->vcpu, vec); else { ++apic->isr_count; -BUG_ON (apic->isr_count >MAX_APIC_VECTOR ); +KVM_BUG_ON (apic->isr_count >MAX_APIC_VECTOR , apic->vcpu->kvm);/* * ISR (in service register) bit is set when injecting an interrupt. * The highest vector is injected. Thus the latest bit set matches
@@ -808,7 +808,7 @@ static inline void apic_clear_isr(int vec, struct kvm_lapic *apic)kvm_x86_call (hwapic_isr_update)(apic->vcpu,apic_find_highest_isr (apic)); else { --apic->isr_count; -BUG_ON (apic->isr_count <0 ); +KVM_BUG_ON (apic->isr_count <0 , apic->vcpu->kvm); apic->highest_isr_cache =-1 ; } }
base-commit: 9d4853b044beefa21c4ee3e18c40653601a64ced
Signature · 1 line
2.55.0.rc0.738.g0c8ab3ebcc-goog
Quoted 5 lines · Sean Christopherson
Bug the VM, not the host kernel, if KVM's ISR count {under,over}flows when tracking in-flight ISRs. There is zero danger to the host if KVM messes up its IRQ tracking.
Signed-off-by Sean Christopherson <[email protected]>
Reviewed-by Kai Huang <[email protected]>
Queued, thanks.
Paolo