Skip to contentSkip to conversation

docs: ipmi: Fix path of the "hotmod" module parameter

PATCH In review Zenghui Yu 3 participants 5 messages Jun 20 – Jun 21

Subsystems (2)
lore
Share & tools
lore

Zenghui Yu

author
#0 lore raw

PATCH 1/1 docs: ipmi: Fix path of the "hotmod" module parameter

The correct path of the "hotmod" module parameter should be /sys/module/ipmi_si/parameters/hotmod. Fix it.

---
 Documentation/driver-api/ipmi.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/driver-api/ipmi.rst +1 -1
index f52ab2df2569..d08cee98e34a 100644
@@ -495,7 +495,7 @@ tuned to the user's desired performance.
 
 The driver supports a hot add and remove of interfaces.  This way,
 interfaces can be added or removed after the kernel is up and running.
-This is done using /sys/modules/ipmi_si/parameters/hotmod, which is a
+This is done using /sys/module/ipmi_si/parameters/hotmod, which is a
 write-only parameter.  You write a string to this interface.  The string
 has the format::
 
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 2 lines · Zenghui Yu

The correct path of the "hotmod" module parameter should be /sys/module/ipmi_si/parameters/hotmod. Fix it.

Thanks, it's in my queue.

-corey

Quoted 22 lines
---
 Documentation/driver-api/ipmi.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/driver-api/ipmi.rst +1 -1
index f52ab2df2569..d08cee98e34a 100644
@@ -495,7 +495,7 @@ tuned to the user's desired performance.
 
 The driver supports a hot add and remove of interfaces.  This way,
 interfaces can be added or removed after the kernel is up and running.
-This is done using /sys/modules/ipmi_si/parameters/hotmod, which is a
+This is done using /sys/module/ipmi_si/parameters/hotmod, which is a
 write-only parameter.  You write a string to this interface.  The string
 has the format::
 
Signature · 1 line
2.53.0
reviewer
#2 lore raw
In reply to Zenghui Yu
Quoted 7 lines · Zenghui Yu

The correct path of the "hotmod" module parameter should be /sys/module/ipmi_si/parameters/hotmod. Fix it.

---
 Documentation/driver-api/ipmi.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

There are several other places that use /sys/modules/ instead of /sys/module/.

Would you care to fix those also?

thanks.

Signature · 1 line
~Randy
author
#3 lore raw
Quoted 6 lines · Randy Dunlap
Quoted 3 lines · Zenghui Yu

The correct path of the "hotmod" module parameter should be /sys/module/ipmi_si/parameters/hotmod. Fix it.

Quoted 7 lines
Quoted 4 lines
---
 Documentation/driver-api/ipmi.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

There are several other places that use /sys/modules/ instead of /sys/module/.

Yup. There are:

Documentation/driver-api/ipmi.rst:This is done using /sys/modules/ipmi_si/parameters/hotmod, which is a Documentation/process/debugging/kgdb.rst:config string to ``/sys/module/<driver>/parameter/<option>``. The driver Documentation/translations/zh_CN/admin-guide/mm/damon/lru_sort.rst:参数,或者在 ``/sys/modules/damon_lru_sort/parameters/<parameter>`` 写入正确的
Documentation/translations/zh_CN/admin-guide/mm/damon/lru_sort.rst: # cd /sys/modules/damon_lru_sort/parameters
Documentation/translations/zh_TW/admin-guide/mm/damon/lru_sort.rst:參數,或者在 ``/sys/modules/damon_lru_sort/parameters/<parameter>`` 寫入正確的
Documentation/translations/zh_TW/admin-guide/mm/damon/lru_sort.rst: # cd /sys/modules/damon_lru_sort/parameters
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/debug_layer
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/debug_level
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/trace_method_name
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/trace_state
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/trace_debug_layer
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/trace_debug_level
drivers/acpi/sysfs.c:/* /sys/modules/acpi/parameters/aml_debug_output */
drivers/base/module.c: /* Lookup or create built-in module entry in /sys/modules */
drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c: * On the fly: echo {0,1,2} > /sys/modules/lpvo_usb_gpib/parameters/debug
fs/btrfs/sysfs.c:/* Set perms to 0, disable /sys/module/btrfs/parameter/read_policy interface. */
fs/cachefiles/Kconfig: enabled by setting bits in /sys/modules/cachefiles/parameter/debug or
kernel/params.c:/* sysfs output in /sys/modules/XYZ/parameters/ */

Quoted 2 lines

Would you care to fix those also?

I plan to fix them by subsystem like:

https://lore.kernel.org/[email protected]

Thanks,
Zenghui

reviewer
#4 lore raw
Quoted 37 lines · Zenghui Yu
Quoted 6 lines · Randy Dunlap
Quoted 3 lines · Zenghui Yu

The correct path of the "hotmod" module parameter should be /sys/module/ipmi_si/parameters/hotmod. Fix it.

Quoted 7 lines
Quoted 4 lines
---
 Documentation/driver-api/ipmi.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

There are several other places that use /sys/modules/ instead of /sys/module/.

Yup. There are:

Documentation/driver-api/ipmi.rst:This is done using /sys/modules/ipmi_si/parameters/hotmod, which is a Documentation/process/debugging/kgdb.rst:config string to ``/sys/module/<driver>/parameter/<option>``. The driver Documentation/translations/zh_CN/admin-guide/mm/damon/lru_sort.rst:参数,或者在 ``/sys/modules/damon_lru_sort/parameters/<parameter>`` 写入正确的
Documentation/translations/zh_CN/admin-guide/mm/damon/lru_sort.rst: # cd /sys/modules/damon_lru_sort/parameters
Documentation/translations/zh_TW/admin-guide/mm/damon/lru_sort.rst:參數,或者在 ``/sys/modules/damon_lru_sort/parameters/<parameter>`` 寫入正確的
Documentation/translations/zh_TW/admin-guide/mm/damon/lru_sort.rst: # cd /sys/modules/damon_lru_sort/parameters
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/debug_layer
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/debug_level
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/trace_method_name
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/trace_state
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/trace_debug_layer
drivers/acpi/sysfs.c: * /sys/modules/acpi/parameters/trace_debug_level
drivers/acpi/sysfs.c:/* /sys/modules/acpi/parameters/aml_debug_output */
drivers/base/module.c: /* Lookup or create built-in module entry in /sys/modules */
drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c: * On the fly: echo {0,1,2} > /sys/modules/lpvo_usb_gpib/parameters/debug
fs/btrfs/sysfs.c:/* Set perms to 0, disable /sys/module/btrfs/parameter/read_policy interface. */
fs/cachefiles/Kconfig: enabled by setting bits in /sys/modules/cachefiles/parameter/debug or
kernel/params.c:/* sysfs output in /sys/modules/XYZ/parameters/ */

Quoted 1 line
Quoted 5 lines
Quoted 1 line

Would you care to fix those also?

I plan to fix them by subsystem like:

https://lore.kernel.org/[email protected]

Great. Thanks.

Signature · 1 line
~Randy