ioctl10: fix the sscanf() call to handle 64-bit inode on 32-bit arch
PATCH 1/1 ioctl10: fix the sscanf() call to handle 64-bit inode on 32-bit arch
This test started failing recently on arm32, when we switched the kernel to displaying the full 64-bit inode number in the maps file. Change the testcase to allow for a full 64-bit inode number on all arches. The value it's compared to is already 64-bits, so widening this field is all that is necessary.
--- testcases/kernel/syscalls/ioctl/ioctl10.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/syscalls/ioctl/ioctl10.c +2 -2
@@ -35,7 +35,7 @@ struct map_entry {unsigned long vm_pgoff;unsigned int vm_major;unsigned int vm_minor; -unsigned long vm_inode; +uint64_t vm_inode;char vm_name[256 ];unsigned int vm_flags; };
@@ -68,7 +68,7 @@ static void parse_maps_file(const char *filename, const char *keyword, struct mawhile (fgets (line,sizeof (line), fp) !=NULL ) {if (fnmatch (keyword, line,0 ) ==0 ) { -if (sscanf (line,"%lx-%lx %s %lx %x:%x %lu %s" , +if (sscanf (line,"%lx-%lx %s %lx %x:%x %llu %s" , &entry->vm_start, &entry->vm_end, entry->vm_flags_str, &entry->vm_pgoff, &entry->vm_major, &entry->vm_minor, &entry->vm_inode, entry->vm_name) <7 )
---
base-commit: 534222c4f3908e9642f913399e37a66fdd266bbe
change-id: 20260626-master-55d29494ba06
Best regards,
Signature · 5 lines
Jeff Layton <[email protected]> -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Jeff,
testcases/kernel/syscalls/ioctl/ioctl10.c static void parse_maps_file(const char *filename, const char *keyword, struct ma · line 71
Quoted 7 lines · Jeff Layton
ioctl10: fix the
sscanf()call to handle 64-bit inode on 32-bit archtestcases/kernel/syscalls/ioctl/ioctl10.c +2
-2-unsigned long vm_inode; +uint64_t vm_inode; - if (sscanf(line, "%lx-%lx %s %lx %x:%x %lu %s", + if (sscanf(line, "%lx-%lx %s %lx %x:%x %llu %s",
The type change to uint64_t is correct, but %llu is the format specifier for unsigned long long, not for uint64_t. On LP64 platforms (x86_64, aarch64), uint64_t is unsigned long, so passing a uint64_t * where sscanf expects unsigned long long * is undefined behavior and will produce -Wformat warnings on 64-bit builds.
The portable fix is to use SCNu64 from <inttypes.h>:
if (sscanf(line, "%lx-%lx %s %lx %x:%x %" SCNu64 " %s",
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp