Skip to contentSkip to conversation

wifi: cfg80211: bound element ID read when checking non-inheritance

PATCH Superseded HE WEI (ギカク) 2 participants 5 messages Jun 26 – Jul 7 802.11 (including cfg80211/NL80211)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wifi: cfg80211: bound element ID read when checking non-inheritance

cfg80211_is_element_inherited() reads the first data octet of the candidate element (id = elem->data[0]) to look it up in an extension non-inheritance list. It does so after testing elem->id, but without verifying that the element actually has a data octet. A zero-length extension element (WLAN_EID_EXTENSION with length 0) therefore makes it read one octet past the end of the element.

_ieee802_11_parse_elems_full() runs this check for every element of a frame once a non-inheritance context exists -- e.g. while parsing a per-STA profile of a Multi-Link element in a (re)association response, or a non-transmitted BSS profile -- so a crafted frame from an AP can trigger a one-octet slab-out-of-bounds read during element parsing:

  BUG: KASAN: slab-out-of-bounds in cfg80211_is_element_inherited
  Read of size 1 ... in net/wireless/scan.c

Return early (treat the element as inherited) when an extension element carries no data, mirroring the existing handling of empty ID lists.

The bug was found by fuzzing ieee802_11_parse_elems_full() under KASAN.

Fixes dfd9aa3e7a45 ("wifi: cfg80211: rewrite merging of inherited elements")
---
 net/wireless/scan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/wireless/scan.c +1 -1
index 05b7dc6b7..0a44856b1 100644
@@ -205,7 +205,7 @@ bool cfg80211_is_element_inherited(const struct element *elem,
 		return true;
 
 	if (elem->id == WLAN_EID_EXTENSION) {
-		if (!ext_id_len)
+		if (!ext_id_len || !elem->datalen)
 			return true;
 		loop_len = ext_id_len;
 		list = &non_inherit_elem->data[3 + id_len];
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 2 lines · HE WEI (ギカク)
Fixes dfd9aa3e7a45 ("wifi: cfg80211: rewrite merging of inherited elements")

This doesn't seem right at all?

johannes

#2 lore raw

Hi Johannes,

I'm sorry, that was my oversight. After reconfirmation, I found that cfg80211_is_element_inherited() was introduced in commit f7dacfb11475b ("cfg80211: support non-inheritance element"), not dfd9aa3e7a45.

The bug existed from the initial implementation of this function in 2019. I will send v2 with the correct Fixes tag.

Thank you for catching this!

Best regards,
HE WEI(ギカク)

Quoted 9 lines · Johannes Berg <[email protected]> 于2026年7月6日周一 20:44写道:
Quoted 2 lines · HE WEI (ギカク)
Fixes dfd9aa3e7a45 ("wifi: cfg80211: rewrite merging of inherited elements")

This doesn't seem right at all?

johannes

#3 lore raw

PATCH v2 1/1 wifi: cfg80211: bound element ID read when checking non-inheritance

In reply to HE WEI (ギカク)

cfg80211_is_element_inherited() reads the first data octet of the candidate element (id = elem->data[0]) to look it up in an extension non-inheritance list. It does so after testing elem->id, but without verifying that the element actually has a data octet. A zero-length extension element (WLAN_EID_EXTENSION with length 0) therefore makes it read one octet past the end of the element.

_ieee802_11_parse_elems_full() runs this check for every element of a frame once a non-inheritance context exists -- e.g. while parsing a per-STA profile of a Multi-Link element in a (re)association response, or a non-transmitted BSS profile -- so a crafted frame from an AP can trigger a one-octet slab-out-of-bounds read during element parsing:

  BUG: KASAN: slab-out-of-bounds in cfg80211_is_element_inherited
  Read of size 1 ... in net/wireless/scan.c

Return early (treat the element as inherited) when an extension element carries no data, mirroring the existing handling of empty ID lists.

The bug was found by fuzzing ieee802_11_parse_elems_full() under KASAN.

Changes in v2:
- Fixed the Fixes tag to point to the correct commit f7dacfb11475b ("cfg80211: support non-inheritance element")
- The bug was introduced in the original implementation in 2019, not in commit dfd9aa3e7a45

Fixes f7dacfb11475b ("cfg80211: support non-inheritance element")
---
 net/wireless/scan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/wireless/scan.c +1 -1
index 05b7dc6b7..0a44856b1 100644
@@ -205,7 +205,7 @@ bool cfg80211_is_element_inherited(const struct element *elem,
 		return true;
 
 	if (elem->id == WLAN_EID_EXTENSION) {
-		if (!ext_id_len)
+		if (!ext_id_len || !elem->datalen)
 			return true;
 		loop_len = ext_id_len;
 		list = &non_inherit_elem->data[3 + id_len];
Signature · 1 line
2.43.0
#4 lore raw

PATCH v3 1/1 wifi: cfg80211: bound element ID read when checking non-inheritance

In reply to HE WEI (ギカク)

cfg80211_is_element_inherited() reads the first data octet of the candidate element (id = elem->data[0]) to look it up in an extension non-inheritance list. It does so after testing elem->id, but without verifying that the element actually has a data octet. A zero-length extension element (WLAN_EID_EXTENSION with length 0) therefore makes it read one octet past the end of the element.

_ieee802_11_parse_elems_full() runs this check for every element of a frame once a non-inheritance context exists -- e.g. while parsing a per-STA profile of a Multi-Link element in a (re)association response, or a non-transmitted BSS profile -- so a crafted frame from an AP can trigger a one-octet slab-out-of-bounds read during element parsing:

  BUG: KASAN: slab-out-of-bounds in cfg80211_is_element_inherited
  Read of size 1 ... in net/wireless/scan.c

Return early (treat the element as inherited) when an extension element carries no data, mirroring the existing handling of empty ID lists.

The bug was found by fuzzing ieee802_11_parse_elems_full() under KASAN.

Fixes f7dacfb11475 ("cfg80211: support non-inheritance element")

---
Changes in v3:
- Move the version changelog below the --- line and trim the Fixes commit id to 12 characters (checkpatch).

Changes in v2:
- Correct the Fixes tag. The unchecked elem->data[0] read was introduced in 2019 by f7dacfb11475 ("cfg80211: support non-inheritance element") -- the commit that added cfg80211_is_element_inherited() -- not by dfd9aa3e7a45, which only rewrote the sibling cfg80211_gen_new_ie() and never touched this function.

 net/wireless/scan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/wireless/scan.c +1 -1
index 05b7dc6b7..0a44856b1 100644
@@ -205,7 +205,7 @@ bool cfg80211_is_element_inherited(const struct element *elem,
 		return true;
 
 	if (elem->id == WLAN_EID_EXTENSION) {
-		if (!ext_id_len)
+		if (!ext_id_len || !elem->datalen)
 			return true;
 		loop_len = ext_id_len;
 		list = &non_inherit_elem->data[3 + id_len];

--
2.43.0