Skip to contentSkip to conversation

rust: aref: make `AlwaysRefCounted::inc_ref` an associated function

PATCH Lorenzo Delgado 1 participant 1 message Jun 27 Rust

lore
Share & tools
lore
#0 lore raw

Hi Trevor,

Are you still planning a v4 of this? It went quiet after the v3 review, and the patch no longer applies to current rust-next: the aref.rs imports were reorganized, AlwaysRefCounted moved from crate::types to sync::aref, and several new implementors have landed that the conversion needs to cover (i2c, usb, pwm, drm/gpuvm).

If you'd rather not carry it further, I'm glad to take it over: rebase onto rust-next, convert the new implementors, fold in the v3 feedback (the doc note, with "accidentally" rather than "lightly"), and re-confirm the Acks. I'd keep you as the author via From:, with myself as Co-developed-by.

Either way is fine. Just let me know if you'd prefer to send v4 yourself.

Thanks,
Lorenzo