Skip to contentSkip to conversation

staging: rtl8723bs: remove unnecessary braces in rtw_wlan_util

PATCH In review Ruziev Miraly 2 participants 2 messages Jun 29 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8723bs: remove unnecessary braces in rtw_wlan_util

Remove unnecessary braces from a single statement block in rtw_wlan_util.c to conform to the kernel coding style.

Changes in v2:
- Drop changes to rtw_xmit.c because the removed NULL check was actually a false positive by checkpatch.pl, and removing the if-block broke the mandatory goto logic. Focus only on rtw_wlan_util.c now.

---
 drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +1 -2
index 1d37c2d5b..cc05decd4 100644
@@ -256,9 +256,8 @@ inline void rtw_set_oper_ch(struct adapter *adapter, u8 ch)
 {
 	struct dvobj_priv *dvobj = adapter_to_dvobj(adapter);
 
-	if (dvobj->oper_channel != ch) {
+	if (dvobj->oper_channel != ch)
 		dvobj->on_oper_ch_time = jiffies;
-	}
 
 	dvobj->oper_channel = ch;
 }
Signature · 1 line
2.54.0
#1 lore raw
Quoted 10 lines · Ruziev Miraly

Remove unnecessary braces from a single statement block in rtw_wlan_util.c to conform to the kernel coding style.

Changes in v2:
- Drop changes to rtw_xmit.c because the removed NULL check was actually a false positive by checkpatch.pl, and removing the if-block broke the mandatory goto logic. Focus only on rtw_wlan_util.c now.

---

There is a specific format for a v2.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Please wait a day between resends otherwise it's overwhelming to reviewers.

regards,
dan carpenter