Skip to contentSkip to conversation

ASoC: amd: yc: Add Alienware m15 R7 AMD to DMIC quirk table

PATCH In review Jetha Chan 3 participants 3 messages Jun 30 – Jul 1

Subsystems (3)
lore
Share & tools
lore

Jetha Chan

author
#0 lore raw

PATCH 1/1 ASoC: amd: yc: Add Alienware m15 R7 AMD to DMIC quirk table

The Alienware m15 R7 AMD exposes an ACP6x DMIC path, but its DMI product name is not present in the Yellow Carp ACP quirk table. As a result, the ACP machine driver does not enable the DMIC card on this system.

Add the DMI product name for this machine. With this quirk applied, the kernel reports:

acp_yc_mach acp_yc_mach.0: Enabling ACP DMIC support via DMI

and ALSA exposes the ACP DMIC capture device:

card 3: acp6x
device 0: DMIC capture dmic-hifi-0

Tested on an Alienware m15 R7 AMD with product SKU 0B59.

---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -0
index 000000000000..000000000000 100644
@@ -504,6 +504,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 		.driver_data = &acp6x_card,
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "Alienware"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Alienware m15 R7 AMD"),
+		}
+	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Alienware"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Alienware m17 R5 AMD"),
 		}
 	},
Signature · 1 line
2.50.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Jetha Chan

[You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

The Alienware m15 R7 AMD exposes an ACP6x DMIC path, but its DMI product name is not present in the Yellow Carp ACP quirk table. As a result, the ACP machine driver does not enable the DMIC card on this system.

Add the DMI product name for this machine. With this quirk applied, the kernel reports:

acp_yc_mach acp_yc_mach.0: Enabling ACP DMIC support via DMI

and ALSA exposes the ACP DMIC capture device:

Quoted 8 lines

card 3: acp6x
device 0: DMIC capture dmic-hifi-0

Tested on an Alienware m15 R7 AMD with product SKU 0B59.

Quoted 24 lines
---
  sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
  1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -1
index 000000000000..000000000000 100644
@@ -504,6 +504,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
                 .driver_data = &acp6x_card,
                 .matches = {
                         DMI_MATCH(DMI_BOARD_VENDOR, "Alienware"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "Alienware m15 R7 AMD"),
+               }
+       },
+       {
+               .driver_data = &acp6x_card,
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "Alienware"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Alienware m17 R5 AMD"),
                 }
         },
--

2.50.0

maintainer
#2 lore raw
In reply to Jetha Chan
Quoted 1 line · Jetha Chan

ASoC: amd: yc: Add Alienware m15 R7 AMD to DMIC quirk table

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2

Thanks!

[1/1] ASoC: amd: yc: Add Alienware m15 R7 AMD to DMIC quirk table

      https://git.kernel.org/broonie/sound/c/e782d687d2f5

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark