Skip to contentSkip to conversation

lan966x pci device: Add support for SFPs, clock dependency part

PATCH Superseded Herve Codina 2 participants 5 messages Jun 30 – Jul 17 Common clk

v8 of 14 Superseded Latest is v14 →

lore
Share & tools
lore
#0 lore raw

v8 cover lan966x pci device: Add support for SFPs, clock dependency part

Hi,

Previously, I sent a big picture series adding support for SFP ports available on the LAN966x PCI device [0].

In this series patches touch several parts and sub-system in the kernel. Reviews have be done and it makes sense to split the series and send parts separately.

This current series is the extraction of a patch related to a clock build dependency issues.

[0] https://lore.kernel.org/all/[email protected]/

Best regards,
Hervé

Changes:

v7 -> v8
v7: https://lore.kernel.org/all/[email protected]/

Rebase on top of v7.2-rc1
No other changes

v6 -> v7

Rebase on top of v7.1-rc1

- Patch 1
No changes

Older iterations:
Patches 18 in the big picture series
https://lore.kernel.org/all/[email protected]/

Herve Codina (1):
clk: lan966x: Add MCHP_LAN966X_PCI dependency

 drivers/clk/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.54.0
#1 lore raw

PATCH v8 1/1 clk: lan966x: Add MCHP_LAN966X_PCI dependency

The lan966x clock controller depends on the LAN969x architecture or the LAN966x SoC.

This clock controller can be used by the LAN966x PCI device and so it needs to be available when the LAN966x PCI device is enabled.

---
 drivers/clk/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/Kconfig +1 -1
index 1717ce75a907..682840e67798 100644
@@ -278,7 +278,7 @@ config COMMON_CLK_LAN966X
 	tristate "Generic Clock Controller driver for LAN966X SoC"
 	depends on HAS_IOMEM
 	depends on OF
-	depends on SOC_LAN966 || ARCH_LAN969X || COMPILE_TEST
+	depends on SOC_LAN966 || ARCH_LAN969X || MCHP_LAN966X_PCI || COMPILE_TEST
 	help
 	  This driver provides support for Generic Clock Controller(GCK) on
 	  LAN966X SoC. GCK generates and supplies clock to various peripherals
Signature · 1 line
2.54.0
Reviewed-by on v8 1/1
#2 lore raw

Re: [PATCH v8 1/1] clk: lan966x: Add MCHP_LAN966X_PCI dependency

Quoted 8 lines · Herve Codina

The lan966x clock controller depends on the LAN969x architecture or the LAN966x SoC.

This clock controller can be used by the LAN966x PCI device and so it needs to be available when the LAN966x PCI device is enabled.

#3 lore raw

Re: [PATCH v8 1/1] clk: lan966x: Add MCHP_LAN966X_PCI dependency

Hi Maintainers,

Quoted 4 lines · On Mon, 6 Jul 2026 12:49:30 -0400 Brian Masney <[email protected]> wrote:
Quoted 3 lines · Herve Codina

The lan966x clock controller depends on the LAN969x architecture or the LAN966x SoC.

Quoted 8 lines
Quoted 5 lines

This clock controller can be used by the LAN966x PCI device and so it needs to be available when the LAN966x PCI device is enabled.

IMHO, this patch is ready to be applied.

Let me know if I need to do anything else on my side to move forward.

Best regards,
Hervé

#4 lore raw

Re: [PATCH v8 1/1] clk: lan966x: Add MCHP_LAN966X_PCI dependency

Hi Herve,

Quoted 13 lines · Herve Codina
Quoted 10 lines · On Mon, 6 Jul 2026 12:49:30 -0400 Brian Masney <[email protected]> wrote:
Quoted 8 lines · Herve Codina

The lan966x clock controller depends on the LAN969x architecture or the LAN966x SoC.

This clock controller can be used by the LAN966x PCI device and so it needs to be available when the LAN966x PCI device is enabled.

Quoted 6 lines
Quoted 2 lines

IMHO, this patch is ready to be applied.

Let me know if I need to do anything else on my side to move forward.

I'm not sure when Stephen will start collecting patches this development cycle. If I don't hear from him by rc6, then I'm going to send him a pull with patches that I've reviewed where there is no clk submaintainer. I plan to include this patch. I'll be honest, I'm not sure if he'll pull, but I'll try.

Brian